[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Mark Johnston  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|ma...@freebsd.org

--- Comment #17 from Mark Johnston  ---
(In reply to Mitchell Horne from comment #15)
One problem with this patch is that clear_inheritance_flags() updates the
global ACE rather than making a copy.  This basically means that setfacl -R
can't reliably be used to recursively set inheritance flags for subdirectories.
 With that fixed I think the patch is reasonable.  I'll take care of getting it
committed and adding some regression tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Ed Maste  changed:

   What|Removed |Added

 Blocks||228911

--- Comment #16 from Ed Maste  ---
Tag as a FreeBSD 12 issue as the change is currently partially complete in
HEAD.


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228911
[Bug 228911] FreeBSD 12.0 Release action items
-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Ed Maste  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2299
   ||30

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #15 from Mitchell Horne  ---
(In reply to Shawn Webb from comment #14)

I've submitted a review to https://reviews.freebsd.org/D15061 containing the
changes from your original patch which seems to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Mitchell Horne  changed:

   What|Removed |Added

 CC||mhorne...@gmail.com

--- Comment #13 from Mitchell Horne  ---
(In reply to Shawn Webb from comment #12)

Are you sure this isn't an existing issue? After enabling NFSv4 ACLs on UFS I
get the same error both pre and post patch, regardless of -R.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #12 from Shawn Webb  ---
(In reply to commit-hook from comment #11)
The new version of the recursive patch does not remove the inheritance flags
from files, so when you do something like:

setfacl -R -m everyone@:full_set:fd:allow /some/path

You get the following error:

setfacl: /usr/src2/tools/tools/track/track.sh: acl_set_link_np() failed:
Invalid argument

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Ed Maste  changed:

   What|Removed |Added

  Flags||mfc-stable10-,
   ||mfc-stable11?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #11 from commit-h...@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Tue Apr 10 23:29:57 UTC 2018
New revision: 332396
URL: https://svnweb.freebsd.org/changeset/base/332396

Log:
  setfacl: add recursive functionality

  Add a -R option to setfacl to operate recursively on directories, along
  with the accompanying flags -H, -L, and -P (whose behaviour mimics
  chmod).

  A patch was submitted with PR 155163, but this is a new implementation
  based on comments raised in the Phabricator review for that patch
  (review D9096).

  PR:   155163
  Submitted by: Mitchell Horne 
  Reviewed by:  jilles
  MFC after:2 weeks
  Relnotes: Yes
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D14934

Changes:
  head/bin/setfacl/setfacl.1
  head/bin/setfacl/setfacl.c
  head/bin/setfacl/setfacl.h
  head/bin/setfacl/util.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #10 from Ed Maste  ---
Updated patch in review at https://reviews.freebsd.org/D14934

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Ed Maste  changed:

   What|Removed |Added

 CC||ema...@freebsd.org

--- Comment #9 from Ed Maste  ---
This is open for review in https://reviews.freebsd.org/D9096, and it is
currently blocked on issues raised in that review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #8 from Shawn Webb  ---
Hey Allan, have you had a chance to look at this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Shawn Webb  changed:

   What|Removed |Added

 Attachment #151059|0   |1
is obsolete||

--- Comment #7 from Shawn Webb  ---
Created attachment 177998
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=177998=edit
Add recurisve support to setfacl(1)

Update the patch to reflect latest HEAD.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #5 from cl...@clintarmstrong.net ---
Is testing and work on this patch still in progress? The inability to
recursively set ACLs on FreeBSD is quite an annoyance and I was going to open
my own bug report on it when I found this one already open.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

--- Comment #6 from Shawn Webb shawn.w...@hardenedbsd.org ---
The patch I submitted in December of last year works well in HardenedBSD.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

latt...@gmail.com changed:

   What|Removed |Added

 Attachment #113589|0   |1
is obsolete||

--- Comment #4 from latt...@gmail.com ---
Created attachment 151059
  -- https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151059action=edit
Add recursive support to setfacl(1)

Manpage still needs to be updated. This patch works against 11-CURRENT.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org

[Bug 155163] [patch] Add Recursive Functionality to setfacl(1)

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=155163

Edward Tomasz Napierala tr...@freebsd.org changed:

   What|Removed |Added

   Assignee|tr...@freebsd.org   |freebsd-bugs@FreeBSD.org

--- Comment #3 from Edward Tomasz Napierala tr...@freebsd.org ---
Disown.  I don't even remember how that code works anymore.  One potential
problem with this code that it used fts to build a list of all paths in the
tree, instead of using fts to iterate over the tree, and that could fail due to
out of memory condition.  That said, it doesn't look critical, and that's also
how setfacl works right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to freebsd-bugs-unsubscr...@freebsd.org