https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Kubilay Kocak changed:
What|Removed |Added
Flags|mfc-stable12? |mfc-stable12+,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #17 from Sean Eric Fagan ---
If you needed to test for that specific error case, that seems sufficient. But
you'd also only want to check for that on a ZFS data set.
--
You are receiving this mail because:
You are the
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #16 from Timur I. Bakeyev ---
Sean, so would it be sufficient to put in tho the client code something like:
+#if defined(__FreeBSD__) && ((__FreeBSD_version >= 1102503 &&
__FreeBSD_version <= 1102506) || (__FreeBSD_version >=
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #15 from commit-h...@freebsd.org ---
A commit references this bug:
Author: sef
Date: Thu Jan 31 22:08:02 UTC 2019
New revision: 343624
URL: https://svnweb.freebsd.org/changeset/base/343624
Log:
MFC r342928:
Change ZFS
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #14 from commit-h...@freebsd.org ---
A commit references this bug:
Author: sef
Date: Thu Jan 31 22:06:47 UTC 2019
New revision: 343623
URL: https://svnweb.freebsd.org/changeset/base/343623
Log:
MFC r342928:
Change ZFS
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Dries Michiels changed:
What|Removed |Added
Flags||mfc-stable12?
--
You are
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Sean Eric Fagan changed:
What|Removed |Added
Resolution|--- |FIXED
Status|New
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #12 from Mark Johnston ---
(In reply to Sean Eric Fagan from comment #11)
LGTM, thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
___
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Mark Linimon changed:
What|Removed |Added
Keywords||patch
--
You are receiving this
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #11 from Sean Eric Fagan ---
Created attachment 201007
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201007=edit
Return EINVAL if no quotas are present
Obviously I have no objection to this ;).
--
You are
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #10 from Mark Johnston ---
(In reply to topical from comment #9)
I don't think it makes sense to return EOPNOTSUPP when Q_GETQUOTA fails because
no quota is configured. UFS already uses EINVAL in this case, and it is in
fact
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
topical changed:
What|Removed |Added
CC||topi...@gmx.net
--- Comment #9 from
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #8 from Sean Eric Fagan ---
(In reply to Emrion from comment #7)
That's a good question. I picked ENOENT because of similarity to other code,
but going with UFS compatibility is a stronger argument.
The main intended use for
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #7 from Emrion ---
(In reply to Mark Johnston from comment #6)
Sorry, I didn't understand your question. Now, you've seen the concerned
snippet code of Samba or the code I posted here for testing purpose. It's
actually
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #6 from Mark Johnston ---
(In reply to Emrion from comment #5)
I was wondering specifically which quotactl() operation was returning ENOENT.
It's a bit more clear now; we have the following in zfs_getquota():
146 if
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #5 from Emrion ---
(In reply to Mark Johnston from comment #4)
I wrote it in my first post (sorry for the double post by the way): it's Samba
which don't handle the error returned by 12.0-RELEASE (ENOENT) and flood tty0
with
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Mark Johnston changed:
What|Removed |Added
CC||ma...@freebsd.org,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #3 from Emrion ---
Reading the man page of quotactl(), I came to the conclusion that it shouldn't
return ENOENT nor ENOTSUP (EOPNOTSUPP) but rather EINVAL error in the case the
file system isn't ufs. ENOTSUP seems reserved when
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Emrion changed:
What|Removed |Added
Attachment #200570|text/x-csrc |text/plain
mime type|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
--- Comment #1 from Emrion ---
This issue is visible when samba operates on a zfs file system but I think it
has issued more problems.
When a call to quotactl() is made on a zfs dataset, the error generated under
11.2 FreeBSD is:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413
Bug ID: 234413
Summary: quotactl() returns wrong error
Product: Base System
Version: 12.0-RELEASE
Hardware: Any
OS: Any
Status: New
Severity:
21 matches
Mail list logo
