[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 Mark Johnston changed: What|Removed |Added Status|New |In Progress Assignee|b...@freebsd.org|ma...@freebsd.org CC||ma...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 --- Comment #5 from commit-h...@freebsd.org --- A commit references this bug: Author: markj Date: Mon Jun 3 16:51:07 UTC 2019 New revision: 348547 URL: https://svnweb.freebsd.org/changeset/base/348547 Log: rpc.yppasswdd: Fix dirname(3) usage after r305952. PR: 234972 Submitted by: Edward Fuhr (original) MFC after:3 days Changes: head/usr.sbin/rpc.yppasswdd/yppasswdd_server.c -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 u.drolsha...@t-online.de changed: What|Removed |Added CC||u.drolsha...@t-online.de --- Comment #4 from u.drolsha...@t-online.de --- I am running into the same problem on a recently installed box running 12.0-stable. I'd like to know if it's to be expected that this bug gets fixed offically any time soon. Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 --- Comment #3 from Bernard Marshall --- (In reply to Edward Fuhr from comment #2) Thanks for looking into this Edward. A quick comment on your patch. I think you have forgotten to initialise "passdir_buf" in "yppasswdproc_update_master_1_svc". I suspect you need to add: /* Hold a copy of the passfile in passdir */ snprintf(passdir_buf, sizeof(passdir_buf), "%s", passfile); passdir = (char *)_buf; around line 831 in the current file, otherwise passdir_buf will not be initialised with passfile. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 Mark Linimon changed: What|Removed |Added Keywords||patch -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 Edward Fuhr changed: What|Removed |Added CC||edward.f...@us.fujitsu.com --- Comment #1 from Edward Fuhr --- Created attachment 201374 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201374=edit Fixes issue when rpc.yppasswdd fails to copy master.passwd As of FreeBSD 12.0 rpc.yppasswdd was failing to copy the master.passwd file due to call pw_init truncating the filename value stored in passfile This fix copies the value of passfile to a temporary variable, passdir. This prevents passfile from being truncated while also allowing the necessary directory name to be passed. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 --- Comment #2 from Edward Fuhr --- (In reply to Edward Fuhr from comment #1) I wish it to be known that this is my own amateur-hour patch, and in no way should this be considered an official patch. I thought the description was for the file and not to replace the blurb previously written up specifying this is NOT an official patch, but my own doing. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972 Mark Linimon changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-bugs@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
[Bug 234972] yppasswdd cannot update passwd (rename of /var/yp to /var/yp/master. passwd.hold failed)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234972
Bug ID: 234972
Summary: yppasswdd cannot update passwd (rename of /var/yp to
/var/yp/master. passwd.hold failed)
Product: Base System
Version: 12.0-RELEASE
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: bin
Assignee: b...@freebsd.org
Reporter: bernard.marsh...@axiell.com
After upgrading to 12.0 RELEASE the yppasswdd RPC no longer updates passwords
successfully. When trying to update a password the following is output:
$ passwd fred
Changing NIS password for fred
New Password:
Retype New Password:
passwd: pam_chauthtok(): Error in service module
A check of /var/log/messages shows one of the following errors depending on
whether the -t option was set for nis_yppasswdd_flags in /etc/rc.conf:
rename of / to /.hold failed
rename of /var to /var/yp.hold failed
rename of /var/yp to /var/yp/master.passwd.hold failed
The error is in /usr/src/usr.sbin/rpc.yppasswdd/yppasswdd_server.c where
dirname() is used twice (line 609 and 832). Both lines have the code:
if (pw_init(dirname(passfile), passfile)) {
It looks like the implementation of dirname in 12.0 RELEASE has changed to now
apply changes to the string passed into the function. The change is to make the
call thread safe according to the updated manual entry. The problem here is
that the call to dirname() now truncates "passfile" meaning the variable no
longer holds the path to the master password file, rather just the directory
and hence the error.
In order to use dirname() now "passfile" will need to be copied before being
passed into dirname().
--
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
