[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

Kubilay Kocak  changed:

   What|Removed |Added

 Status|New |Open
 CC||gleb...@freebsd.org,
   ||melif...@freebsd.org,
   ||n...@freebsd.org
  Flags||maintainer-feedback?(melifa
   ||r...@freebsd.org),
   ||maintainer-feedback?(glebiu
   ||s...@freebsd.org),
   ||mfc-stable11?,
   ||mfc-stable12?
 Blocks||240700
   Keywords|panic, patch|needs-qa
   Assignee|b...@freebsd.org|n...@freebsd.org

--- Comment #4 from Kubilay Kocak  ---
Crash report with patch on stable/12, potential 12.1-R candidate

CC recent committers around that section of code


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240700
[Bug 240700] [META] FreeBSD 12.1-RELEASE blockers
-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

Andrey Linkevich  changed:

   What|Removed |Added

   Keywords||crash, panic, patch
 CC||d...@cyberpunk.ru

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

--- Comment #3 from Andrey Linkevich  ---
Created attachment 208240
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208240=edit
Patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

--- Comment #2 from Andrey Linkevich  ---
Created attachment 208239
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208239=edit
Panic screenshot, 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

--- Comment #1 from Andrey Linkevich  ---
Created attachment 208238
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208238=edit
Panic screenshot, 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


[Bug 241191] route flush panic with RADIX_MPATH

2019-10-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241191

Bug ID: 241191
   Summary: route flush panic with RADIX_MPATH
   Product: Base System
   Version: 12.0-STABLE
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Some People
  Priority: ---
 Component: kern
  Assignee: b...@freebsd.org
  Reporter: d...@cyberpunk.ru

Hello, Colleagues.

We are use RADIX_MPATH .
Have a lot of IPv4 route multipath.

Our FreeBSD 12.0-STABLE is panic when execute `route flush`. (See details and
screenshots)

The problem is caused by incorrect processing of return rt_unlinkrte() from
sys/net/route.c .

With RADIX_MPATH return may be _NULL_ with *perror = 0.

Than rtrequest1_fib() from sys/net/route.c is panic;
Also route_output() from sys/net/rtsock.c .

I prepared the patch.
Please check it out. If he does not contradict anything, then accept.

Perhaps patch creates some other problems. However, patch solves the original
problem successfully.

Thanks.


Add details.

root@noc-srr01:~ # sysctl kern | grep kern.os
kern.ostype: FreeBSD
kern.osrelease: 12.0-STABLE
kern.osrevision: 199506
kern.osreldate: 1200503


Example 1: WITHOUT kernel options RADIX_MPATH

# A lot of routes
root@noc-srr01:/boot/kernel # netstat -rnW | wc -l
   16132

# 
root@noc-srr01:/boot/kernel # netstat -rnW | more
Routing tables

Internet:
DestinationGatewayFlags   UseMtu  Netif Expire
default10.169.211.1   UGS3945   1500xn0
1.1.2.0/30 10.169.213.234 UG1   0   1500xn1
1.2.2.0/30 10.169.213.234 UG1   0   1500xn1
1.2.3.0/30 10.169.213.234 UG1   0   1500xn1
...

# Work flush correctly
root@noc-srr01:/boot/kernel # netstat -rn | wc -l ; route -qn flush ; netstat
-rn | wc -l
   16132
 23


Example 2: WITH kernel options RADIX_MPATH

# A lot of routes (16000 * 4 ifs and routers)
root@noc-srr01:~ # netstat -rn | wc -l
   63595

# 
root@noc-srr01:~ # netstat -rn | more
Routing tables

Internet:
DestinationGatewayFlags Netif Expire
default10.169.211.1   UGS xn0
1.1.2.0/30 10.169.213.234 UG1 xn1
1.1.2.0/30 10.169.213.242 UG1 xn2
1.1.2.0/30 10.169.213.233 UG1 xn1
1.1.2.0/30 10.169.213.241 UG1 xn2
1.2.2.0/30 10.169.213.234 UG1 xn1
1.2.2.0/30 10.169.213.242 UG1 xn2
1.2.2.0/30 10.169.213.233 UG1 xn1
1.2.2.0/30 10.169.213.241 UG1 xn2
1.2.3.0/30 10.169.213.234 UG1 xn1
1.2.3.0/30 10.169.213.242 UG1 xn2
1.2.3.0/30 10.169.213.233 UG1 xn1
1.2.3.0/30 10.169.213.241 UG1 xn2

# flush panic ... see ScreenShots in attach
root@noc-srr01:~ # netstat -rn | wc -l ; route -qn flush ; netstat -rn | wc -l
   63599

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"