Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-28 Thread Dmitry Marakasov
* Dmitry Marakasov (amd...@amdmi3.ru) wrote: The patch is complete, see https://reviews.freebsd.org/D1600. - With it, for all knobs from src.conf(5) there are no difference in file tree contents between `KNOB make installworld` and `make installworld KNOB make delete-old delete-old-libs` -

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-25 Thread Jakub Lach
In other words, if a user has some WITHOUT_* set in src.conf, specific files are not installed by installworld, but not removed by remove-old, which I try to fix. Please carry on, I saw quite a few times that this behaviour was assumed by new users, only it is not (yet), to their surprise :)

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-24 Thread Dmitry Marakasov
* Garrett Cooper (yaneurab...@gmail.com) wrote: Hi Dmitry, Seems like we’ve duplicated work a bit. Have you looked at ^/projects/building-blocks yet ? Hm, seems so, partly. How do you gather missing entries? My way is pretty dumb, I just do bunch of installworlds + delete-old's

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-24 Thread Dmitry Marakasov
* Dmitry Marakasov (amdmi3@hades.panopticon) wrote: Also there is a question of delete-old-dirs removing directories which are created by mtree run by installworld unconditionally. This seems to be incorrect - either directories should be installed conditionally or not removed by

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-23 Thread Garrett Cooper
On Jan 23, 2015, at 16:29, Dmitry Marakasov amd...@amdmi3.ru wrote: Hi! Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which allows make delete-old / delete-old-libs / delete-old-dirs targets completelty remove files which are normally installed

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-23 Thread Garrett Cooper
On Jan 23, 2015, at 17:20, Garrett Cooper yaneurab...@gmail.com wrote: On Jan 23, 2015, at 17:16, Dmitry Marakasov amd...@amdmi3.ru wrote: * Garrett Cooper (yaneurab...@gmail.com) wrote: Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-23 Thread Dmitry Marakasov
* Garrett Cooper (yaneurab...@gmail.com) wrote: Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which allows make delete-old / delete-old-libs / delete-old-dirs targets completelty remove files which are normally installed when specific src.conf

Re: OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-23 Thread Garrett Cooper
On Jan 23, 2015, at 17:16, Dmitry Marakasov amd...@amdmi3.ru wrote: * Garrett Cooper (yaneurab...@gmail.com) wrote: Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which allows make delete-old / delete-old-libs / delete-old-dirs targets completelty

OptionalObsoleteFiles.inc completeness improvement, try 2

2015-01-23 Thread Dmitry Marakasov
Hi! Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which allows make delete-old / delete-old-libs / delete-old-dirs targets completelty remove files which are normally installed when specific src.conf WITHOUT_* knobs are set. In other words, if a user

Re: OptionalObsoleteFiles.inc completeness

2012-06-07 Thread Dmitry Marakasov
* Dmitry Marakasov (amd...@amdmi3.ru) wrote: So would someone please commit it? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber: amd...@jabber.ruhttp://www.amdmi3.ru ___

Re: OptionalObsoleteFiles.inc completeness

2012-06-01 Thread Ulrich Spörlein
On Fri, 2012-06-01 at 07:20:42 +1000, Peter Jeremy wrote: On 2012-May-30 13:27:03 +1000, Peter Jeremy pe...@rulingia.com wrote: On 2012-May-29 02:18:25 +0400, Dmitry Marakasov amd...@amdmi3.ru wrote: Then you should try to profile it - my script basically runs delete-old delete-old-libs for

Re: OptionalObsoleteFiles.inc completeness

2012-06-01 Thread Peter Jeremy
On 2012-Jun-01 20:50:24 +0200, Ulrich Spörlein u...@freebsd.org wrote: Why is xargs even calling /bin/echo when utility is not specified. Because that's what it's documented as doing. Shouldn't it just print a certain number of arguments (one in this case)? The current approach is simpler -

Re: OptionalObsoleteFiles.inc completeness

2012-05-31 Thread Peter Jeremy
On 2012-May-30 13:27:03 +1000, Peter Jeremy pe...@rulingia.com wrote: On 2012-May-29 02:18:25 +0400, Dmitry Marakasov amd...@amdmi3.ru wrote: Then you should try to profile it - my script basically runs delete-old delete-old-libs for every knob (131 of them), and it hadn't taken more than 4

Re: OptionalObsoleteFiles.inc completeness

2012-05-29 Thread Peter Jeremy
On 2012-May-29 02:18:25 +0400, Dmitry Marakasov amd...@amdmi3.ru wrote: * Peter Jeremy (pe...@rulingia.com) wrote: My experience is that it now takes about 2½ minutes on 10.x with warm caches, compared to less than 1 second on 8.x. Now = after applying my patch or after changing system? Which

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Doug Barton
On 05/27/2012 07:05, Dmitry Marakasov wrote: Hi! I'm running a little pet project of improving completeness of tools/build/mk/OptionalObsoleteFiles.inc file and thus delete-old* targets with regard to all possible WITHOUT_* knobs. E.g. when WITHOUT_foo is defined in src.conf, make

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Peter Jeremy
On 2012-May-27 18:05:41 +0400, Dmitry Marakasov amd...@amdmi3.ru wrote: 2) Is this ok to backport the list from current to stable branches? Pro - it's really simple, con - it will contain files never installed with this (old) branch. Another con: make delete-old on -current takes about 2 orders

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Jakub Lach
I'm pro improving completeness, as most people are really surprised when after setting WITHOUT* they are left with old cruft from first install, what's more important- it's getting left as is with all possible (security) bugs. Just be careful, as after recent expansion it looked here like

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Dmitry Marakasov
* Doug Barton (do...@freebsd.org) wrote: I'm running a little pet project of improving completeness of tools/build/mk/OptionalObsoleteFiles.inc file and thus delete-old* targets with regard to all possible WITHOUT_* knobs. E.g. when WITHOUT_foo is defined in src.conf, make delete-old

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Dmitry Marakasov
* Peter Jeremy (pe...@rulingia.com) wrote: 2) Is this ok to backport the list from current to stable branches? Pro - it's really simple, con - it will contain files never installed with this (old) branch. Another con: make delete-old on -current takes about 2 orders of magnitude longer to

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Doug Barton
On 05/28/2012 12:52, Dmitry Marakasov wrote: * Doug Barton (do...@freebsd.org) wrote: I'm running a little pet project of improving completeness of tools/build/mk/OptionalObsoleteFiles.inc file and thus delete-old* targets with regard to all possible WITHOUT_* knobs. E.g. when WITHOUT_foo

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Peter Jeremy
On 2012-May-28 23:55:42 +0400, Dmitry Marakasov amd...@amdmi3.ru wrote: * Peter Jeremy (pe...@rulingia.com) wrote: 2) Is this ok to backport the list from current to stable branches? Pro - it's really simple, con - it will contain files never installed with this (old) branch. Another con:

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Alexander Leidinger
On Mon, 28 May 2012 12:59:17 -0700 Doug Barton do...@freebsd.org wrote: this issue. The numerous problems we've had with it ever since it was introduced seem to bear me out. :) Can you list them? A missing obsolete file doesn't count. Bye, Alexander. -- http://www.Leidinger.netAlexander

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Alexander Leidinger
On Tue, 29 May 2012 06:04:03 +1000 Peter Jeremy pe...@rulingia.com wrote: My experience is that it now takes about 2½ minutes on 10.x with warm caches, compared to less than 1 second on 8.x. For most of that time, there's no output and there's no warning of the increased time. I actually

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Doug Barton
On 05/28/2012 13:23, Alexander Leidinger wrote: On Mon, 28 May 2012 12:59:17 -0700 Doug Barton do...@freebsd.org wrote: this issue. The numerous problems we've had with it ever since it was introduced seem to bear me out. :) Can you list them? A missing obsolete file doesn't count. It

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Dmitry Marakasov
* Doug Barton (do...@freebsd.org) wrote: this issue. The numerous problems we've had with it ever since it was introduced seem to bear me out. :) Can you list them? A missing obsolete file doesn't count. It doesn't catch things it needs to It catches things it shouldn't The current

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Dmitry Marakasov
* Peter Jeremy (pe...@rulingia.com) wrote: 2) Is this ok to backport the list from current to stable branches? Pro - it's really simple, con - it will contain files never installed with this (old) branch. Another con: make delete-old on -current takes about 2 orders of magnitude

Re: OptionalObsoleteFiles.inc completeness

2012-05-28 Thread Doug Barton
On 5/28/2012 3:05 PM, Dmitry Marakasov wrote: * Doug Barton (do...@freebsd.org) wrote: this issue. The numerous problems we've had with it ever since it was introduced seem to bear me out. :) Can you list them? A missing obsolete file doesn't count. It doesn't catch things it needs to It

OptionalObsoleteFiles.inc completeness

2012-05-27 Thread Dmitry Marakasov
Hi! I'm running a little pet project of improving completeness of tools/build/mk/OptionalObsoleteFiles.inc file and thus delete-old* targets with regard to all possible WITHOUT_* knobs. E.g. when WITHOUT_foo is defined in src.conf, make delete-old should remove related files completely, to make