Re: ZFS TRIM support committed to HEAD.

2012-09-25 Thread Lev Serebryakov
Hello, Pawel. You wrote 23 сентября 2012 г., 23:53:58: PJD FYI, I just committed TRIM support to ZFS, especially useful for PJD SSD-only pools. This is something I implemented long time ago, but was PJD now motivated to get back to it and commit it finally by some great PJD fixes and improvements

Re: ZFS TRIM support committed to HEAD.

2012-09-25 Thread Bob Bishop
On 25 Sep 2012, at 06:40, Pawel Jakub Dawidek wrote: On Tue, Sep 25, 2012 at 12:14:24AM +0100, Bob Bishop wrote: Hi, Still seems to be working OK, but: seagoon# zpool status pool: m1 state: ONLINE status: One or more devices has experienced an unrecoverable error. An attempt

Re: ZFS TRIM support committed to HEAD.

2012-09-25 Thread Bob Bishop
On 25 Sep 2012, at 06:40, Pawel Jakub Dawidek wrote: On Tue, Sep 25, 2012 at 12:14:24AM +0100, Bob Bishop wrote: Hi, Still seems to be working OK, but: seagoon# zpool status pool: m1 state: ONLINE status: One or more devices has experienced an unrecoverable error. An attempt

Re: ZFS TRIM support committed to HEAD.

2012-09-25 Thread Pawel Jakub Dawidek
On Sun, Sep 23, 2012 at 08:20:41PM -0400, Glen Barber wrote: Hi Pawel, On Sun, Sep 23, 2012 at 09:53:58PM +0200, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. This is something I implemented long time ago, but was now

Re: ZFS TRIM support committed to HEAD.

2012-09-25 Thread Miroslav Lachman
Pawel Jakub Dawidek wrote: On Sun, Sep 23, 2012 at 08:20:41PM -0400, Glen Barber wrote: Hi Pawel, [...] Great! Thanks for this. Any chance you can document the following sysctls? None od the kstat sysctls are documented, they emulate kstat framework from Solaris. We would need to modify

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Charles Sprickman sp...@bway.net Are you aware of anyone that will be trying this in production, and if so, will you be able to give us list denizens any feedback on it? Yes we've been using it in production for a few months now, but only on single disk

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Charles Sprickman
On Sep 23, 2012, at 6:25 PM, Pawel Jakub Dawidek wrote: On Sun, Sep 23, 2012 at 10:24:53PM +0100, Bob Bishop wrote: Hi, On 23 Sep 2012, at 20:53, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. [etc] Is any of this applicable

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Charles Sprickman sp...@bway.net I have a patch against stable/8, but not stable/9: http://people.freebsd.org/~pjd/patches/zfstrim8.patch Are you aware of anyone that will be trying this in production, and if so, will you be able to give us list denizens

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Ollivier Robert
According to Steven Hartland: We applied the patch to a 8.3-RELEASE based install with additional patches including patches to provide TRIM support for CAM da devices via SATA pass-through including full support for security and identify commands in camcontrol. If anyone would like those as

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Ollivier Robert robe...@keltia.freenix.fr According to Steven Hartland: We applied the patch to a 8.3-RELEASE based install with additional patches including patches to provide TRIM support for CAM da devices via SATA pass-through including full support for

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Bob Bishop
Hi, On 23 Sep 2012, at 23:25, Pawel Jakub Dawidek wrote: I have a patch against stable/8, but not stable/9: http://people.freebsd.org/~pjd/patches/zfstrim8.patch Running with that in an otherwise 8-STABLE GENERIC amd64 kernel, I'm getting: kstat.zfs.misc.zio_trim.zio_trim_bytes: 0

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Bob Bishop r...@gid.co.uk To: Pawel Jakub Dawidek p...@freebsd.org Cc: freebsd-current@freebsd.org; freebsd...@freebsd.org; Steven Hartland kill...@multiplay.co.uk Sent: Monday, September 24, 2012 3:17 PM Subject: Re: ZFS TRIM support committed to HEAD. Hi

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Bob Bishop
PM Subject: Re: ZFS TRIM support committed to HEAD. Hi, On 23 Sep 2012, at 23:25, Pawel Jakub Dawidek wrote: I have a patch against stable/8, but not stable/9: http://people.freebsd.org/~pjd/patches/zfstrim8.patch Running with that in an otherwise 8-STABLE GENERIC amd64 kernel, I'm getting

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Pawel Jakub Dawidek
, 2012 3:17 PM Subject: Re: ZFS TRIM support committed to HEAD. Hi, On 23 Sep 2012, at 23:25, Pawel Jakub Dawidek wrote: I have a patch against stable/8, but not stable/9: http://people.freebsd.org/~pjd/patches/zfstrim8.patch Running with that in an otherwise 8-STABLE

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Bob Bishop
Hi, On 24 Sep 2012, at 16:55, Steven Hartland wrote: Don't think ad supports TRIM, switch to ada (ahci) and you should be good. Switched to AHCI and now looks more plausible: kstat.zfs.misc.zio_trim.zio_trim_bytes: 2173466624 kstat.zfs.misc.zio_trim.zio_trim_success: 13244

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Pawel Jakub Dawidek p...@freebsd.org Although I'm surprised your seeing that many reported failures as it should have disabled it on a pool level after the first few failures. Is it still increasing? Note that 'failed' count is increasing, not the

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Bob Bishop
Hi, Still seems to be working OK, but: seagoon# zpool status pool: m1 state: ONLINE status: One or more devices has experienced an unrecoverable error. An attempt was made to correct the error. Applications are unaffected. action: Determine if the device needs to be replaced, and

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Ryan Stone
On Mon, Sep 24, 2012 at 1:03 PM, Steven Hartland kill...@multiplay.co.uk wrote: Ahh yes looks like ATA supports BIO_DELETE via ATA_CFA_ERASE if the drive announces ATA_PROTO_CFA, so I can only assume this is failing when it shouldn't. Might be nice to investigate what's happening and fix, but

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Steven Hartland
- Original Message - From: Ryan Stone Ahh yes looks like ATA supports BIO_DELETE via ATA_CFA_ERASE if the drive announces ATA_PROTO_CFA, so I can only assume this is failing when it shouldn't. Might be nice to investigate what's happening and fix, but as ATA is being replaced by CAM

Re: ZFS TRIM support committed to HEAD.

2012-09-24 Thread Pawel Jakub Dawidek
On Tue, Sep 25, 2012 at 12:14:24AM +0100, Bob Bishop wrote: Hi, Still seems to be working OK, but: seagoon# zpool status pool: m1 state: ONLINE status: One or more devices has experienced an unrecoverable error. An attempt was made to correct the error. Applications are

ZFS TRIM support committed to HEAD.

2012-09-23 Thread Pawel Jakub Dawidek
FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. This is something I implemented long time ago, but was now motivated to get back to it and commit it finally by some great fixes and improvements from the zfsonlinux project (made by Etienne Dechamps). Note that this

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread Bob Bishop
Hi, On 23 Sep 2012, at 20:53, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. [etc] Is any of this applicable to -STABLE or 8.x? -- Bob Bishop r...@gid.co.uk ___

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread Pawel Jakub Dawidek
On Sun, Sep 23, 2012 at 10:24:53PM +0100, Bob Bishop wrote: Hi, On 23 Sep 2012, at 20:53, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. [etc] Is any of this applicable to -STABLE or 8.x? I have a patch against stable/8,

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread George Kontostanos
On Mon, Sep 24, 2012 at 1:25 AM, Pawel Jakub Dawidek p...@freebsd.org wrote: On Sun, Sep 23, 2012 at 10:24:53PM +0100, Bob Bishop wrote: Hi, On 23 Sep 2012, at 20:53, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. [etc] Is any

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread Glen Barber
Hi Pawel, On Sun, Sep 23, 2012 at 09:53:58PM +0200, Pawel Jakub Dawidek wrote: FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. This is something I implemented long time ago, but was now motivated to get back to it and commit it finally by some great fixes and

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread Mark Felder
Is this making it TRIM aware globally -- even on your cache and log devices? ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to

Re: ZFS TRIM support committed to HEAD.

2012-09-23 Thread Marcelo Araujo
2012/9/24 Pawel Jakub Dawidek p...@freebsd.org FYI, I just committed TRIM support to ZFS, especially useful for SSD-only pools. This is something I implemented long time ago, but was now motivated to get back to it and commit it finally by some great fixes and improvements from the zfsonlinux