[head tinderbox] failure on i386/i386

2013-12-24 Thread FreeBSD Tinderbox
TB --- 2013-12-24 07:00:20 - tinderbox 2.20 running on freebsd-current.sentex.ca TB --- 2013-12-24 07:00:20 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 d...@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB ---

[PATCH RFC 03/13] xen: mask event channels while changing affinity

2013-12-24 Thread Roger Pau Monne
Event channels should be masked while chaning affinity, or else we might get spurious/lost interrupts. --- sys/x86/xen/xen_intr.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c index fd36e68..bc0781e 100644

[PATCH RFC 02/13] ioapic: introduce hooks for some ioapic ops

2013-12-24 Thread Roger Pau Monne
Create some hooks for IO APIC operations that will diverge from bare metal when implemented for Xen Dom0. This patch should not introduce any changes in functionality, it's a preparatory patch for the implementation of the Xen IO APIC hooks. --- sys/amd64/include/apicvar.h | 13

[PATCH RFC 05/13] xen: implement Xen IO APIC ops

2013-12-24 Thread Roger Pau Monne
Implement a different set of hooks for IO APIC to use when running under Xen Dom0. --- sys/x86/xen/pv.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/sys/x86/xen/pv.c b/sys/x86/xen/pv.c index ab4afba..e5ad200 100644 ---

[PATCH RFC 06/13] xen: Dom0 console fixes

2013-12-24 Thread Roger Pau Monne
Minor fixes and workarounds to make the Xen Dom0 console work. --- sys/dev/xen/console/xencons_ring.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/sys/dev/xen/console/xencons_ring.c b/sys/dev/xen/console/xencons_ring.c index d826363..ea97f7b 100644 ---

[PATCH RFC 01/13] xen: use the hardware e820 map on Dom0

2013-12-24 Thread Roger Pau Monne
We need to do some tweaking of the hardware e820 map, since the memory layout provided by Xen and the e820 map doesn't match. This consists in clamping the e820 map so that regions above max_pfn are marked as unusuable. --- sys/x86/xen/pv.c | 35 +-- 1 files

[PATCH RFC 07/13] xen: implement IO APIC support in Xen mptable parser

2013-12-24 Thread Roger Pau Monne
Use madt_setup_io (from madt.c) on Xen apic_enumerator, in order to parse the interrupt sources from the IO APIC. I would like to get opinions, but I think we should rename and move madt_setup_io to io_apic.c. --- sys/amd64/include/apicvar.h |1 + sys/i386/include/apicvar.h |1 +

[PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2013-12-24 Thread Roger Pau Monne
Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can force the usage of the Xen mptable enumerator even when ACPI is detected. --- sys/x86/acpica/madt.c |2 +- sys/x86/xen/mptable.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/x86/acpica/madt.c

[PATCH RFC 13/13] xenstore: changes needed to boot in Dom0 mode

2013-12-24 Thread Roger Pau Monne
This patch includes changes to xenstore in order to boot as Dom0. This is different from booting as a guest, since when booted as Dom0 xenstore is not available. This patch sets up a memory page, an event channel for xenstore and disables xenbus device probing at boot. It contains a workaround for

[PATCH RFC 11/13] pci: introduce a new event on PCI device detection

2013-12-24 Thread Roger Pau Monne
Add a new event that will fire each time a PCI device is added to the system, and allows us to register the device with Xen. --- sys/dev/pci/pci.c |1 + sys/sys/eventhandler.h |5 + sys/x86/xen/pv.c| 21 + sys/x86/xen/xen_nexus.c |6 ++

[PATCH RFC 12/13] mca: disable cmc enable on Xen PV

2013-12-24 Thread Roger Pau Monne
Xen PV guests doesn't have a lapic, so disable the lapic call in mca initialization. --- sys/x86/x86/mca.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index f1369cd..e9d2c1d 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c

[PATCH RFC 10/13] xen: add ACPI bus to xen_nexus when running as Dom0

2013-12-24 Thread Roger Pau Monne
Also disable a couple of ACPI devices that are not usable under Dom0. --- sys/x86/xen/xen_nexus.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/sys/x86/xen/xen_nexus.c b/sys/x86/xen/xen_nexus.c index 288e6b6..823b3bc 100644 ---

Re: [head tinderbox] failure on i386/i386

2013-12-24 Thread John Baldwin
On Monday, December 23, 2013 6:21:30 pm FreeBSD Tinderbox wrote: TB --- 2013-12-23 19:50:20 - tinderbox 2.20 running on freebsd- current.sentex.ca TB --- 2013-12-23 19:50:20 - FreeBSD freebsd-current.sentex.ca 8.3- PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012

Re: [PATCH v7 03/19] xen: add and enable Xen console for PVH guests

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:40 pm Roger Pau Monne wrote: diff --git a/sys/dev/xen/console/console.c b/sys/dev/xen/console/console.c index 23eaee2..e8079da 100644 --- a/sys/dev/xen/console/console.c +++ b/sys/dev/xen/console/console.c @@ -69,11 +69,14 @@ struct mtx cn_mtx;

Re: [PATCH v7 02/19] xen: add macro to detect if running as Dom0

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:39 pm Roger Pau Monne wrote: --- sys/xen/xen-os.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/sys/xen/xen-os.h b/sys/xen/xen-os.h index c7474d8..e8a5a99 100644 --- a/sys/xen/xen-os.h +++ b/sys/xen/xen-os.h @@ -82,6

Re: [PATCH v7 04/19] amd64: introduce hook for custom preload metadata parsers

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:41 pm Roger Pau Monne wrote: --- /dev/null +++ b/sys/xen/pv.h @@ -0,0 +1,28 @@ +/* + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the Software), to + * deal in

Re: [PATCH v7 06/19] xen: implement an early timer for Xen PVH

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:43 pm Roger Pau Monne wrote: When running as a PVH guest, there's no emulated i8254, so we need to use the Xen PV timer as the early source for DELAY. This change allows for different implementations of the early DELAY function and implements a Xen variant

Re: [PATCH v7 05/19] xen: rework xen timer so it can be used early in boot process

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:42 pm Roger Pau Monne wrote: This should not introduce any functional change, and makes the functions suitable to be called before we have actually mapped the vcpu_info struct on a per-cpu basis. Looks fine to me. -- John Baldwin

Re: [PATCH v7 11/19] xen: changes to hvm code in order to support PVH guests

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:48 pm Roger Pau Monne wrote: On PVH we don't need to init the shared info page, or disable emulated devices. Also, make sure PV IPIs are set before starting the APs. Looks ok to me. -- John Baldwin ___

Re: [PATCH v7 16/19] xen: add shutdown hook for PVH

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:53 pm Roger Pau Monne wrote: Add the PV shutdown hook to PVH. --- sys/dev/xen/control/control.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) This looks fine to me. -- John Baldwin

Re: [PATCH v7 08/19] xen: use the same hypercall mechanism for XEN and XENHVM

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:45 pm Roger Pau Monne wrote: --- sys/amd64/include/xen/hypercall.h |7 --- sys/i386/i386/locore.s|9 + sys/i386/include/xen/hypercall.h |8 sys/x86/xen/hvm.c | 24 ++-- 4

Re: [PATCH v7 13/19] xen: introduce flag to disable the local apic

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:50 pm Roger Pau Monne wrote: PVH guests don't have an emulated lapic. Since the tests all use '!lapic_disabled' I think I would prefer to flip the name to 'lapic_valid' and have it default to true. It would just be a cosmetic change to the current patch,

Re: [PATCH v7 15/19] xen: create a Xen nexus to use in PV/PVH

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:52 pm Roger Pau Monne wrote: Introduce a Xen specific nexus that is going to be in charge for attaching Xen specific devices. Remove the identify routine from Xen devices and instead attach them from the nexus (PV/PVH) or xenpci (HVM). As with my previous

Re: [PATCH v7 17/19] xen: xenstore changes to support PVH

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:54 pm Roger Pau Monne wrote: --- sys/xen/xenstore/xenstore.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) This looks fine modulo possibly making it a xenpv child instead of a nexus child. Note that even in the old XEN

Re: [PATCH v7 19/19] isa: allow ISA bus to attach to the nexus

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:56 pm Roger Pau Monne wrote: --- sys/x86/isa/isa.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) If you go the xenpv route, you would replace 'nexus' with 'xenpv' here. diff --git a/sys/x86/isa/isa.c b/sys/x86/isa/isa.c index

Re: [PATCH v7 18/19] xen: changes to gnttab for PVH

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:55 pm Roger Pau Monne wrote: --- sys/xen/gnttab.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) I can't really speak to the correctness of this as I don't know the Xen internals well enough, but I don't see anything

Re: [PATCH v7 14/19] xen: introduce a dummy pvcpu device

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:51 pm Roger Pau Monne wrote: Since Xen PVH guests doesn't have ACPI, we need to create a dummy pvcpu device that will be used to fill the pcpu-pc_device field. Rather than have this hang directly off of nexus0, it might be better to create some sort of

Re: [PATCH v7 12/19] xen: add a hook to perform AP startup

2013-12-24 Thread John Baldwin
On Thursday, December 19, 2013 1:54:49 pm Roger Pau Monne wrote: AP startup on PVH follows the PV method, so we need to add a hook in order to diverge from bare metal. --- +int native_start_all_aps(void); + Please put this in a header instead of using an extern in the Xen PV code.

Re: [PATCH v7 04/19] amd64: introduce hook for custom preload metadata parsers

2013-12-24 Thread Roger Pau Monné
On 24/12/13 16:47, John Baldwin wrote: On Thursday, December 19, 2013 1:54:41 pm Roger Pau Monne wrote: --- /dev/null +++ b/sys/xen/pv.h @@ -0,0 +1,28 @@ +/* + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation

Re: [PATCH v7 04/19] amd64: introduce hook for custom preload metadata parsers

2013-12-24 Thread John Baldwin
On Tuesday, December 24, 2013 11:47:53 am Roger Pau Monné wrote: On 24/12/13 16:47, John Baldwin wrote: On Thursday, December 19, 2013 1:54:41 pm Roger Pau Monne wrote: --- /dev/null +++ b/sys/xen/pv.h @@ -0,0 +1,28 @@ +/* + * Permission is hereby granted, free of charge, to any

Re: new Xorg (KMS, etc.) for Radeon 9600

2013-12-24 Thread dt71
John Baldwin wrote, On 12/23/2013 17:50: It needs fixing, but the fix needs to be correct. Though a fix should not be delayed by decades... ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To

[PATCH RFC] Disable save-entropy in jails

2013-12-24 Thread Xin Li
Hi, I think we shouldn't save entropy inside jails, as the data is not going to be used by rc script (pjd@126744). If there is no objections, I will commit this changeset on January 1, 2014. Index: libexec/save-entropy/save-entropy.sh

Re: [PATCH RFC] Disable save-entropy in jails

2013-12-24 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/24/13 14:36, Paul Hoffman wrote: On Dec 24, 2013, at 12:44 PM, Xin Li delp...@delphij.net wrote: I think we shouldn't save entropy inside jails, as the data is not going to be used by rc script (pjd@126744). If there is no objections,

Re: [PATCH RFC] Disable save-entropy in jails

2013-12-24 Thread Paul Hoffman
On Dec 24, 2013, at 12:44 PM, Xin Li delp...@delphij.net wrote: I think we shouldn't save entropy inside jails, as the data is not going to be used by rc script (pjd@126744). If there is no objections, I will commit this changeset on January 1, 2014. Even if it is not used by an rc script,

Re: [PATCH RFC] Disable save-entropy in jails

2013-12-24 Thread John-Mark Gurney
Paul Hoffman wrote this message on Tue, Dec 24, 2013 at 15:26 -0800: On Dec 24, 2013, at 2:53 PM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/24/13 14:36, Paul Hoffman wrote: On Dec 24, 2013, at 12:44 PM, Xin Li delp...@delphij.net wrote:

Re: [PATCH RFC] Disable save-entropy in jails

2013-12-24 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/24/13 15:26, Paul Hoffman wrote: On Dec 24, 2013, at 2:53 PM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/24/13 14:36, Paul Hoffman wrote: On Dec 24, 2013, at 12:44 PM, Xin Li

Re: new Xorg (KMS, etc.) for Radeon 9600

2013-12-24 Thread Adrian Chadd
On 24 December 2013 12:41, d...@gmx.com wrote: John Baldwin wrote, On 12/23/2013 17:50: It needs fixing, but the fix needs to be correct. Though a fix should not be delayed by decades... THe problem here is that a lot of people (and no offence to the patch author or other developers!) just