Jenkins build is back to normal : FreeBSD_HEAD #1865

2014-11-19 Thread jenkins-admin
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD/1865/changes ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

[RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Hans Petter Selasky
Hi, The M_FLOWID flag is marked as deprecated in the FreeBSD kernel code and the patch below completely removes it. I suggest we will now be using the m_pkthdr.rsstype also known as M_HASHTYPE to decide if the flowid value is valid or not. When the rsstype is set to M_HASHTYPE_NONE the

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Adrian Chadd
Hm, how are we going to have the RSS stuff work at the same time as the hardware flow steering stuff you're prototyping? -adrian On 19 November 2014 11:02, Hans Petter Selasky h...@selasky.org wrote: Hi, The M_FLOWID flag is marked as deprecated in the FreeBSD kernel code and the patch

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Hans Petter Selasky
On 11/19/14 20:23, Adrian Chadd wrote: Hm, how are we going to have the RSS stuff work at the same time as the hardware flow steering stuff you're prototyping? Hi Adrain, RSS is only the receive side and its functionality is not touched. I'm just re-using the RSS fields for the transmit

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Michael Tuexen
On 19 Nov 2014, at 20:02, Hans Petter Selasky h...@selasky.org wrote: Hi, The M_FLOWID flag is marked as deprecated in the FreeBSD kernel code and the patch below completely removes it. I suggest we will now be using the m_pkthdr.rsstype also known as M_HASHTYPE to decide if the flowid

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Adrian Chadd
The RSS hash is also used for: * TCP timers, * UDP transmit, and * the transmit path in RSS aware drivers (igb / ixgbe) -adrian On 19 November 2014 11:25, Hans Petter Selasky h...@selasky.org wrote: On 11/19/14 20:23, Adrian Chadd wrote: Hm, how are we going to have the RSS stuff work at

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Hans Petter Selasky
On 11/19/14 20:32, Adrian Chadd wrote: The RSS hash is also used for: * TCP timers, * UDP transmit, and * the transmit path in RSS aware drivers (igb / ixgbe) I know, and the RSS flowid values are still preserved as before in the receive path. It is just about how you tell the upper/lower

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread K. Macy
Hi Hans, It mostly looks fine, but it's a large change and there are some places in the patch where it isn't clear that the right thing is being done by looking at the patch alone. Please give us some time to review. Thanks. -K On Wed, Nov 19, 2014 at 11:02 AM, Hans Petter Selasky

Re: General Protection Fault in prelist_remove()

2014-11-19 Thread Ryan Stone
On Tue, Nov 18, 2014 at 2:21 AM, Mark Johnston ma...@freebsd.org wrote: https://people.freebsd.org/~markj/patches/nd6_dad_races.diff I haven't had the chance to study the patch in detail, but I can confirm that it at least fixes the crashes that I was seeing earlier.

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread Hans Petter Selasky
On 11/19/14 21:46, K. Macy wrote: Hi Hans, It mostly looks fine, but it's a large change and there are some places in the patch where it isn't clear that the right thing is being done by looking at the patch alone. Please give us some time to review. No problem. Do you think you need more

Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues]

2014-11-19 Thread K. Macy
On Wed, Nov 19, 2014 at 1:34 PM, Hans Petter Selasky h...@selasky.org wrote: On 11/19/14 21:46, K. Macy wrote: Hi Hans, It mostly looks fine, but it's a large change and there are some places in the patch where it isn't clear that the right thing is being done by looking at the patch alone.