Re: RFC: Should fspacectl() commit changes to stable storage?

2023-02-06 Thread Konstantin Belousov
On Mon, Feb 06, 2023 at 06:59:59PM -0700, Alan Somers wrote: > On Mon, Feb 6, 2023 at 6:23 PM Rick Macklem wrote: > > > > PR#269328 reports an issue related to fspacectl() being > > mixed with mmap'd I/O. > > > > When working on a fix for this for the NFS client, I realized that > > "man

Re: RFC: Should fspacectl() commit changes to stable storage?

2023-02-06 Thread Alan Somers
On Mon, Feb 6, 2023 at 6:23 PM Rick Macklem wrote: > > PR#269328 reports an issue related to fspacectl() being > mixed with mmap'd I/O. > > When working on a fix for this for the NFS client, I realized that > "man fspacectl" does not clarify if the deallocation should commit > changes to stable

RFC: Should fspacectl() commit changes to stable storage?

2023-02-06 Thread Rick Macklem
PR#269328 reports an issue related to fspacectl() being mixed with mmap'd I/O. When working on a fix for this for the NFS client, I realized that "man fspacectl" does not clarify if the deallocation should commit changes to stable storage before returning success. vop_stddeallocate() currently