Re: Queue drop not accounted ?

2011-09-16 Thread Arnaud Lacombe
Hi, On Fri, Sep 16, 2011 at 3:40 PM, YongHyeon PYUN wrote: > On Thu, Sep 15, 2011 at 09:25:19PM -0400, Arnaud Lacombe wrote: >> Hi, >> >> Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be >> accounted as dropped, cf attached patch ? >> > > Hmm, I think err would be set to ENOBU

Re: Queue drop not accounted ?

2011-09-16 Thread YongHyeon PYUN
On Thu, Sep 15, 2011 at 09:25:19PM -0400, Arnaud Lacombe wrote: > Hi, > > Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be > accounted as dropped, cf attached patch ? > Hmm, I think err would be set to ENOBUFS for queue full case and this err will crease ifq_drops. > Thanks,

Queue drop not accounted ?

2011-09-15 Thread Arnaud Lacombe
Hi, Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be accounted as dropped, cf attached patch ? Thanks, - Arnaud diff --git a/sys/net/if_var.h b/sys/net/if_var.h index 2dcb6f9..387f614 100644 --- a/sys/net/if_var.h +++ b/sys/net/if_var.h @@ -419,6 +419,7 @@ do { \ A