Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-27 Thread Luigi Rizzo
On Thu, Jul 26, 2012 at 10:52:08PM -0700, Adrian Chadd wrote: On 25 July 2012 08:14, Luigi Rizzo ri...@iet.unipi.it wrote: I suggest doing some digging to understand why. I bet we all know the answer, but it would be nice to have it documented and investigated. I bet em(4) isn't the only

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-27 Thread Adrian Chadd
Hm. Ok, I wonder whether it's a general case of touching the hardware too much versus a more specific case of all that taskqueue scheduling overhead is killing us in virtualised environments. Adrian ___ freebsd-current@freebsd.org mailing list

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-26 Thread Adrian Chadd
On 25 July 2012 08:14, Luigi Rizzo ri...@iet.unipi.it wrote: I suggest doing some digging to understand why. I bet we all know the answer, but it would be nice to have it documented and investigated. I bet em(4) isn't the only device that would benefit from this? I am not so sure i know the

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-25 Thread Andrew Boyer
lem is also used under VMware. Performance and stability should be tested there, too, before this change. -Andrew On Jul 24, 2012, at 4:20 PM, Luigi Rizzo wrote: if_lem.c (lem, one of the e1000 drivers) has 2 possible interrupt modes: EM_LEGACY_IRQ uses the standard dispatch mechanism,

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-25 Thread Luigi Rizzo
On Wed, Jul 25, 2012 at 09:08:42AM -0400, Andrew Boyer wrote: lem is also used under VMware. Performance and stability should be tested there, too, before this change. i do not have VMware so i cannot test it myself, but at the end of this email you can find a suitable image and instructions

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-25 Thread Adrian Chadd
On 24 July 2012 13:20, Luigi Rizzo ri...@iet.unipi.it wrote: if_lem.c (lem, one of the e1000 drivers) has 2 possible interrupt modes: EM_LEGACY_IRQ uses the standard dispatch mechanism, whereas FAST_INTR has a custom handler that signals a taskqueue to do the job. I have no idea which actual

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-25 Thread Luigi Rizzo
On Wed, Jul 25, 2012 at 07:48:57AM -0700, Adrian Chadd wrote: On 24 July 2012 13:20, Luigi Rizzo ri...@iet.unipi.it wrote: if_lem.c (lem, one of the e1000 drivers) has 2 possible interrupt modes: EM_LEGACY_IRQ uses the standard dispatch mechanism, whereas FAST_INTR has a custom handler that

RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-24 Thread Luigi Rizzo
if_lem.c (lem, one of the e1000 drivers) has 2 possible interrupt modes: EM_LEGACY_IRQ uses the standard dispatch mechanism, whereas FAST_INTR has a custom handler that signals a taskqueue to do the job. I have no idea which actual hardware uses it (all of my Intel 1G cards use either em or igb),

Re: RFC: use EM_LEGACY_IRQ in if_lem.c ?

2012-07-24 Thread Jack Vogel
Interesting, lem is all the non-pcie hardware, and if you see better performance out of the LEGACY path then I'm OK with changing the default. Jack On Tue, Jul 24, 2012 at 1:20 PM, Luigi Rizzo ri...@iet.unipi.it wrote: if_lem.c (lem, one of the e1000 drivers) has 2 possible interrupt modes: