Re: [PATCH] newvers.sh

2010-03-15 Thread David O'Brien
On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: In message: 20100312171206.ga31...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : * Simplify SRCDIR calculation by directly finding the kernel sources : based directly on one of them. : Reviewed by: dhw

Re: [PATCH] newvers.sh

2010-03-15 Thread M. Warner Losh
In message: 20100315142806.ga5...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: : In message: 20100312171206.ga31...@dragon.nuxi.org : David O'Brien obr...@freebsd.org writes: : : * Simplify

Re: [PATCH] newvers.sh

2010-03-15 Thread David O'Brien
On Mon, Mar 15, 2010 at 08:44:26AM -0600, M. Warner Losh wrote: In message: 20100315142806.ga5...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: : In message: 20100312171206.ga31...@dragon.nuxi.org :

Re: [PATCH] newvers.sh

2010-03-15 Thread David O'Brien
On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: The Makefile already knows where the kernel src is located. Let's use that knowledge to make things a little simpler. This also uses the Makefile variable SYSDIR. It should also work with non-standard sys directories. ..

Re: [PATCH] newvers.sh

2010-03-15 Thread M. Warner Losh
In message: 20100316002939.ga36...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : On Mon, Mar 15, 2010 at 08:44:26AM -0600, M. Warner Losh wrote: : In message: 20100315142806.ga5...@dragon.nuxi.org : David O'Brien obr...@freebsd.org writes: : : On Sat, Mar

Re: [PATCH] newvers.sh

2010-03-15 Thread Doug Barton
On 03/15/10 17:41, David O'Brien wrote: I'd rather not introduce yet more special things that have to be done before invoking newvers.sh. David, Trying to understand what you're getting at here. What's your use case for invoking newvers.sh from the command line? AFAIK it's only every used as

Re: [PATCH] newvers.sh

2010-03-15 Thread M. Warner Losh
David In message: 20100316004117.gb36...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: : The Makefile already knows where the kernel src is located. Let's use : that knowledge to make things a little

Re: [PATCH] newvers.sh

2010-03-15 Thread M. Warner Losh
In message: 4b9edb05.4020...@freebsd.org Doug Barton do...@freebsd.org writes: : On 03/15/10 17:41, David O'Brien wrote: : I'd rather not introduce yet more special things that have to be done : before invoking newvers.sh. : : David, : : Trying to understand what you're getting

Re: [PATCH] newvers.sh

2010-03-15 Thread Doug Barton
On 03/15/10 18:34, M. Warner Losh wrote: In message: 4b9edb05.4020...@freebsd.org Doug Barton do...@freebsd.org writes: : On 03/15/10 17:41, David O'Brien wrote: : I'd rather not introduce yet more special things that have to be done : before invoking newvers.sh. : : David,

Re: [PATCH] newvers.sh

2010-03-15 Thread M. Warner Losh
In message: 4b9ee1ad.9080...@freebsd.org Doug Barton do...@freebsd.org writes: : I believe the latter can be simplified to not require it. : : When I last looked at it I vaguely recall thinking that not needing : newvers.sh for that purpose was a good goal, but ENOTIME. Right now it

Re: [PATCH] newvers.sh

2010-03-13 Thread M. Warner Losh
In message: 20100312171206.ga31...@dragon.nuxi.org David O'Brien obr...@freebsd.org writes: : * Simplify SRCDIR calculation by directly finding the kernel sources : based directly on one of them. : : Reviewed by: dhw : : This change does not increase the kernel build time. It