Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-15 Thread Conrad J. Sabatier
On Sat, 14 Jan 2012 15:30:15 + Chris Rees cr...@freebsd.org wrote: On 14 January 2012 15:16, Rainer Hurling rhur...@gwdg.de wrote: On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: Howdy, Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr. The concept of

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-15 Thread Doug Barton
On 01/15/2012 00:11, Conrad J. Sabatier wrote: Chris, if you're working on fixing ports' rc files Thanks for taking a look at this. FYI, all of the rc.d scripts that are actually in the ports tree have already been fixed. The outliers at this point are scripts that are included in the

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-15 Thread Chris Rees
On 15 January 2012 08:11, Conrad J. Sabatier conr...@cox.net wrote: On Sat, 14 Jan 2012 15:30:15 + Chris Rees cr...@freebsd.org wrote: On 14 January 2012 15:16, Rainer Hurling rhur...@gwdg.de wrote: On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: Howdy, Per discussion in

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-15 Thread Conrad J. Sabatier
On Sun, 15 Jan 2012 00:40:36 -0800 Doug Barton do...@freebsd.org wrote: On 01/15/2012 00:11, Conrad J. Sabatier wrote: Chris, if you're working on fixing ports' rc files Thanks for taking a look at this. FYI, all of the rc.d scripts that are actually in the ports tree have already been

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-15 Thread Conrad J. Sabatier
On Sun, 15 Jan 2012 08:51:53 + Chris Rees cr...@freebsd.org wrote: [snip] Don't thank me! http://lists.freebsd.org/pipermail/cvs-ports/2012-January/233843.html Wow! Doug has been a busy boy recently! :-) The only ones that will cause trouble are the ones provided by upstream, but a

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Denny Lin
On Sat, Jan 14, 2012 at 01:05:59AM -0800, Doug Barton wrote: to make the change by hand, change this: name=foo rcvar=`set_rcvar` to: name=foo rcvar=foo_enable The scripts installed by net/avahi-app still use set_rcvar() because they are included in the source. -- Denny Lin

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Chris Rees
On 14 January 2012 11:11, Denny Lin dennyli...@hs.ntnu.edu.tw wrote: On Sat, Jan 14, 2012 at 01:05:59AM -0800, Doug Barton wrote: to make the change by hand, change this: name=foo rcvar=`set_rcvar` to: name=foo rcvar=foo_enable The scripts installed by net/avahi-app still use

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Jilles Tjoelker
On Sat, Jan 14, 2012 at 01:05:59AM -0800, Doug Barton wrote: Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr. The concept of set_rcvar() was nice in theory, but the forks it creates are a drag on the startup process, which is especially noticeable on slower systems, such

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Rainer Hurling
On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: Howdy, Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr. The concept of set_rcvar() was nice in theory, but the forks it creates are a drag on the startup process, which is especially noticeable on slower systems, such as

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Chris Rees
On 14 January 2012 15:16, Rainer Hurling rhur...@gwdg.de wrote: On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: Howdy, Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr. The concept of set_rcvar() was nice in theory, but the forks it creates are a drag on the startup

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Doug Barton
On 01/14/2012 06:44, Jilles Tjoelker wrote: Why must the 2-argument form of set_rcvar die at the same time? It is used very differently and does not cause unnecessary forks. Instead, it is called in the same shell environment to define additional rc.conf variables that have defaults and are

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Doug Barton
On 01/14/2012 07:16, Rainer Hurling wrote: BTW, is there any reason not to set 'rcvar=${name}_enable' in all that cases? http://lists.freebsd.org/pipermail/freebsd-rc/2012-January/002660.html Also, as I pointed out in my commit message, using the literal value is a tiny bit faster, and every

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Rainer Hurling
On 14.01.2012 22:29 (UTC+1), Doug Barton wrote: On 01/14/2012 07:16, Rainer Hurling wrote: BTW, is there any reason not to set 'rcvar=${name}_enable' in all that cases? http://lists.freebsd.org/pipermail/freebsd-rc/2012-January/002660.html Also, as I pointed out in my commit message, using