Re: Recent if_wg work: Should DIAGNOSTIC imply KASSERT is available?

2021-03-15 Thread David Wolfskill
On Mon, Mar 15, 2021 at 07:36:51AM -0500, Kyle Evans wrote: > On Mon, Mar 15, 2021 at 6:20 AM David Wolfskill wrote: > ... > > So: Is DIAGNOSTIC intended to necessarily imply that KASSERT is > > available for use? > > > > This is fixed in ff92a03616c5, thanks for the report! > > Kyle Evans > ...

Re: Recent if_wg work: Should DIAGNOSTIC imply KASSERT is available?

2021-03-15 Thread Kyle Evans
On Mon, Mar 15, 2021 at 6:20 AM David Wolfskill wrote: > > For my laptop, the kernel config includes GENERIC, does not have > > options INVARIANTS > > but does have > > options DIAGNOSTIC > > which has not been a problem until today. > > In src/sys/dev/if_wg/wg_noise.c, as of main-n2

Recent if_wg work: Should DIAGNOSTIC imply KASSERT is available?

2021-03-15 Thread David Wolfskill
For my laptop, the kernel config includes GENERIC, does not have options INVARIANTS but does have options DIAGNOSTIC which has not been a problem until today. In src/sys/dev/if_wg/wg_noise.c, as of main-n245465-16b2290447de, I see: ... 778 static void 779 noise_kdf(uint8