Re: SVN r351457 breaks drm-current

2019-08-27 Thread Michael Butler
On 2019-08-24 19:09, Michael Butler wrote: > On 2019-08-24 14:04, Konstantin Belousov wrote: >> On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote: >>> forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure >>> that's the right fix. >> More correct way to fix it is to

Re: SVN r351457 breaks drm-current

2019-08-24 Thread Michael Butler
On 2019-08-24 14:04, Konstantin Belousov wrote: > On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote: >> forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure >> that's the right fix. > More correct way to fix it is to include sys/pcpu.h before machine/md_var.h, > same

Re: SVN r351457 breaks drm-current

2019-08-24 Thread Konstantin Belousov
On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote: > forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure > that's the right fix. More correct way to fix it is to include sys/pcpu.h before machine/md_var.h, same as all in-tree consumers of the header do, apparently.

Re: SVN r351457 breaks drm-current

2019-08-24 Thread Warner Losh
forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure that's the right fix. Warner On Sat, Aug 24, 2019 at 10:35 AM Michael Butler wrote: > As follows .. > > Building > >

SVN r351457 breaks drm-current

2019-08-24 Thread Michael Butler
As follows .. Building /usr/obj/usr/src/amd64.amd64/sys/TOSHI/modules/usr/local/sys/modules/drm-current-kmod/linuxkpi/linux_compat.o --- linux_compat.o --- In file included from /usr/local/sys/modules/drm-current-kmod/linuxkpi/gplv2/src/linux_compat.c:5: ./machine/md_var.h:61:34: error: