XXX driver didn't initialize queue mtx

2001-01-27 Thread Blaz Zupan
# dmesg ... xl0 XXX: driver didn't initialize queue mtx lo0 XXX: driver didn't initialize queue mtx isp0 XXX: driver didn't initialize queue mtx isp1 XXX: driver didn't initialize queue mtx isp2 XXX: driver didn't initialize queue mtx isp3 XXX: driver didn't initialize queue mtx ... Anything

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Dag-Erling Smorgrav
Blaz Zupan [EMAIL PROTECTED] writes: xl0 XXX: driver didn't initialize queue mtx [...] Nothing to worry about, it's just a reminder for us kernel jocks. DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-cu

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Matthew Jacob
Oh, yeah- can someone say *which* queue mtx it's referring to? On 27 Jan 2001, Dag-Erling Smorgrav wrote: Blaz Zupan [EMAIL PROTECTED] writes: xl0 XXX: driver didn't initialize queue mtx [...] Nothing to worry about, it's just a reminder for us kernel jocks. DES -- Dag-Erling

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Dag-Erling Smorgrav
Matthew Jacob [EMAIL PROTECTED] writes: Oh, yeah- can someone say *which* queue mtx it's referring to? des@des ~% current "driver didn.t initialize" src/sys/net/if.c: printf("%s%d XXX: driver didn't initialize queue mtx\n", des@des ~% grep -C "

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Matthew Jacob
river didn.t initialize" src/sys/net/if.c: printf("%s%d XXX: driver didn't initialize queue mtx\n", des@des ~% grep -C "driver didn.t initialize" /sys/net/if.c /* XXX This is an access violation of the mutex internal

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Jason Evans
On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: Oh, I suppose, I did find that... well, mainly I wanted the person who made the change to actually broadcast to NIC maintainers what the expectations were... The code that prints these warnings out has existed for a while.

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Matthew Jacob
Shouldn't ether_ifattach initialize the mutex? Or do expect all drivers to initialize these prior to calling ether_ifattach? Look- I just want to know what the people who put the check in *want*. On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: Oh, I suppose, I did

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Jason Evans
On Sat, Jan 27, 2001 at 12:48:36PM -0800, Matthew Jacob wrote: Somewhere in between, Jason Evans wrote: On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: Oh, I suppose, I did find that... well, mainly I wanted the person who made the change to actually broadcast to NIC

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Matthew Jacob
cvs annotate is your friend. The code was added in revision 1.95 of src/sys/net/if.c by Jonathan Lemon. Please talk to him about what should be done to fix the drivers. Yes, and I shall... but this came up in a public forum. I'm making a point here (that apparently you and others don't

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Jonathan Lemon
In article local.mail.freebsd-current/[EMAIL PROTECTED] you write: On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: Oh, I suppose, I did find that... well, mainly I wanted the person who made the change to actually broadcast to NIC maintainers what the expectations were... The

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Jonathan Lemon
On Sat, Jan 27, 2001 at 01:05:58PM -0800, Jason Evans wrote: On Sat, Jan 27, 2001 at 12:48:36PM -0800, Matthew Jacob wrote: Somewhere in between, Jason Evans wrote: On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote: Oh, I suppose, I did find that... well, mainly I

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread John Baldwin
On 27-Jan-01 Matthew Jacob wrote: Oh, yeah- can someone say *which* queue mtx it's referring to? The if queues. Ones with the IFQ_ENQUEUE() etc. macros. On 27 Jan 2001, Dag-Erling Smorgrav wrote: Blaz Zupan [EMAIL PROTECTED] writes: xl0 XXX: driver didn't initialize queue mtx

Re: XXX driver didn't initialize queue mtx

2001-01-27 Thread Jason Evans
On Sat, Jan 27, 2001 at 03:19:04PM -0600, Jonathan Lemon wrote: Actually, the new check appears to be incorrect, as seen by the code fragments below: Whoops. I obviously looked at the wrong #define when making the change. Thanks for pointing out the mistake. Jason To Unsubscribe: send mail