Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-18 Thread Andrey A. Chernov
On Sun, Feb 16, 2003 at 22:08:10 -0800, Kris Kennaway wrote: > when they should not. I've given examples of two of them, and there > are probably lots of others I haven't noticed. For example, I just > checked, and libICE appears to use rand() for cookie generation. This > is completely bogus,

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-17 Thread David Schultz
Thus spake Jacques A. Vidrine <[EMAIL PROTECTED]>: > On Mon, Feb 17, 2003 at 04:40:48PM +1100, Tim Robbins wrote: > > I disagree. It's safe to use rand() in games and in certain kinds of > > simulations when you don't care that the distribution isn't quite > > uniform, > > Safe, maybe. But I thin

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-17 Thread Jacques A. Vidrine
On Mon, Feb 17, 2003 at 04:40:48PM +1100, Tim Robbins wrote: > I disagree. It's safe to use rand() in games and in certain kinds of > simulations when you don't care that the distribution isn't quite > uniform, Safe, maybe. But I think it still shouldn't be used. See my posting of two years ago:

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-17 Thread Andrey A. Chernov
On Mon, Feb 17, 2003 at 17:39:55 +1100, Tim Robbins wrote: > > variant (which generates bad quality ones), the only problem remains is > > first value monotonically increased with the seed. > > Here's an interesting picture of that: http://people.freebsd.org/~tjr/rand.gif > Nothing surprising h

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Kris Kennaway
On Sun, Feb 16, 2003 at 10:31:25PM -0800, David Schultz wrote: > > Note that I was only suggesting this patch be committed to -current > > for purposes of finding out what these applications are, and fixing > > them as appropriate. > > Then how about wrapping the warning in an #ifdef, so people w

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Tim Robbins
On Mon, Feb 17, 2003 at 08:53:09AM +0300, Andrey A. Chernov wrote: > On Mon, Feb 17, 2003 at 16:40:48 +1100, Tim Robbins wrote: > > > I don't think rand() > > needs a warning message like gets() &c. because it's not as dangerous. > > Wait, what kind of warning __warn_references() produce? I was

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread David Schultz
Thus spake Kris Kennaway <[EMAIL PROTECTED]>: > On Mon, Feb 17, 2003 at 04:40:48PM +1100, Tim Robbins wrote: > > > I disagree. It's safe to use rand() in games and in certain kinds of > > simulations when you don't care that the distribution isn't quite > > uniform, or when you prefer speed over q

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Kris Kennaway
On Mon, Feb 17, 2003 at 04:40:48PM +1100, Tim Robbins wrote: > I disagree. It's safe to use rand() in games and in certain kinds of > simulations when you don't care that the distribution isn't quite > uniform, or when you prefer speed over quality. I don't think rand() > needs a warning message l

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread David Schultz
Thus spake Kris Kennaway <[EMAIL PROTECTED]>: > I think we should commit this patch (to -current) and fix all the > problems that pop up. For example, it's used in awk (which started > this set of changes), and in some of the XFree86 libraries. ... > +__warn_references(rand_r, > + "warning: ra

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Juli Mallett
* De: "Andrey A. Chernov" <[EMAIL PROTECTED]> [ Data: 2003-02-16 ] [ Subjecte: Re: cvs commit: src/lib/libc/stdlib rand.c ] > On Mon, Feb 17, 2003 at 16:40:48 +1100, Tim Robbins wrote: > > > I don't think rand() > > needs a warning message like g

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Andrey A. Chernov
On Mon, Feb 17, 2003 at 16:40:48 +1100, Tim Robbins wrote: > I don't think rand() > needs a warning message like gets() &c. because it's not as dangerous. Wait, what kind of warning __warn_references() produce? I was under impression that it is compile-time only. > What I suggest instead is to

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Tim Robbins
On Sun, Feb 16, 2003 at 08:57:29PM -0800, Kris Kennaway wrote: > On Sun, Feb 16, 2003 at 07:52:35PM -0800, Andrey A. Chernov wrote: > > > So, monotonically increased seed->first value correlation problem remains... > > I think we should commit this patch (to -current) and fix all the > problem

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Andrey A. Chernov
On Sun, Feb 16, 2003 at 20:57:29 -0800, Kris Kennaway wrote: > On Sun, Feb 16, 2003 at 07:52:35PM -0800, Andrey A. Chernov wrote: > > > So, monotonically increased seed->first value correlation problem remains... > > I think we should commit this patch (to -current) and fix all the > problems t

Re: cvs commit: src/lib/libc/stdlib rand.c

2003-02-16 Thread Kris Kennaway
On Sun, Feb 16, 2003 at 07:52:35PM -0800, Andrey A. Chernov wrote: > So, monotonically increased seed->first value correlation problem remains... I think we should commit this patch (to -current) and fix all the problems that pop up. For example, it's used in awk (which started this set of cha