Re: newfs_msdos and DVD-RAM

2010-04-04 Thread Bruce Evans
On Sat, 3 Apr 2010, Tijl Coosemans wrote: Wikipedia's article on FAT has this to say about the maximum size of clusters: The limit on partition size was dictated by the 8-bit signed count of sectors per cluster, which had a maximum power-of-two value of 64. With That seems unlikely. The

Re: newfs_msdos and DVD-RAM

2010-04-03 Thread Paul B Mahol
On 4/2/10, Andriy Gapon a...@freebsd.org wrote: on 02/04/2010 22:26 Andriy Gapon said the following: OK, I did it again. I tested the below patch using the scenario described above. Could you please review and/or test this patch? If you like it and it works, I can commit it. Thanks! ---

Re: newfs_msdos and DVD-RAM

2010-04-03 Thread Tijl Coosemans
On Friday 02 April 2010 21:31:33 Andriy Gapon wrote: on 02/04/2010 22:26 Andriy Gapon said the following: OK, I did it again. I tested the below patch using the scenario described above. Could you please review and/or test this patch? If you like it and it works, I can commit it. Thanks!

Re: newfs_msdos and DVD-RAM

2010-04-03 Thread Andriy Gapon
on 03/04/2010 18:07 Tijl Coosemans said the following: I'm not sure the second paragraph is worth supporting, but the first seems to say that 32k limit you have in your patch only applies to disks with 512 byte sectors. For disks with larger sectors it would be proportionally larger. Last

Re: newfs_msdos and DVD-RAM

2010-04-03 Thread Andriy Gapon
on 03/04/2010 18:27 Andriy Gapon said the following: on 03/04/2010 18:07 Tijl Coosemans said the following: I'm not sure the second paragraph is worth supporting, but the first seems to say that 32k limit you have in your patch only applies to disks with 512 byte sectors. For disks with larger

Re: newfs_msdos and DVD-RAM

2010-04-02 Thread Fabian Keil
Andriy Gapon a...@freebsd.org wrote: on 30/03/2010 18:41 Andriy Gapon said the following: on 30/03/2010 18:36 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: on 29/03/2010 23:29 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Thus, clearly,

Re: newfs_msdos and DVD-RAM

2010-04-02 Thread Andriy Gapon
on 02/04/2010 13:57 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Anyways, here is a patch that I would use. Unfortunately, ENOTIME to understand newfs_msdos code and fix it too, --- a/sys/fs/msdosfs/msdosfs_vfsops.c +++ b/sys/fs/msdosfs/msdosfs_vfsops.c @@ -580,6

Re: newfs_msdos and DVD-RAM

2010-04-02 Thread Andriy Gapon
on 02/04/2010 14:09 Andriy Gapon said the following: on 02/04/2010 13:57 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Anyways, here is a patch that I would use. Unfortunately, ENOTIME to understand newfs_msdos code and fix it too, --- a/sys/fs/msdosfs/msdosfs_vfsops.c

Re: newfs_msdos and DVD-RAM

2010-04-02 Thread Andriy Gapon
on 02/04/2010 22:26 Andriy Gapon said the following: OK, I did it again. I tested the below patch using the scenario described above. Could you please review and/or test this patch? If you like it and it works, I can commit it. Thanks! --- a/sbin/newfs_msdos/newfs_msdos.c +++

Re: newfs_msdos and DVD-RAM

2010-03-31 Thread Andriy Gapon
on 30/03/2010 18:41 Andriy Gapon said the following: on 30/03/2010 18:36 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: on 29/03/2010 23:29 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Thus, clearly, it is a fault of a tool that formatted the

Re: newfs_msdos and DVD-RAM

2010-03-30 Thread Kostik Belousov
On Tue, Mar 30, 2010 at 10:40:07AM +1100, Bruce Evans wrote: On Mon, 29 Mar 2010, Andriy Gapon wrote: ... I am not a FAT expert and I know to take Wikipedia with a grain of salt. But please take a look at this: http://en.wikipedia.org/wiki/File_Allocation_Table#Boot_Sector In our

Re: newfs_msdos and DVD-RAM

2010-03-30 Thread Fabian Keil
Andriy Gapon a...@freebsd.org wrote: on 29/03/2010 23:29 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Thus, clearly, it is a fault of a tool that formatted the media for FAT. It should have picked correct values, or rejected incorrect values if those were provided

Re: newfs_msdos and DVD-RAM

2010-03-30 Thread Andriy Gapon
on 30/03/2010 18:36 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: on 29/03/2010 23:29 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Thus, clearly, it is a fault of a tool that formatted the media for FAT. It should have picked correct values, or

Re: newfs_msdos and DVD-RAM

2010-03-29 Thread Andriy Gapon
If you want to make sure that I see your reply please include me into recipient list. FreeBSD mailing lists sometimes have high volume and it's easy to miss a followup even if you are interested in reading it. on 28/03/2010 18:25 Fabian Keil said the following: Andriy Gapon a...@icyb.net.ua

Re: newfs_msdos and DVD-RAM

2010-03-29 Thread Fabian Keil
Andriy Gapon a...@freebsd.org wrote: on 28/03/2010 18:25 Fabian Keil said the following: Andriy Gapon a...@icyb.net.ua wrote: Looking at the code in mountmsdosfs(), it seems that SecPerClust can have zero value at the place of the crash only if pm_BlkPerSec is zero. See this line and the

Re: newfs_msdos and DVD-RAM

2010-03-29 Thread Andriy Gapon
on 29/03/2010 23:29 Fabian Keil said the following: Andriy Gapon a...@freebsd.org wrote: Thus, clearly, it is a fault of a tool that formatted the media for FAT. It should have picked correct values, or rejected incorrect values if those were provided as overrides via command line options.

Re: newfs_msdos and DVD-RAM

2010-03-29 Thread Bruce Evans
On Mon, 29 Mar 2010, Andriy Gapon wrote: ... I am not a FAT expert and I know to take Wikipedia with a grain of salt. But please take a look at this: http://en.wikipedia.org/wiki/File_Allocation_Table#Boot_Sector In our formula: SecPerClust *= pmp-pm_BlkPerSec; we have the following

Re: newfs_msdos and DVD-RAM

2010-03-29 Thread Ryan Stone
BTW, why can't gdb find any variables? They are just stack variables whose address is easy to find. ... #14 0x8042f24e in bread (vp=Variable vp is not available. ) at /usr/src/sys/kern/vfs_bio.c:748 ... and isn't vp a variable? Maybe the bad default -O2 is destroying

Re: newfs_msdos and DVD-RAM

2010-03-28 Thread Fabian Keil
on DVD-RAM disc. Something to do about divide by zero. I recently had a similar problem with a 16GB iPod. I still haven't managed to actually mount it, but the patch below at least works around the panic. Does it work for you, too? Obviously it will fix panic, but will not allow

Re: newfs_msdos and DVD-RAM

2010-03-24 Thread Andriy Gapon
on 19/03/2010 20:26 Paul B Mahol said the following: On Fri, Mar 19, 2010 at 7:11 PM, Fabian Keil freebsd-lis...@fabiankeil.de wrote: Paul B Mahol one...@gmail.com wrote: FreeBSD 9.0 CURRENT panics when mounting file system created via newfs_msdos on DVD-RAM disc. Something to do about

newfs_msdos and DVD-RAM

2010-03-19 Thread Paul B Mahol
Hi, FreeBSD 9.0 CURRENT panics when mounting file system created via newfs_msdos on DVD-RAM disc. Something to do about divide by zero. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe

Re: newfs_msdos and DVD-RAM

2010-03-19 Thread Fabian Keil
Paul B Mahol one...@gmail.com wrote: FreeBSD 9.0 CURRENT panics when mounting file system created via newfs_msdos on DVD-RAM disc. Something to do about divide by zero. I recently had a similar problem with a 16GB iPod. I still haven't managed to actually mount it, but the patch below

Re: newfs_msdos and DVD-RAM

2010-03-19 Thread Paul B Mahol
On Fri, Mar 19, 2010 at 7:11 PM, Fabian Keil freebsd-lis...@fabiankeil.de wrote: Paul B Mahol one...@gmail.com wrote: FreeBSD 9.0 CURRENT panics when mounting file system created via newfs_msdos on DVD-RAM disc. Something to do about divide by zero. I recently had a similar problem