Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Bruce Evans
On Sat, 28 Dec 2002, Matthew Dillon wrote: > The swapctl code has been comitted. Bruce, you never supplied feedback > in regards to your original nits, but feel free to clean the code up > now that it has been comitted. All other bullets have been taken care > of. I'm not sure i

Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Bruce Evans
[Reply to old mail] On Wed, 18 Dec 2002, Matthew Dillon wrote: > :Looks good to me, modulo a few nits. I try not to nitpick, but > :I've mentioned a few of them below. (BDE does a better job of it > :than I do anyway. :-) > : > :The patch puts identical functionality in two places, so maybe it

Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Matthew Dillon
The swapctl code has been comitted. Bruce, you never supplied feedback in regards to your original nits, but feel free to clean the code up now that it has been comitted. All other bullets have been taken care of. I'm still on the fence in regards to backporting it. I would

Re: patch #3 Re: swapoff code comitted.

2002-12-19 Thread David Schultz
Thus spake Matthew Dillon <[EMAIL PROTECTED]>: > :Looks good to me, modulo a few nits. I try not to nitpick, but > :I've mentioned a few of them below. (BDE does a better job of it > :than I do anyway. :-) > : > :The patch puts identical functionality in two places, so maybe it > :would make sen

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
: :On Wed, 18 Dec 2002, Matthew Dillon wrote: : :> Here's another update. I cleaned things up even more, add BLOCKSIZE :> support, and updated the manual page. It looks quite nice now. : :I still dislike it. It starts by adding style bugs to the Makefile :(changing "=" to "+=" for the i

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
:Looks good to me, modulo a few nits. I try not to nitpick, but :I've mentioned a few of them below. (BDE does a better job of it :than I do anyway. :-) : :The patch puts identical functionality in two places, so maybe it :would make sense to rip support for -s out of pstat/swapinfo (and :integ

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread David Schultz
Looks good to me, modulo a few nits. I try not to nitpick, but I've mentioned a few of them below. (BDE does a better job of it than I do anyway. :-) The patch puts identical functionality in two places, so maybe it would make sense to rip support for -s out of pstat/swapinfo (and integrate 'ps

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Bruce Evans
On Wed, 18 Dec 2002, Matthew Dillon wrote: > Here's another update. I cleaned things up even more, add BLOCKSIZE > support, and updated the manual page. It looks quite nice now. I still dislike it. It starts by adding style bugs to the Makefile (changing "=" to "+=" for the initial ass

patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
Here's another update. I cleaned things up even more, add BLOCKSIZE support, and updated the manual page. It looks quite nice now. -Matt Index: Makefile === RCS file: /home/nc