Re: ppp RADIUS accounting bug

2003-11-19 Thread Boris Kovalenko
Hello! Yes, unsigned, so we have 4G limit, which may simple be overflowed by (for example) PPPoE connection. Yes, RADIUS standard defines new attributes for big words, but current PPP does not supports it (it, so our knowledge about RFC is useless :) Again, rad_put_int defined u_int32_t

Re: ppp RADIUS accounting bug

2003-11-19 Thread Michael Bretterklieber
Hi, On Wed, 19 Nov 2003, Boris Kovalenko wrote: Hello! Yes, unsigned, so we have 4G limit, which may simple be overflowed by (for example) PPPoE connection. Yes, RADIUS standard defines new attributes for big words, but current PPP does not supports it (it, so our knowledge about RFC is

Re: ppp RADIUS accounting bug

2003-11-19 Thread Boris Kovalenko
Hello! Standard PPP does not support UPDATE packets, and of course (as my RADIUS knowledge) the counters should not be resetted, because RADIUS updates the same record. Regards, Boris Michael Bretterklieber wrote: Hi, On Wed, 19 Nov 2003, Boris Kovalenko wrote: Hello! Yes,

Re: ppp RADIUS accounting bug

2003-11-19 Thread Michael Bretterklieber
Hi Boris, On Wed, 19 Nov 2003, Boris Kovalenko wrote: Hello! Standard PPP does not support UPDATE packets, and of course (as my but a patch could be written :-) RADIUS knowledge) the counters should not be resetted, because RADIUS updates the same record. The RFC says: 5.4.

Re: ppp RADIUS accounting bug

2003-11-19 Thread Boris Kovalenko
The RFC says: 5.4. Acct-Output-Octets blabla can only be present in Accounting-Request records where the Acct-Status-Type is set to Stop. It looks like, that these counters must not present in accounting updates. You are right, but your words - but a patch could be written :-).

Re: ppp RADIUS accounting bug

2003-11-19 Thread Michael Bretterklieber
Hi, On Wed, 19 Nov 2003, Boris Kovalenko wrote: The RFC says: 5.4. Acct-Output-Octets blabla can only be present in Accounting-Request records where the Acct-Status-Type is set to Stop. It looks like, that these counters must not present in accounting updates. You

Re: ppp RADIUS accounting bug

2003-11-19 Thread Boris Kovalenko
Hello! So sending interim update packets won't help. Like I said :) looking for someone who supervises my patch and commit it if no problems will be founded. this can be a problem :-) This is the problem now :) I'm wondering if I only one useing ppp with RADIUS accounting with FreeBSD.

Re: ppp RADIUS accounting bug

2003-11-19 Thread Barney Wolff
On Wed, Nov 19, 2003 at 09:00:01AM +0500, Boris Kovalenko wrote: I found a serious bug in RADIUS accounting code. The problem is that OctetsIn and OctetsOut are defined as unsingned long long, but the RADIUS supports only INT32 values, so, when we're doing rad_put_int(r-cx.rad,

ppp RADIUS accounting bug

2003-11-18 Thread Boris Kovalenko
Hello! I found a serious bug in RADIUS accounting code. The problem is that OctetsIn and OctetsOut are defined as unsingned long long, but the RADIUS supports only INT32 values, so, when we're doing rad_put_int(r-cx.rad, RAD_ACCT_OUTPUT_OCTETS, stats-OctetsOut) in radius.c for OctetsOut (and