Re: r367672 broke the NFS server

2021-01-01 Thread Rick Macklem
; Alan Somers; Kirk McKusick; Mark Johnston Subject: Re: r367672 broke the NFS server Just fyi, I have put a patch up on phabricator as D27875 that seems to fix the problem for all NFS client mounts except NFSv4.0. NFSv4.0 will require an additional fix so that the "seqid" is properly

Re: r367672 broke the NFS server

2020-12-31 Thread Rick Macklem
on Subject: Re: r367672 broke the NFS server CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to ith...@uoguelph.ca On Thu, Dec 31,

Re: r367672 broke the NFS server

2020-12-31 Thread Konstantin Belousov
On Thu, Dec 31, 2020 at 05:16:27AM +, Rick Macklem wrote: > Rick Macklem wrote: > >Kostik wrote: > > > > > >Idea of the change is to restart the syscall at top level. So for NFS > > >server the right approach is to not send a response and also to not > > >free the request mbuf chain, but to

Re: r367672 broke the NFS server

2020-12-30 Thread Rick Macklem
Rick Macklem wrote: >Kostik wrote: > > > >Idea of the change is to restart the syscall at top level. So for NFS > >server the right approach is to not send a response and also to not > >free the request mbuf chain, but to restart processing. > Yes. I took a look and I think restarting the

Re: r367672 broke the NFS server

2020-12-30 Thread Peter Holm
On Wed, Dec 30, 2020 at 07:27:08PM +0200, Konstantin Belousov wrote: > On Wed, Dec 30, 2020 at 04:48:27PM +, Rick Macklem wrote: > > Kostik wrote: > > >On Wed, Dec 30, 2020 at 02:02:48AM +, Rick Macklem wrote: > > >> Hi, > > >> > > >> Post r367671... > > >> When multiple files are being

Re: r367672 broke the NFS server

2020-12-30 Thread Konstantin Belousov
On Wed, Dec 30, 2020 at 04:48:27PM +, Rick Macklem wrote: > Kostik wrote: > >On Wed, Dec 30, 2020 at 02:02:48AM +, Rick Macklem wrote: > >> Hi, > >> > >> Post r367671... > >> When multiple files are being created by an NFS client in the same > >> directory, the VOP_CREATE()/ufs_create()

Re: r367672 broke the NFS server

2020-12-30 Thread Rick Macklem
Kostik wrote: >On Wed, Dec 30, 2020 at 02:02:48AM +, Rick Macklem wrote: >> Hi, >> >> Post r367671... >> When multiple files are being created by an NFS client in the same >> directory, the VOP_CREATE()/ufs_create() can fail with ERELOOKUP. >> This results in a EIO return to the NFS client. >>

Re: r367672 broke the NFS server

2020-12-30 Thread Konstantin Belousov
On Wed, Dec 30, 2020 at 02:02:48AM +, Rick Macklem wrote: > Hi, > > Post r367671... > When multiple files are being created by an NFS client in the same > directory, the VOP_CREATE()/ufs_create() can fail with ERELOOKUP. > This results in a EIO return to the NFS client. > --> This causes

r367672 broke the NFS server

2020-12-29 Thread Rick Macklem
Hi, Post r367671... When multiple files are being created by an NFS client in the same directory, the VOP_CREATE()/ufs_create() can fail with ERELOOKUP. This results in a EIO return to the NFS client. --> This causes "nfsv4 client/server protocol prob err=10026" on the client for NFSv4.0