Re: specfs lock plumbing broken

2003-01-06 Thread Bruce Evans
On Sun, 5 Jan 2003, Nate Lawson wrote: > On Mon, 6 Jan 2003, Bruce Evans wrote: > > - spec_print() is of low quality: it doesn't print the device name or number. > > - devfs_print() would be reachable but doesn't exist, so vprint() prints > > even lower quality output for devfs since there nothi

Re: specfs lock plumbing broken

2003-01-05 Thread phk
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >No. Also no INVARIANTS and the like. A profiling kernel (with profiling >not running) seemed to panic faster. Ok, in this case listening to KASSERTS would probably have helped you. Please try 1.351 of vfs_bio.c -- Poul-Henning Kamp |

Re: specfs lock plumbing broken

2003-01-05 Thread Nate Lawson
On Mon, 6 Jan 2003, Bruce Evans wrote: > - spec_print() is of low quality: it doesn't print the device name or number. > - devfs_print() would be reachable but doesn't exist, so vprint() prints > even lower quality output for devfs since there nothing prints an inode > number either. I was the

Re: specfs lock plumbing broken

2003-01-05 Thread Bruce Evans
On Sun, 5 Jan 2003 [EMAIL PROTECTED] wrote: > In message <[EMAIL PROTECTED]>, Bruce Evans writes: > >On Sun, 5 Jan 2003 [EMAIL PROTECTED] wrote: > >> This is not tested with DEVFS I take it ? > > > >It doesn't affect devfs because devfs doesn't go through ufs. It goes > >straight to the default v

Re: specfs lock plumbing broken

2003-01-05 Thread phk
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >On Sun, 5 Jan 2003 [EMAIL PROTECTED] wrote: > >> I always wondered why specfs would insist on no locking, but I never >> had much ambition for finding out. > >Me too. It seems to be mostly a mistake. > >> >Fixing specfs is simple: >> >> This is

Re: specfs lock plumbing broken

2003-01-05 Thread Bruce Evans
On Sun, 5 Jan 2003 [EMAIL PROTECTED] wrote: > In message <[EMAIL PROTECTED]>, Bruce Evans writes: > > >The following change uncovers bugs in specfs locking and other places: > > Wow, that was fun! :-/ It took a while, yes %-). > I always wondered why specfs would insist on no locking, but I nev

Re: specfs lock plumbing broken

2003-01-05 Thread phk
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >The following change uncovers bugs in specfs locking and other places: Wow, that was fun! :-/ I always wondered why specfs would insist on no locking, but I never had much ambition for finding out. >Fixing specfs is simple: This is not test

specfs lock plumbing broken

2003-01-05 Thread Bruce Evans
The following change uncovers bugs in specfs locking and other places: % RCS file: /home/ncvs/src/sys/ufs/ufs/ufs_vnops.c,v % Working file: ufs_vnops.c % head: 1.222 % ... % % revision 1.221 % date: 2003/01/04 08:47:19; author: phk; state: Exp; lines: +0 -9 % Since