Patch review [was: Re: viapropm doesnt like sys/dev/pci.c rev 1.214]

2003-06-15 Thread Nicolas Souchu
On Thu, Jun 05, 2003 at 04:17:38AM -0700, Terry Lambert wrote: > How about RF_DONTCHECK or RF_ALWAYSWORKS? It better implies > what's happening here, since you're going to assume success in > the face of diagnostics to the contrary. > > So instead of: > > if (flag) > return (

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-05 Thread Terry Lambert
"David P. Reese Jr." wrote: > > > A snip of code from sys/dev/pci/pci.c:pci_enable_io_method(): > > > > > > pci_set_command_bit(dev, child, bit); > > > command = PCI_READ_CONFIG(dev, child, PCIR_COMMAND, 2); > > > if (command & bit) > > > return (0); > > >

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-04 Thread David P. Reese Jr.
On Wed, Jun 04, 2003 at 07:29:31AM +, Nicolas Souchu wrote: > On Tue, Jun 03, 2003 at 10:54:30AM -0700, David P. Reese Jr. wrote: > > [...] > > : The datasheet states that the command bits are RW but "fixed at 0". > > > > A snip of code from sys/dev/pci/pci.c:pci_enable_io_method(): > > > >

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-04 Thread Nicolas Souchu
On Tue, Jun 03, 2003 at 10:54:30AM -0700, David P. Reese Jr. wrote: [...] > : The datasheet states that the command bits are RW but "fixed at 0". > > A snip of code from sys/dev/pci/pci.c:pci_enable_io_method(): > > pci_set_command_bit(dev, child, bit); > command = PCI_READ_CONFI

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-04 Thread David P. Reese Jr.
On Tue, Jun 03, 2003 at 01:54:36AM -0500, Conrad Sabatier wrote: > > On 02-Jun-2003 Nicolas Souchu wrote: > > On Sun, Jun 01, 2003 at 01:52:57AM +0200, Dag-Erling Smorgrav wrote: > >> > >> viapropm is seriously broken for other reasons and needs professional > >> help. > > > > What kind of break

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-03 Thread Conrad Sabatier
On 02-Jun-2003 Nicolas Souchu wrote: > On Sun, Jun 01, 2003 at 01:52:57AM +0200, Dag-Erling Smorgrav wrote: >> >> viapropm is seriously broken for other reasons and needs professional >> help. > > What kind of breakage? Setting resources in probe? Right. Anybody having > the viapm driver loaded

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-03 Thread Nicolas Souchu
On Sun, Jun 01, 2003 at 01:52:57AM +0200, Dag-Erling Smorgrav wrote: > "David P. Reese Jr." <[EMAIL PROTECTED]> writes: > > In rev 1.214 of sys/dev/pci/pci.c, we have started checking if a > > pci_set_command_bit() was successful with a subsequent PCI_READ_CONFIG > > and comparing the results. For

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-01 Thread David P. Reese Jr.
On Sun, Jun 01, 2003 at 01:52:57AM +0200, Dag-Erling Smorgrav wrote: > "David P. Reese Jr." <[EMAIL PROTECTED]> writes: > > In rev 1.214 of sys/dev/pci/pci.c, we have started checking if a > > pci_set_command_bit() was successful with a subsequent PCI_READ_CONFIG > > and comparing the results. For

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-01 Thread Dag-Erling Smorgrav
"David P. Reese Jr." <[EMAIL PROTECTED]> writes: > In rev 1.214 of sys/dev/pci/pci.c, we have started checking if a > pci_set_command_bit() was successful with a subsequent PCI_READ_CONFIG > and comparing the results. For some odd reason, this doesnt work when > my viapropm tries to attach. viapr

Re: viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-01 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> "David P. Reese Jr." <[EMAIL PROTECTED]> writes: : Is it my chipset's fault for not reading back the correct register value? : The board is a SOYO K7VTAPRO-2AA6. What other info would be helpful in : this situation? It appears that there's some non-zero

viapropm doesnt like sys/dev/pci.c rev 1.214

2003-06-01 Thread David P. Reese Jr.
In rev 1.214 of sys/dev/pci/pci.c, we have started checking if a pci_set_command_bit() was successful with a subsequent PCI_READ_CONFIG and comparing the results. For some odd reason, this doesnt work when my viapropm tries to attach. Allocating its port resources fails in pci_enable_io_method().