Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Baptiste Daroussin 
On Wed, Nov 25, 2015 at 06:31:16PM +0300, Andrey Chernov wrote:
> On 25.11.2015 18:12, Andrey Chernov wrote:
> > On 25.11.2015 17:35, Baptiste Daroussin wrote:
> >>> BTW, array size looks suspicious:
> >>> static wchar_t wab_months[12][MAX_ABMON_WIDTH * 2 * MB_LEN_MAX];
> >>> what MB_LEN_MAX doing here? This constant is for multiple-bytes encoded,
> >>> not for wide chars.
> >> Bad copy/paste sorry it should be "MAX_ABMON_WIDTH * 2"
> > 
> > I don't check deep enough, it seems first array
> > MAX_ABMON_WIDTH * MB_LEN_MAX + 1
> > and second one
> > MAX_ABMON_WIDTH * 2 + 1
> > 
> 
> No. We can't assume anything here and should integrate limits from the
> locale for months fields instead. F.e. in abstract general case in wide
> array can be 100 zero-width characters + 5 of normal characters, so
> width-oriented sizes not prevents overflowing.
> 
> First array size should be from locale internals,

There is no max size for an abbreviated month in the locale internals
So maybe the best here is to consider your first proposal:
MAX_ABMON_WIDTH * MB_LEN_MAX + 1 and MAX_ABMON_WIDTH * 2 + 1
Check that it does not overflow and fallack if it overflows.

Having 100 zero-width characters in a locale have very little probability to
happen and if it does one day, it problably means something went wrong in the
code generation

Bapt


signature.asc
Description: PGP signature

Re: Panic while waiting on wlan0

2015-11-25 Thread Adrian Chadd 
ok, so I think you're hitting the iwn bug with scanning hanging.
net80211 does scan-channel-at-a-time and instead we should be issuing
a scan command once and then waiting for the results.

There's not much we can do about it without finishing redoing how the
scan stuff works completely in iwn.



-adrian
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Bryan Drewery 
On 11/24/2015 1:31 AM, M - Krasznai András wrote:
> What can I do to eliminate the ccache error during installworld apart from 
> not using ccache?

I would recommend not setting CC or CCACHE_PATH in make.conf and using
the new WITH_CCACHE_BUILD=yes option instead.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

r291302: f_enc.c:104:43: error: use of undeclared identifier 'IPSEC_ENC_BEFORE' static

2015-11-25 Thread O. Hartmann 
The recent CURRENT (r291302) sources won't build anymore due to the error shown 
below:

[...]
--- if_enc.o ---
cc  -c -O3 -pipe -fno-strict-aliasing -march=native  -nostdinc  -I. 
-I/usr/src/sys
-I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include
opt_global.h  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer 
-mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables
-ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls 
-Wnested-externs
-Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  
-Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__  -Wmissing-include-dirs
-fdiagnostics-show-option  -Wno-unknown-pragmas  -Wno-error-tautological-compare
-Wno-error-empty-body  -Wno-error-parentheses-equality 
-Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx
-std=iso9899:1999 -Werror  /usr/src/sys/net/if_enc.c --- if_mib.o --- 
ctfconvert -L
VERSION if_mib.o ERROR: ctfconvert: if_mib.o doesn't have type data to convert 
---
if_vlan.o --- cc  -c -O3 -pipe -fno-strict-aliasing -march=native  -nostdinc  
-I.
-I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL 
-DHAVE_KERNEL_OPTION_HEADERS
-include opt_global.h  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
-D__printf__=__freebsd_kprintf__  -Wmissing-include-dirs 
-fdiagnostics-show-option
-Wno-unknown-pragmas  -Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality -Wno-error-unused-function  
-Wno-error-pointer-sign
-Wno-error-shift-negative-value  -mno-aes -mno-avx  -std=iso9899:1999
-Werror  /usr/src/sys/net/if_vlan.c --- modules-all --- --- all_subdir_aac --- 
===> aac
(all) --- if_enc.o --- /usr/src/sys/net/if_enc.c:104:43: error: use of 
undeclared
identifier 'IPSEC_ENC_BEFORE' static VNET_DEFINE(int, filter_mask_in) = 
IPSEC_ENC_BEFORE;
^ /usr/src/sys/net/if_enc.c:105:40: error: use of undeclared identifier
'IPSEC_ENC_BEFORE' static VNET_DEFINE(int, bpf_mask_in) = IPSEC_ENC_BEFORE;
^ /usr/src/sys/net/if_enc.c:106:44: error: use of undeclared identifier
'IPSEC_ENC_BEFORE' static VNET_DEFINE(int, filter_mask_out) = IPSEC_ENC_BEFORE;
^ /usr/src/sys/net/if_enc.c:107:41: error: use of undeclared identifier
'IPSEC_ENC_BEFORE' static VNET_DEFINE(int, bpf_mask_out) = IPSEC_ENC_BEFORE |
IPSEC_ENC_AFTER; ^ /usr/src/sys/net/if_enc.c:107:60: error: use of undeclared 
identifier
'IPSEC_ENC_AFTER' static VNET_DEFINE(int, bpf_mask_out) = IPSEC_ENC_BEFORE |
IPSEC_ENC_AFTER; ^ /usr/src/sys/net/if_enc.c:226:9: error: incomplete 
definition of type
'struct ipsec_ctx_data' if (ctx->af != hhook_id)
~~~^ /usr/src/sys/netipsec/ipsec.h:261:8: note: forward declaration of 'struct
ipsec_ctx_data' struct ipsec_ctx_data; ^ --- modules-all --- --- 
all_subdir_aacraid ---


pgpblRX7klWc2.pgp
Description: OpenPGP digital signature

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Andrey Chernov 
On 25.11.2015 18:12, Andrey Chernov wrote:
> On 25.11.2015 17:35, Baptiste Daroussin wrote:
>>> BTW, array size looks suspicious:
>>> static wchar_t wab_months[12][MAX_ABMON_WIDTH * 2 * MB_LEN_MAX];
>>> what MB_LEN_MAX doing here? This constant is for multiple-bytes encoded,
>>> not for wide chars.
>> Bad copy/paste sorry it should be "MAX_ABMON_WIDTH * 2"
> 
> I don't check deep enough, it seems first array
> MAX_ABMON_WIDTH * MB_LEN_MAX + 1
> and second one
> MAX_ABMON_WIDTH * 2 + 1
> 

No. We can't assume anything here and should integrate limits from the
locale for months fields instead. F.e. in abstract general case in wide
array can be 100 zero-width characters + 5 of normal characters, so
width-oriented sizes not prevents overflowing.

First array size should be from locale internals,
second one == first * sizeof(wchar_t)
it will be safe for not overflowing.

-- 
http://ache.vniz.net/



signature.asc
Description: OpenPGP digital signature

FreeBSD_HEAD_i386 - Build #1762 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1762 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1762/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1762/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1762/console

Change summaries:

291302 by hselasky:
Update usage:
- Add missing description of "-c" option.
- Add one more usage example.

291301 by fabient:
The r241129 description was wrong that the scenario is possible
only for read locks on pcbs. The same race can happen with write
lock semantics as well.

The race scenario:

- Two threads (1 and 2) locate pcb with writer semantics (INPLOOKUP_WLOCKPCB)
 and do in_pcbref() on it.
- 1 and 2 both drop the inp hash lock.
- Another thread (3) grabs the inp hash lock. Then it runs in_pcbfree(),
 which wlocks the pcb. They must happen faster than 1 or 2 come INP_WLOCK()!
- 1 and 2 congest in INP_WLOCK().
- 3 does in_pcbremlists(), drops hash lock, and runs in_pcbrele_wlocked(),
 which doesn't free the pcb due to two references on it.
 Then it unlocks the pcb.
- 1 (or 2) gets wlock on the pcb, runs in_pcbrele_wlocked(), which doesn't
 report inp as freed, due to 2 (or 1) still helding extra reference on it.
 The thread tries to do smth with a disconnected pcb and crashes.

Submitted by:   emeric.pou...@stormshield.eu
Reviewed by:gleb@
MFC after:  1 week
Sponsored by: Stormshield
Tested by: Cassiano Peixoto, Stormshield

291300 by hselasky:
Add simple indent wrapper tool for style(9) checking GIT/SVN patches.
The indent_wrapper tool only accepts full context diffs and works by
identifying the surrounding C-block touched by a diff and passing only
that to indent for styling. In the end a diff is produced or an
external tool like meld can be invoked, to show the styling
differences.



The end of the build log:

[...truncated 181356 lines...]
--- if_disc.ko.debug ---
objcopy --only-keep-debug if_disc.ko.full if_disc.ko.debug
--- if_disc.ko ---
objcopy --strip-debug --add-gnu-debuglink=if_disc.ko.debug  if_disc.ko.full 
if_disc.ko
--- all_subdir_if_edsc ---
--- if_edsc.kld ---
ld -d -warn-common -r -d -o if_edsc.kld if_edsc.o
--- all_subdir_ibcs2 ---
--- ibcs2.kld ---
--- all_subdir_if_enc ---
--- all_subdir_ibcs2 ---
ld -d -warn-common -r -d -o ibcs2.kld ibcs2_errno.o ibcs2_ipc.o ibcs2_stat.o 
ibcs2_misc.o ibcs2_fcntl.o ibcs2_signal.o ibcs2_sysent.o ibcs2_ioctl.o 
ibcs2_socksys.o ibcs2_util.o ibcs2_xenix.o ibcs2_xenix_sysent.o ibcs2_isc.o 
ibcs2_isc_sysent.o ibcs2_msg.o ibcs2_other.o ibcs2_sysi86.o ibcs2_sysvec.o
--- all_subdir_if_edsc ---
ctfmerge -L VERSION -g -o if_edsc.kld if_edsc.o
--- all_subdir_if_enc ---
===> if_enc (all)
--- all_subdir_if_edsc ---
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk if_edsc.kld  export_syms | xargs -J% 
objcopy % if_edsc.kld
--- if_edsc.ko.full ---
ld -Bshareable -d -warn-common -o if_edsc.ko.full if_edsc.kld
--- all_subdir_ibcs2 ---
ctfmerge -L VERSION -g -o ibcs2.kld ibcs2_errno.o ibcs2_ipc.o ibcs2_stat.o 
ibcs2_misc.o ibcs2_fcntl.o ibcs2_signal.o ibcs2_sysent.o ibcs2_ioctl.o 
ibcs2_socksys.o ibcs2_util.o ibcs2_xenix.o ibcs2_xenix_sysent.o ibcs2_isc.o 
ibcs2_isc_sysent.o ibcs2_msg.o ibcs2_other.o ibcs2_sysi86.o ibcs2_sysvec.o
--- all_subdir_if_edsc ---
--- if_edsc.ko.debug ---
objcopy --only-keep-debug if_edsc.ko.full if_edsc.ko.debug
--- if_edsc.ko ---
objcopy --strip-debug --add-gnu-debuglink=if_edsc.ko.debug  if_edsc.ko.full 
if_edsc.ko
--- tbfadt.o ---
cc  -c -O -pipe  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt 
-D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h  -mno-mmx -mno-sse 
-msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall 
-Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes 
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign 
-D__printf__=__freebsd_kprintf__  -Wmissing-include-dirs 
-fdiagnostics-show-option  -Wno-unknown-pragmas  
-Wno-error-tautological-compare -Wno-error-empty-body  
-Wno-error-parentheses-equality -Wno-error-unused-function  
-Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx  
-std=iso9899:1999 -Werror  
/usr/src/sys/contrib/dev/acpica/components/tables/tbfadt.c
--- modules-all ---
--- all_subdir_if_enc ---
--- if_enc.o ---
cc  -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   
-DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/GENERIC/opt_global.h 
-I. -I/usr/src/sys -fno-common -g -I/usr/obj/usr/src/sys/GENERIC  -mno-mmx 
-mno-sse -msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall 
-Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes 
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign 
-D__printf__=__freebsd_kprintf__  -Wmissing-include-dirs 
-fdiagnostics-show-option  -Wno-unknown-pragmas  
-Wno-error-tautological-compare -Wno-error-empty-body  
-Wno-error-parentheses-equality -Wno-error-unused-function

FreeBSD_HEAD_i386 - Build #1765 - Fixed

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1765 - Fixed:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1765/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1765/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1765/console

Change summaries:

291341 by gnn:
Summary: A simple script to print the return value of any function,
with or without wild cards.

291340 by bdrewery:
Follow-up r291338 to handle .d, .y and .l files better as well.

X-MFC-With: r291338
MFC after:  2 weeks
Sponsored by:   EMC / Isilon Storage Division

291339 by bdrewery:
Follow-up r291330: h_testbits.h is only needed by xdr_test.

X-MFC-With: r291330
MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291338 by bdrewery:
Fix the "common object" handling to not depend on ".o" if SRCS only contains
headers.

This resulted in 'don't know how to make .o.' errors after the changes in
r289286.

MFC after:  2 weeks
Sponsored by:   EMC / Isilon Storage Division

291337 by ngie:
Link fclose(3) to fdclose(3)

X-MFC with: r285140
MFC after: 3 weeks (need to evaluate whether or not r285140 can be MFCed)
Sponsored by: EMC / Isilon Storage Division

291335 by ngie:
Fix building sys/modules/if_enc by adding missing headers

X-MFC with: r291292, r291299 (if that ever happens)
Pointyhat to: ae

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: FreeBSD_HEAD_i386 - Build #1764 - Still Failing

2015-11-25 Thread Bryan Drewery 
On 11/25/2015 2:16 PM, jenkins-ad...@freebsd.org wrote:
> make[7]: make[7]: don't know how to make .o. Stop

My bad. Fixed.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

FreeBSD_HEAD - Build #3566 - Fixed

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD - Build #3566 - Fixed:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3566/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3566/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3566/console

Change summaries:

291342 by sjg:
ParseTrackInput: do not access beyond end of buffer.

Reviewed by:dim

291341 by gnn:
Summary: A simple script to print the return value of any function,
with or without wild cards.

291340 by bdrewery:
Follow-up r291338 to handle .d, .y and .l files better as well.

X-MFC-With: r291338
MFC after:  2 weeks
Sponsored by:   EMC / Isilon Storage Division

291339 by bdrewery:
Follow-up r291330: h_testbits.h is only needed by xdr_test.

X-MFC-With: r291330
MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291338 by bdrewery:
Fix the "common object" handling to not depend on ".o" if SRCS only contains
headers.

This resulted in 'don't know how to make .o.' errors after the changes in
r289286.

MFC after:  2 weeks
Sponsored by:   EMC / Isilon Storage Division

291337 by ngie:
Link fclose(3) to fdclose(3)

X-MFC with: r285140
MFC after: 3 weeks (need to evaluate whether or not r285140 can be MFCed)
Sponsored by: EMC / Isilon Storage Division

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Rainer Hurling 
Am 25.11.15 um 20:37 schrieb Bryan Drewery:
> On 11/25/2015 11:34 AM, Rainer Hurling wrote:
>> Am 25.11.15 um 19:50 schrieb Bryan Drewery:
>>> On 11/25/2015 10:09 AM, Juan Molina wrote:
> On 11/24/2015 1:31 AM, M - Krasznai András wrote:
>> /What can I do to eliminate the ccache error during installworld
> apart from not using ccache? /
> I would recommend not setting CC or CCACHE_PATH in make.conf and using
> the new WITH_CCACHE_BUILD=yes option instead.
>
> -- 
> Regards,
> Bryan Drewery

 Hi.

 I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
 defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.

>>>
>>> WITH_FAST_DEPEND is not related.
>>>
>>> Are you building and installing as a different user? Using a different
>>> MAKEOBJDIRPREFIX in build and install?
>>>
>>> Do you have CCACHE_PATH in your environment?
>>>
>>> Run 'make ccache-print-options|grep path'. It should have no value.
>>>
>>
>> Is there any possibility to redirect the .ccache directory, something
>> like CCACHE_PATH for userland?
>>
>> I am asking, because in my attempts to build base with WITH_CCACHE_BUILD
>> and WITH_FAST_DEPEND enabled, it breaks with error message 'file system
>> full'. My root partition has only 1GB and ccache itself seems to need
>> more than 800MB in /root/.ccache.
>>
> 
> You want to modify CCACHE_DIR. You can do this in make.conf or the
> environment.
> 
> I tend to just symlink /root/.ccache to somewhere else though and let
> the default work via the symlink.
> 
> Also see 'man src.conf' (WITH_CCACHE_BUILD section) and 'man ccache'.
> 

Oops, I should have looked into man src.conf before asking here, sorry.

And many thanks for the quick and helpful answer.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

freebsd-current compile with clang & ccache

2015-11-25 Thread Juan Molina 

On 11/24/2015 1:31 AM, M - Krasznai András wrote:
>/What can I do to eliminate the ccache error during installworld apart 
from not using ccache? /

I would recommend not setting CC or CCACHE_PATH in make.conf and using
the new WITH_CCACHE_BUILD=yes option instead.

--
Regards,
Bryan Drewery


Hi.

I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH 
defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.


Best regards,
Juan
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Bryan Drewery 
On 11/25/2015 11:34 AM, Rainer Hurling wrote:
> Am 25.11.15 um 19:50 schrieb Bryan Drewery:
>> On 11/25/2015 10:09 AM, Juan Molina wrote:
 On 11/24/2015 1:31 AM, M - Krasznai András wrote:
> /What can I do to eliminate the ccache error during installworld
 apart from not using ccache? /
 I would recommend not setting CC or CCACHE_PATH in make.conf and using
 the new WITH_CCACHE_BUILD=yes option instead.

 -- 
 Regards,
 Bryan Drewery
>>>
>>> Hi.
>>>
>>> I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
>>> defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.
>>>
>>
>> WITH_FAST_DEPEND is not related.
>>
>> Are you building and installing as a different user? Using a different
>> MAKEOBJDIRPREFIX in build and install?
>>
>> Do you have CCACHE_PATH in your environment?
>>
>> Run 'make ccache-print-options|grep path'. It should have no value.
>>
> 
> Is there any possibility to redirect the .ccache directory, something
> like CCACHE_PATH for userland?
> 
> I am asking, because in my attempts to build base with WITH_CCACHE_BUILD
> and WITH_FAST_DEPEND enabled, it breaks with error message 'file system
> full'. My root partition has only 1GB and ccache itself seems to need
> more than 800MB in /root/.ccache.
> 

You want to modify CCACHE_DIR. You can do this in make.conf or the
environment.

I tend to just symlink /root/.ccache to somewhere else though and let
the default work via the symlink.

Also see 'man src.conf' (WITH_CCACHE_BUILD section) and 'man ccache'.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Bryan Drewery 
On 11/25/2015 10:09 AM, Juan Molina wrote:
>> On 11/24/2015 1:31 AM, M - Krasznai András wrote:
>> >/What can I do to eliminate the ccache error during installworld
>> apart from not using ccache? /
>> I would recommend not setting CC or CCACHE_PATH in make.conf and using
>> the new WITH_CCACHE_BUILD=yes option instead.
>>
>> -- 
>> Regards,
>> Bryan Drewery
> 
> Hi.
> 
> I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
> defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.
> 

WITH_FAST_DEPEND is not related.

Are you building and installing as a different user? Using a different
MAKEOBJDIRPREFIX in build and install?

Do you have CCACHE_PATH in your environment?

Run 'make ccache-print-options|grep path'. It should have no value.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Rainer Hurling 
Am 25.11.15 um 19:50 schrieb Bryan Drewery:
> On 11/25/2015 10:09 AM, Juan Molina wrote:
>>> On 11/24/2015 1:31 AM, M - Krasznai András wrote:
 /What can I do to eliminate the ccache error during installworld
>>> apart from not using ccache? /
>>> I would recommend not setting CC or CCACHE_PATH in make.conf and using
>>> the new WITH_CCACHE_BUILD=yes option instead.
>>>
>>> -- 
>>> Regards,
>>> Bryan Drewery
>>
>> Hi.
>>
>> I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
>> defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.
>>
> 
> WITH_FAST_DEPEND is not related.
> 
> Are you building and installing as a different user? Using a different
> MAKEOBJDIRPREFIX in build and install?
> 
> Do you have CCACHE_PATH in your environment?
> 
> Run 'make ccache-print-options|grep path'. It should have no value.
> 

Is there any possibility to redirect the .ccache directory, something
like CCACHE_PATH for userland?

I am asking, because in my attempts to build base with WITH_CCACHE_BUILD
and WITH_FAST_DEPEND enabled, it breaks with error message 'file system
full'. My root partition has only 1GB and ccache itself seems to need
more than 800MB in /root/.ccache.

Thanks in advance,
Rainer Hurling

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Juan Ramón Molina Menor 

Le 25/11/2015 19:50, Bryan Drewery a écrit :

On 11/25/2015 10:09 AM, Juan Molina wrote:

On 11/24/2015 1:31 AM, M - Krasznai András wrote:

/What can I do to eliminate the ccache error during installworld

apart from not using ccache? /
I would recommend not setting CC or CCACHE_PATH in make.conf and using
the new WITH_CCACHE_BUILD=yes option instead.

--
Regards,
Bryan Drewery

Hi.

I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in src.conf.


WITH_FAST_DEPEND is not related.
OK, thanks. I was referring to the content of /etc/src.conf. By the way, 
there is no /etc/make.conf in this system.



Are you building and installing as a different user? Using a different
MAKEOBJDIRPREFIX in build and install?

Not at all, just following the /etc/src/UPDATING instructions, as root:

# cd /usr/src
# svn up
# make -j2 buildworld
# make -j2 kernel

# mergemaster -Fp
# make installworld COMPILER_TYPE="clang"

# mergemaster -Fi
# make delete-old


Do you have CCACHE_PATH in your environment?

Yes, it is set in /etc/csh.cshrc as indicate the ccache instructions:

# echo $CCACHE_PATH
/usr/bin:/usr/local/bin


Run 'make ccache-print-options|grep path'. It should have no value.

# make ccache-print-options | grep path
(environment) path =

Best regards,
Juan
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

FreeBSD_HEAD_i386 - Build #1764 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1764 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1764/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1764/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1764/console

Change summaries:

291332 by bdrewery:
Rename Makefile.inc1 to dtrace.test.mk to avoid clash with top-level 
Makefile.inc1.

Discussed with: ngie, markj
Sponsored by:   EMC / Isilon Storage Division

291331 by bdrewery:
Avoid requiring 'make depend' here.

Really this should not be a DPSRCS.  The acct_test.c should not #include
convert.c, but just link it in as a normal SRCS.

MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291330 by bdrewery:
Replace DPSRCS that work fine in SRCS.

This is so that 'make depend' is not a required build step in these
files.

DPSRCS is overall unneeded.  DPSRCS already contains SRCS, so anything
which can safely be in SRCS should be.  DPSRCS is mostly just a way to
generate files that should not be linked into the final PROG/LIB.  For
headers and grammars it is safe for them to be in SRCS since they will
be excluded during linking and installation.

The only remaining uses of DPSRCS are for generating .c or .o files that
must be built before 'make depend' can run 'mkdep' on the SRCS c files
list.  A semi-proper example is in tests/sys/kern/acct/Makefile where a
checked-in .c file has an #include on a generated .c file.  The
generated .c file should not be linked into the final PROG though since
it is #include'd.  The more proper way here is just to build/link it in
though without DPSRCS.  Another example is in sys/modules/linux/Makefile
where a shell script runs to parse a DPSRCS .o file that should not be
linked into the module.  Beyond those, the need for DPSRCS is largely
unneeded, redundant, and forces 'make depend' to be ran.  Generally,
these Makefiles should avoid the need for DPSRCS and define proper
dependencies for their files as well.

An example of an improper usage and why this matters is in usr.bin/netstat.
nl_defs.h was only in DPSRCS and so was not generated during 'make all',
but only during 'make depend'.  The files including it lacked proper
depenencies on it, which forced running 'make depend' to workaround that
bug.  The 'make depend' target should mostly be used for incremental build
help, not to produce a working build.  This specific example was broken in
the meta build until r287905 since it does not run 'make depend'.

The gnu/lib/libreadline/readline case is fine since bsd.lib.mk has 'OBJS:
SRCS:M*.h' when there is no .depend file.

Sponsored by:   EMC / Isilon Storage Division
MFC after:  1 week

291329 by bdrewery:
Remove redundant DPSRCS which were already in SRCS.

DPSRCS already contains all of SRCS.

MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291328 by lidl:
Have syslogd honor 'mesg' status when logging to users.

PR: bin/196742
Submitted by:   jef at mail acme com
Approved by:rpaulo (mentor)
Differential Revision:  https://reviews.freebsd.org/D4270

291327 by bdrewery:
Define a LIBDIR for every library that LIBADD provides.

This is going to be used to allow DIRDEPS to be bootstrapped off of
LIBADD/DPADD.  It currently works for internal libraries which have a
DIR defined for them but also use the .a library from a src-mapped obj
directory.  It can also be useful for using -L without a --sysroot per
LIBADD to use the OBJDIR version of the libraries.

I didn't review every LIBADD, so it is possible this is missing some.

Sponsored by:   EMC / Isilon Storage Division

291326 by bdrewery:
Fix spelling error.

291325 by bdrewery:
META MODE: Avoid dirdep dependency on lib/libmd.

This avoids using the staged headers for sys/crypto/sha2/*.h, such as sha256.h,
which added an unneeded pre-build dependency on libmd to libcrypt.  This
header is an INCS in lib/libmd, but found via .PATH in sys/crypto/sha2.
Since the libcrypt build was already using the in-src libmd headers
directly, just teach it how to find the sha256.h header as well.

Sponsored by:   EMC / Isilon Storage Division

291324 by bdrewery:
META MODE: Fix MACHINE=host builds.

We need to not use -nostdinc since it breaks building of clang itself.  Use
-isystem rather than -I/usr/include and -nostdinc which gets us using
the stage include directory before searching the real host headers.
This allows removing more of the -I hacks to get host headers since the
headers are no longer excluded.  The -B seemed unneeded.

This fixes building of secure/lib/libcrypto which was looking at the
/usr/include/openssl/asn1.h header rather than the staged one.

This fixes building of clang which wants to find its own internal
headers in the STAGEDIR/usr/lib/clang/* path.

Sponsored by:   EMC / Isilon Storage Division

291323 by bdrewery:
Stop looking up the same id(1) results in sub-makes.

Sponsored by:   EMC / Isilon Storage Division

291322 by bdrewery:

FreeBSD_HEAD - Build #3565 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD - Build #3565 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3565/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3565/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3565/console

Change summaries:

291335 by ngie:
Fix building sys/modules/if_enc by adding missing headers

X-MFC with: r291292, r291299 (if that ever happens)
Pointyhat to: ae

291332 by bdrewery:
Rename Makefile.inc1 to dtrace.test.mk to avoid clash with top-level 
Makefile.inc1.

Discussed with: ngie, markj
Sponsored by:   EMC / Isilon Storage Division

291331 by bdrewery:
Avoid requiring 'make depend' here.

Really this should not be a DPSRCS.  The acct_test.c should not #include
convert.c, but just link it in as a normal SRCS.

MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291330 by bdrewery:
Replace DPSRCS that work fine in SRCS.

This is so that 'make depend' is not a required build step in these
files.

DPSRCS is overall unneeded.  DPSRCS already contains SRCS, so anything
which can safely be in SRCS should be.  DPSRCS is mostly just a way to
generate files that should not be linked into the final PROG/LIB.  For
headers and grammars it is safe for them to be in SRCS since they will
be excluded during linking and installation.

The only remaining uses of DPSRCS are for generating .c or .o files that
must be built before 'make depend' can run 'mkdep' on the SRCS c files
list.  A semi-proper example is in tests/sys/kern/acct/Makefile where a
checked-in .c file has an #include on a generated .c file.  The
generated .c file should not be linked into the final PROG though since
it is #include'd.  The more proper way here is just to build/link it in
though without DPSRCS.  Another example is in sys/modules/linux/Makefile
where a shell script runs to parse a DPSRCS .o file that should not be
linked into the module.  Beyond those, the need for DPSRCS is largely
unneeded, redundant, and forces 'make depend' to be ran.  Generally,
these Makefiles should avoid the need for DPSRCS and define proper
dependencies for their files as well.

An example of an improper usage and why this matters is in usr.bin/netstat.
nl_defs.h was only in DPSRCS and so was not generated during 'make all',
but only during 'make depend'.  The files including it lacked proper
depenencies on it, which forced running 'make depend' to workaround that
bug.  The 'make depend' target should mostly be used for incremental build
help, not to produce a working build.  This specific example was broken in
the meta build until r287905 since it does not run 'make depend'.

The gnu/lib/libreadline/readline case is fine since bsd.lib.mk has 'OBJS:
SRCS:M*.h' when there is no .depend file.

Sponsored by:   EMC / Isilon Storage Division
MFC after:  1 week

291329 by bdrewery:
Remove redundant DPSRCS which were already in SRCS.

DPSRCS already contains all of SRCS.

MFC after:  1 week
Sponsored by:   EMC / Isilon Storage Division

291328 by lidl:
Have syslogd honor 'mesg' status when logging to users.

PR: bin/196742
Submitted by:   jef at mail acme com
Approved by:rpaulo (mentor)
Differential Revision:  https://reviews.freebsd.org/D4270

291327 by bdrewery:
Define a LIBDIR for every library that LIBADD provides.

This is going to be used to allow DIRDEPS to be bootstrapped off of
LIBADD/DPADD.  It currently works for internal libraries which have a
DIR defined for them but also use the .a library from a src-mapped obj
directory.  It can also be useful for using -L without a --sysroot per
LIBADD to use the OBJDIR version of the libraries.

I didn't review every LIBADD, so it is possible this is missing some.

Sponsored by:   EMC / Isilon Storage Division

291326 by bdrewery:
Fix spelling error.

291325 by bdrewery:
META MODE: Avoid dirdep dependency on lib/libmd.

This avoids using the staged headers for sys/crypto/sha2/*.h, such as sha256.h,
which added an unneeded pre-build dependency on libmd to libcrypt.  This
header is an INCS in lib/libmd, but found via .PATH in sys/crypto/sha2.
Since the libcrypt build was already using the in-src libmd headers
directly, just teach it how to find the sha256.h header as well.

Sponsored by:   EMC / Isilon Storage Division

291324 by bdrewery:
META MODE: Fix MACHINE=host builds.

We need to not use -nostdinc since it breaks building of clang itself.  Use
-isystem rather than -I/usr/include and -nostdinc which gets us using
the stage include directory before searching the real host headers.
This allows removing more of the -I hacks to get host headers since the
headers are no longer excluded.  The -B seemed unneeded.

This fixes building of secure/lib/libcrypto which was looking at the
/usr/include/openssl/asn1.h header rather than the staged one.

This fixes building of clang which wants to find its own internal
headers in the STAGEDIR/usr/lib/clang/* path.

Sponsored by:   EMC / Isilon Storage Division

291323 by

FreeBSD_HEAD_i386 - Build #1763 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1763 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1763/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1763/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1763/console

Change summaries:

291316 by bdrewery:
META MODE: Don't add staged DPADDs to DIRDEPS when bootstrapping gendirdeps.

This was finding libraries that were installed into DESTDIR/usr/lib,
where DESTDIR is the stage directory, and then adding in usr/lib to
DIRDEPS.  Just exclude the STAGE_ROOT if defined.

Discussed with: sjg
Sponsored by:   EMC / Isilon Storage Division

291315 by bdrewery:
META MODE: Define variables this file uses that were defined elsewhere.

Discussed with: sjg
Sponsored by:   EMC / Isilon Storage Division

291314 by bdrewery:
META MODE: Don't truncate DIRDEPS for bootstrapping during gendirdeps.

Reviewed by:sjg
Sponsored by:   EMC / Isilon Storage Division

291313 by bdrewery:
META MODE: Rework circular dependency guard for librtld_db/libproc.

librtld_db only needs libutil.h to build, not the libproc library.  So
it can safely use its header and allow libproc to depend on librtld_rb
to be built first to link.  This is required after fixing ld --sysroot
in r291226.

Sponsored by:   EMC / Isilon Storage Division

291312 by bdrewery:
META MODE: Revert r287879 so that 'make -V' still uses AUTO_OBJ.

This has caused much confusion for myself as there are quite a lot of
variables that depend on having a proper ${.OBJDIR}.

Sponsored by:   EMC / Isilon Storage Division

291311 by bdrewery:
META MODE: Fix 'make the-lot' with recent locale changes

Sponsored by:   EMC / Isilon Storage Division

291310 by bdrewery:
Stop building vers.c in include/ and only build the needed osreldate.h.

Because of how osreldate.h was being built with newvers.sh, which always
spat out a vers.c dependent on SVN or git, the meta mode build was
considering osreldate.h to depend on the current git or SVN index.  This
would lead to entire tree rebuilds when modifying git's index.  There's
no reason to be generating vers.c here so just skip it.

While here, in mk-osreldate.sh rename PARAM_H to proper PARAMFILE (which
newvers.sh already has a default for) and remove unneeded export.

Sponsored by:   EMC / Isilon Storage Division

291309 by bdrewery:
META MODE: Avoid creating TESTS directories for bootstrap.

Sponsored by:   EMC / Isilon Storage Division

291308 by bdrewery:
META MODE: Don't override DESTDIR to the default when building the toolchain.

For this case, the normal META MODE staging logic should be used.  The
BSARGS having DESTDIR= is due to Makefile.inc1 overriding DESTDIR to
something when appropriate.  For the toolchain stage META MODE is in charge of
it, not Makefile.inc1.

At least include/, if staging it to the host stagedir, was impacted from
this.  Staging of include.host is not yet done.

Sponsored by:   EMC / Isilon Storage Division

291307 by bdrewery:
META MODE: Prefer INSTALL=tools/install.sh to lessen the need for xinstall.host.

This both avoids some dependencies on xinstall.host and allows
bootstrapping on older releases to work due to lack of at least 'install -l'
support.

Sponsored by:   EMC / Isilon Storage Division

291306 by gjb:
Fix tmpfs(5) '/tmp' mount point.

A stray trailing space snuck in with one of the recent
changes, making r290550 and r290573 effectively no-op.

MFC after:  3 days
Sponsored by:   The FreeBSD Foundation

291305 by bdrewery:
META MODE: Remove bin/cat.host dependency.

This likely slipped in during early testing; local.dirdeps.mk always
excludes bin/cat.host now.

Sponsored by:   EMC / Isilon Storage Division

291304 by adrian:
[ath] listen to all beacons in IBSS and software beacon miss.

I added MYBEACON support a while ago to listen to beacons that are only
for your configured BSSID.  For AR9380 and later NICs this results in
a lot less chip wakeups in station mode as it then only shows you beacons
that are destined to you.

However in IBSS mode you really do want to hear all beacons so you can do
IBSS merges.  Oops.

So only use MYBEACON for STA + not-scanning, and just use BEACON for
the other modes it used to use BEACON for.

This doesn't completely fix IBSS merges though - there are still some
conditions to chase down and fix.

291303 by adrian:
[net80211] log the A-MPDU setup attempt count as part of debugging.

I've seen some cases where we get stuck in a loop constantly trying to
negotiate A-MPDU TX which is definitely not supposed to happen.
This will let me see if it's something funky with the retry count or
not.



The end of the build log:

[...truncated 180680 lines...]
cc  -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   
-DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/GENERIC/opt_global.h 
-I. -I/usr/src/sys -fno-common -g -I/usr/obj/usr/src/sys/GENERIC  -mno-mmx 
-mno-sse -msoft-float -ffreestanding -fwrapv

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread Bryan Drewery 
On 11/25/2015 12:59 PM, Juan Ramón Molina Menor wrote:
> Le 25/11/2015 19:50, Bryan Drewery a écrit :
>> On 11/25/2015 10:09 AM, Juan Molina wrote:
 On 11/24/2015 1:31 AM, M - Krasznai András wrote:
> /What can I do to eliminate the ccache error during installworld
 apart from not using ccache? /
 I would recommend not setting CC or CCACHE_PATH in make.conf and using
 the new WITH_CCACHE_BUILD=yes option instead.

 -- 
 Regards,
 Bryan Drewery
>>> Hi.
>>>
>>> I’m seeing the same ccache errors and I do not have CC or CCACHE_PATH
>>> defined anywhere. Only WITH_CCACHE_BUILD and WITH_FAST_DEPEND in
>>> src.conf.
>>>
>> WITH_FAST_DEPEND is not related.
> OK, thanks. I was referring to the content of /etc/src.conf. By the way,
> there is no /etc/make.conf in this system.
> 
>> Are you building and installing as a different user? Using a different
>> MAKEOBJDIRPREFIX in build and install?
> Not at all, just following the /etc/src/UPDATING instructions, as root:
> 
> # cd /usr/src
> # svn up
> # make -j2 buildworld
> # make -j2 kernel
> 
> # mergemaster -Fp
> # make installworld COMPILER_TYPE="clang"
> 
> # mergemaster -Fi
> # make delete-old
> 
>> Do you have CCACHE_PATH in your environment?
> Yes, it is set in /etc/csh.cshrc as indicate the ccache instructions:
> 
> # echo $CCACHE_PATH
> /usr/bin:/usr/local/bin
> 
>> Run 'make ccache-print-options|grep path'. It should have no value.
> # make ccache-print-options | grep path
> (environment) path =
> 

Which branch and revision is this?


-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

FreeBSD_HEAD - Build #3564 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD - Build #3564 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3564/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3564/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD/3564/console

Change summaries:

291304 by adrian:
[ath] listen to all beacons in IBSS and software beacon miss.

I added MYBEACON support a while ago to listen to beacons that are only
for your configured BSSID.  For AR9380 and later NICs this results in
a lot less chip wakeups in station mode as it then only shows you beacons
that are destined to you.

However in IBSS mode you really do want to hear all beacons so you can do
IBSS merges.  Oops.

So only use MYBEACON for STA + not-scanning, and just use BEACON for
the other modes it used to use BEACON for.

This doesn't completely fix IBSS merges though - there are still some
conditions to chase down and fix.

291303 by adrian:
[net80211] log the A-MPDU setup attempt count as part of debugging.

I've seen some cases where we get stuck in a loop constantly trying to
negotiate A-MPDU TX which is definitely not supposed to happen.
This will let me see if it's something funky with the retry count or
not.

291302 by hselasky:
Update usage:
- Add missing description of "-c" option.
- Add one more usage example.

291301 by fabient:
The r241129 description was wrong that the scenario is possible
only for read locks on pcbs. The same race can happen with write
lock semantics as well.

The race scenario:

- Two threads (1 and 2) locate pcb with writer semantics (INPLOOKUP_WLOCKPCB)
 and do in_pcbref() on it.
- 1 and 2 both drop the inp hash lock.
- Another thread (3) grabs the inp hash lock. Then it runs in_pcbfree(),
 which wlocks the pcb. They must happen faster than 1 or 2 come INP_WLOCK()!
- 1 and 2 congest in INP_WLOCK().
- 3 does in_pcbremlists(), drops hash lock, and runs in_pcbrele_wlocked(),
 which doesn't free the pcb due to two references on it.
 Then it unlocks the pcb.
- 1 (or 2) gets wlock on the pcb, runs in_pcbrele_wlocked(), which doesn't
 report inp as freed, due to 2 (or 1) still helding extra reference on it.
 The thread tries to do smth with a disconnected pcb and crashes.

Submitted by:   emeric.pou...@stormshield.eu
Reviewed by:gleb@
MFC after:  1 week
Sponsored by: Stormshield
Tested by: Cassiano Peixoto, Stormshield

291300 by hselasky:
Add simple indent wrapper tool for style(9) checking GIT/SVN patches.
The indent_wrapper tool only accepts full context diffs and works by
identifying the surrounding C-block touched by a diff and passing only
that to indent for styling. In the end a diff is produced or an
external tool like meld can be invoked, to show the styling
differences.

291299 by ae:
Fix the build.

291298 by ume:
Fix udp entry of `netstat -TW'.

291296 by ngie:
Link localeconv(3) to localeconv_l(3)

MFC after: 3 days

291292 by ae:
Overhaul if_enc(4) and make it loadable in run-time.

Use hhook(9) framework to achieve ability of loading and unloading
if_enc(4) kernel module. INET and INET6 code on initialization registers
two helper hooks points in the kernel. if_enc(4) module uses these helper
hook points and registers its hooks. IPSEC code uses these hhook points
to call helper hooks implemented in if_enc(4).

291291 by ae:
Check that hhk_helper pointer isn't NULL before access.

It isn't forbidden to use NULL pointer for hook_helper in hookinfo
structure when hhook_add_hook() adds new helper hook.

291280 by cem:
NTB: WC/WB isn't enough; set MMR region as UC

And expose vm_memattr_t of current mapping to consumers (as well as the
ability to change it to one of UC, WB, WC).

After short discussion with:jhb (but no review)
Sponsored by:   EMC / Isilon Storage Division

291267 by jilles:
sh: Remove global state from nodes.c.

No functional change is intended.

291266 by kib:
Correct the number of DTLB entries reported for the CPUID Leaf 2
descriptor 0x6c.

Confirmed by:   Intel
MFC after:  3 days

291265 by mav:
Rename ASYNC_LIP_F8 to ASYNC_LIP_NOS_OLS_RECV.

New name better repsents its meaning for modern chips.

291264 by avos:
urtwn(4): rework ROM reading.

- Add error handling for urtwn_(r88e_)read_rom() and
urtwn_efuse_*() functions.
- Remove code duplication between urtwn_efuse_read() and
urtwn_r88e_read_rom().
- Merge r88e_rom and (r92c_)rom structures
(only one of them can be used at the same time).
- Other minor fixes / improvements.

Tested with RTL8188EU, STA mode
(URTWN_DEBUG + USB_DEBUG, hw.usb.urtwn.debug=3, no visual differences).

Reviewed by:kevlo
Approved by:adrian (mentor)
Differential Revision:  https://reviews.freebsd.org/D4253

291263 by cem:
ntb: Add MW tunable for MMR Xeon errata workaround

Adds a new tunable, ntb.hw.b2b_mw_idx, which specifies the offset (from the
total number of memory windows) to use for register access on hardware with
the SDOORBELL_LOCKUP errata.  The default is -1, i.e., the last memory
window.

We map BARs before

Re: freebsd-current compile with clang & ccache

2015-11-25 Thread NGie Cooper 

> On Nov 25, 2015, at 23:21, M - Krasznai András  
> wrote:
> 
> Thanks, but as far as I know WITH_CCACHE_BUILD is only for ports compilation 
> and novadays I use binary ports wherever I can.

It’s available in recent versions of FreeBSD CURRENT [1], [2] .
Cheers,
-NGie

1. https://lists.freebsd.org/pipermail/freebsd-arch/2015-November/017472.html
2. https://svnweb.freebsd.org/changeset/base/290526
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Andrey Chernov 
On 25.11.2015 17:35, Baptiste Daroussin wrote:
>> BTW, array size looks suspicious:
>> static wchar_t wab_months[12][MAX_ABMON_WIDTH * 2 * MB_LEN_MAX];
>> what MB_LEN_MAX doing here? This constant is for multiple-bytes encoded,
>> not for wide chars.
> Bad copy/paste sorry it should be "MAX_ABMON_WIDTH * 2"

I don't check deep enough, it seems first array
MAX_ABMON_WIDTH * MB_LEN_MAX + 1
and second one
MAX_ABMON_WIDTH * 2 + 1

-- 
http://ache.vniz.net/



signature.asc
Description: OpenPGP digital signature

RE: freebsd-current compile with clang & ccache

2015-11-25 Thread M - Krasznai András 
Thanks, but as far as I know WITH_CCACHE_BUILD is only for ports compilation 
and novadays I use binary ports wherever I can.

rgds

András



-Original Message-
From: Bryan Drewery [mailto:bdrew...@freebsd.org] 
Sent: Wednesday, November 25, 2015 5:35 PM
To: M - Krasznai András ; 
freebsd-current@freebsd.org
Subject: Re: freebsd-current compile with clang & ccache

On 11/24/2015 1:31 AM, M - Krasznai András wrote:
> What can I do to eliminate the ccache error during installworld apart from 
> not using ccache?

I would recommend not setting CC or CCACHE_PATH in make.conf and using the new 
WITH_CCACHE_BUILD=yes option instead.

--
Regards,
Bryan Drewery

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

FreeBSD_HEAD_i386 - Build #1760 - Failure

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1760 - Failure:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1760/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1760/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1760/console

Change summaries:

291296 by ngie:
Link localeconv(3) to localeconv_l(3)

MFC after: 3 days

291292 by ae:
Overhaul if_enc(4) and make it loadable in run-time.

Use hhook(9) framework to achieve ability of loading and unloading
if_enc(4) kernel module. INET and INET6 code on initialization registers
two helper hooks points in the kernel. if_enc(4) module uses these helper
hook points and registers its hooks. IPSEC code uses these hhook points
to call helper hooks implemented in if_enc(4).

291291 by ae:
Check that hhk_helper pointer isn't NULL before access.

It isn't forbidden to use NULL pointer for hook_helper in hookinfo
structure when hhook_add_hook() adds new helper hook.



The end of the build log:

[...truncated 161523 lines...]
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS -I. -I/usr/src/sys -I/usr/obj/usr/src/sys/GENERIC 
-D__printf__=__freebsd_kprintf__ -std=iso9899:1999   
/usr/src/sys/modules/i2c/controllers/pcf/../../../../dev/pcf/pcf.c 
/usr/src/sys/modules/i2c/controllers/pcf/../../../../dev/pcf/pcf_isa.c
--- depend_subdir_iic ---
--- .depend ---
rm -f .depend
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS -I. -I/usr/src/sys -I/usr/obj/usr/src/sys/GENERIC 
-D__printf__=__freebsd_kprintf__ -std=iso9899:1999   
/usr/src/sys/modules/i2c/iic/../../../dev/iicbus/iic.c
--- depend_subdir_cyapa ---
--- device_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
--- depend_subdir_smb ---
--- machine ---
--- depend_subdir_cyapa ---
--- bus_if.h ---
--- depend_subdir_smb ---
machine -> /usr/src/sys/i386/include
--- depend_subdir_cyapa ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
--- depend_subdir_smb ---
--- x86 ---
x86 -> /usr/src/sys/x86/include
--- device_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
--- bus_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
--- depend_subdir_cyapa ---
--- smbus_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/smbus/smbus_if.m -h
--- depend_subdir_smb ---
--- smbus_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/smbus/smbus_if.m -h
--- depend_subdir_cyapa ---
--- vnode_if.h ---
awk -f /usr/src/sys/tools/vnode_if.awk /usr/src/sys/kern/vnode_if.src -h
--- depend_subdir_isl ---
===> i2c/isl (depend)
--- depend_subdir_smb ---
--- .depend ---
rm -f .depend
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS -I. -I/usr/src/sys -I/usr/obj/usr/src/sys/GENERIC 
-D__printf__=__freebsd_kprintf__ -std=iso9899:1999   
/usr/src/sys/modules/i2c/smb/../../../dev/smbus/smb.c
--- depend_subdir_if_disc ---
===> if_disc (depend)
--- depend_subdir_i2c ---
--- depend_subdir_isl ---
--- machine ---
--- depend_subdir_cyapa ---
--- .depend ---
rm -f .depend
--- depend_subdir_isl ---
machine -> /usr/src/sys/i386/include
--- depend_subdir_cyapa ---
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS -I. -I/usr/src/sys -I/usr/obj/usr/src/sys/GENERIC 
-D__printf__=__freebsd_kprintf__ -std=iso9899:1999   
/usr/src/sys/modules/i2c/cyapa/../../../dev/cyapa/cyapa.c
--- depend_subdir_isl ---
--- x86 ---
x86 -> /usr/src/sys/x86/include
--- depend_subdir_if_disc ---
--- machine ---
--- depend_subdir_i2c ---
--- vnode_if_newproto.h ---
awk -f /usr/src/sys/tools/vnode_if.awk /usr/src/sys/kern/vnode_if.src -p
--- depend_subdir_if_disc ---
machine -> /usr/src/sys/i386/include
--- x86 ---
--- depend_subdir_if_edsc ---
===> if_edsc (depend)
--- depend_subdir_if_disc ---
x86 -> /usr/src/sys/x86/include
--- opt_inet.h ---
ln -sf /usr/obj/usr/src/sys/GENERIC/opt_inet.h opt_inet.h
--- opt_inet6.h ---
ln -sf /usr/obj/usr/src/sys/GENERIC/opt_inet6.h opt_inet6.h
--- .depend ---
rm -f .depend
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS -I. -I/usr/src/sys -I/usr/obj/usr/src/sys/GENERIC 
-D__printf__=__freebsd_kprintf__ -std=iso9899:1999   
/usr/src/sys/modules/if_disc/../../net/if_disc.c
--- depend_subdir_i2c ---
--- vnode_if_typedef.h ---
awk -f /usr/src/sys/tools/vnode_if.awk /usr/src/sys/kern/vnode_if.src -q
--- depend_subdir_if_edsc ---
--- machine ---
machine -> /usr/src/sys/i386/include
--- x86 ---
x86 -> /usr/src/sys/x86/include
--- depend_subdir_i2c ---
--- device_if.h ---
--- depend_subdir_if_edsc ---
--- .depend ---
--- depend_subdir_i2c ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
--- depend_subdir_if_edsc ---
rm -f .depend
CC='cc' mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE 
-DHAVE_KERNEL_OPTION_HEADERS

Re: Panic while waiting on wlan0

2015-11-25 Thread Florian Limberger 

Hi,

On 22.11.15 17:52, Adrian Chadd wrote:

Do this:

* compile in IEEE80211_DEBUG;
* do "wlandebug +scan"

That way we can see if net80211 is refusing to continue scanning.


As far as I can see it, net8011 (or iwn?) does refuse to scan.  These 
are the last lines concerning wlan0 from my dmesg:

> wlan0: Ethernet address: 00:24:d7:91:b5:44
> iwn0: iwn_read_firmware: ucode rev=0x09dd0401
> wlan0: link state changed to UP
> wlan0: link state changed to DOWN
> iwn0: device timeout

``wlandebug -i wlan0 +scan`` does nothing, until I restart the interface 
(my current workaround: ``ifconfig wlan0 down; sleep 3; ifconfig wlan0 
up && wpa_supplicant -B -Dbsd -iwlan0 -c/etc/wpa_supplicant.conf``), 
after which I can see the debug output in the dmesg (which you can find 
attached).


Regards,


flo
Copyright (c) 1992-2015 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 11.0-CURRENT #0 r291012+894433c(master): Wed Nov 18 15:00:12 CET 2015
r...@nachtschatten.purplekraken.com:/usr/obj/usr/src/sys/GENERIC amd64
FreeBSD clang version 3.7.0 (tags/RELEASE_370/final 246257) 20150906
WARNING: WITNESS option enabled, expect reduced performance.
VT(vga): resolution 640x480
can't re-use a leaf (hwpstate_verbose)!
module_register: cannot register cpu/ichss from kernel; already loaded from 
cpufreq.ko
Module cpu/ichss failed to register: 17
module_register: cannot register cpu/powernow from kernel; already loaded from 
cpufreq.ko
Module cpu/powernow failed to register: 17
module_register: cannot register cpu/est from kernel; already loaded from 
cpufreq.ko
Module cpu/est failed to register: 17
module_register: cannot register cpu/hwpstate from kernel; already loaded from 
cpufreq.ko
Module cpu/hwpstate failed to register: 17
module_register: cannot register cpu/p4tcc from kernel; already loaded from 
cpufreq.ko
Module cpu/p4tcc failed to register: 17
CPU: Intel(R) Core(TM) i5 CPU   M 560  @ 2.67GHz (2660.06-MHz K8-class CPU)
  Origin="GenuineIntel"  Id=0x20655  Family=0x6  Model=0x25  Stepping=5
  
Features=0xbfebfbff
  
Features2=0x29ae3ff
  AMD Features=0x28100800
  AMD Features2=0x1
  VT-x: PAT,HLT,MTF,PAUSE,EPT,UG,VPID
  TSC: P-state invariant, performance statistics
real memory  = 4294967296 (4096 MB)
avail memory = 3930210304 (3748 MB)
ACPI APIC Table: 
FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs
FreeBSD/SMP: 1 package(s) x 2 core(s) x 2 SMT threads
 cpu0 (BSP): APIC ID:  0
 cpu1 (AP): APIC ID:  1
 cpu2 (AP): APIC ID:  4
 cpu3 (AP): APIC ID:  5
random: unblocking device.
ACPI BIOS Warning (bug): 32/64X length mismatch in FADT/Pm1aControlBlock: 16/32 
(20150818/tbfadt-649)
ACPI BIOS Warning (bug): Invalid length for FADT/Pm1aControlBlock: 32, using 
default 16 (20150818/tbfadt-730)
ioapic0: Changing APIC ID to 1
ioapic0  irqs 0-23 on motherboard
random: entropy device external interface
kbd1 at kbdmux0
netmap: loaded module
module_register_init: MOD_LOAD (vesa, 0x80edc3c0, 0) error 19
vtvga0:  on motherboard
cryptosoft0:  on motherboard
acpi0:  on motherboard
acpi_ec0:  port 0x62,0x66 on acpi0
acpi0: Power Button (fixed)
cpu0:  on acpi0
cpu1:  on acpi0
cpu2:  on acpi0
cpu3:  on acpi0
attimer0:  port 0x40-0x43 irq 0 on acpi0
Timecounter "i8254" frequency 1193182 Hz quality 0
Event timer "i8254" frequency 1193182 Hz quality 100
hpet0:  iomem 0xfed0-0xfed003ff on acpi0
Timecounter "HPET" frequency 14318180 Hz quality 950
Event timer "HPET" frequency 14318180 Hz quality 550
Event timer "HPET1" frequency 14318180 Hz quality 440
Event timer "HPET2" frequency 14318180 Hz quality 440
Event timer "HPET3" frequency 14318180 Hz quality 440
Event timer "HPET4" frequency 14318180 Hz quality 440
atrtc0:  port 0x70-0x71 irq 8 on acpi0
Event timer "RTC" frequency 32768 Hz quality 0
Timecounter "ACPI-safe" frequency 3579545 Hz quality 850
acpi_timer0: <24-bit timer at 3.579545MHz> port 0x1008-0x100b on acpi0
acpi_lid0:  on acpi0
acpi_button0:  on acpi0
pcib0:  on acpi0
pci0:  on pcib0
pcib1:  port 0xcf8-0xcff on acpi0
pci1:  on pcib1
pcib2:  irq 16 at device 1.0 on pci1
pci2:  on pcib2
vgapci0:  port 0x2000-0x207f mem 
0xcc00-0xccff,0xd000-0xdfff,0xce00-0xcfff irq 16 at 
device 0.0 on pci2
nvidia0:  on vgapci0
vgapci0: child nvidia0 requested pci_enable_io
vgapci0: child nvidia0 requested pci_enable_io
vgapci0: Boot video device
hdac0:  mem 0xcdefc000-0xcdef at device 0.1 
on pci2
pci1:  at device 22.0 (no driver attached)
uart2: <5 Series/3400 Series Chipset KT Controller> port 0x1800-0x1807 mem 
0xf2424000-0xf2424fff irq 17 at device 22.3 on pci1
em0:

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Baptiste Daroussin 
On Wed, Nov 25, 2015 at 04:34:17PM +0300, Andrey Chernov wrote:
> On 25.11.2015 15:53, Baptiste Daroussin wrote:
> > What I did for now is set max_month_width to -1 and in ls_strftime I 
> > fallback on
> > the plain strftime meaning you keep localized information but the 
> > alignement is
> > broken as of now.
> 
> It will be enough.
> 
> >> 3) wcwidth/wcswidth may return -1 too, it needs to be checked too.
> > done and truncate the name of the month to the latest valid character
> 
> I think there is no point for sofisticated truncating, if locale is not
> valid. F.e. you may truncate to just 1 char. The thing above will be
> enough for all such cases.
> 
> > Review updated (if you prefer a diff by mail just tell me, given you do not 
> > have
> > a phabricator account.)
> 
> I don't have phabricator.
> 
> This one
> if ((n = max_month_width - wab_months_width[i]) > 0) {
> wcslcat(wab_months[i], L" "/* MAX_ABMON_WIDTH */,
> max_month_width + 1);
> }
> should be
> if ((n = max_month_width - wab_months_width[i]) > 0)
> wcslcat(wab_months[i], L" "/* MAX_ABMON_WIDTH */, n);
> 
> I.e. you append n spaces and n is the difference between max and current.

With wcsncat I would agree, but not with wcslcat.

wcslcat works like strlcat:
to quote the manpage:
"It will append at most dstsize - strlen(dst) - 1 characters."
So here with your version it will be n - wcslen(wab_months[i]) -1
which won't fit what we want to do.

btw that makes me figure out that what I want is wcsncat because we do care to
make sure we have appended the right number of spaces at the end of the
abbreviated month based on character width, not the on the len of the wide
string

so I changed it

if ((n = max_month_width - wab_months_width[i]) > 0)
wcsncat(wab_months[i], L" "/* MAX_ABMON_WIDTH */, n);

If you do not have further comments, I will commit that later today.

Then I will work on libarchive and pax (would you like to review the patches for
those?)

Best regards,
Bapt


signature.asc
Description: PGP signature

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Baptiste Daroussin 
On Wed, Nov 25, 2015 at 04:31:21AM +0300, Andrey Chernov wrote:
> On 25.11.2015 3:15, Baptiste Daroussin wrote:
> > On Sat, Nov 21, 2015 at 11:57:46PM +0300, Andrey Chernov wrote:
> >> On 21.11.2015 15:18, Ed Schouten wrote:
> >>> Hi Baptiste,
> >>>
> >>> I suppose you should use the wcswidth() function somewhere to compute
> >>> the visible width of the month name. Some characters may be
> >>> double-width, others may have no effective width at all.
> >>>
> >>
> >> I agree. Checking error return of wide chars functions with some
> >> fallback will be good too.
> > 
> > I have updated the code https://reviews.freebsd.org/D4239
> > 
> > Tested by modifying some locales to add double width and zero width unicode 
> > in
> > the locales
> > 
> > Also added the error checking for the return of wide chars functions. For 
> > now I
> > haven't added fallback, suggestions welcome if needed.
> 
> 1) For just 1 char in wcswidth(_months[i][j], 1); it is better to
> use another function wcwidth(wab_months[i][j]);

done
> 
> 2) By fallback I mean something which not stops ls working with
> incorrect for some reason locale, like setting max_width_month to
> MAX_ABMON_WIDTH on error return (from
> mbstowcs/wcwidth/wcswidth/wcswidth) and exit from
> populate_abbreviated_month().

Not that easy to provide a fallback (or better to say I can't find a proper way)
it if fails on mbstocws then ab_months is not populated so unusable.
What I did for now is set max_month_width to -1 and in ls_strftime I fallback on
the plain strftime meaning you keep localized information but the alignement is
broken as of now.

> 
> 3) wcwidth/wcswidth may return -1 too, it needs to be checked too.
done and truncate the name of the month to the latest valid character
> 
> 4) The whole processing looks overcomplicated and not effective. What
> about this instead?
> for (i = 0; i < 12; i++) {
> count wcswidth() of each month and store it in wab_months_width[].
> count max_width_month.
> }
> for (i = 0; i < 12; i++) {
> if ((n = max_width_month - wab_months_width[i]) > 0)
>   call wcscat(wab_months[i], L" ") n times.
> }

Done, along with your optimisation from your next mail
> 
> 5) If there is no %b is strftime() format, there is no sense to spend
> CPU cycles on from populate_abbreviated_month(), so it should be called
> only once inside ls_strftime() on first %b instead of calling it in
> printtime() for all cases.

done

Review updated (if you prefer a diff by mail just tell me, given you do not have
a phabricator account.)

Thanks for your patience! and reviews!

Bapt


signature.asc
Description: PGP signature

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Andrey Chernov 
On 25.11.2015 16:51, Baptiste Daroussin wrote:
> wcslcat works like strlcat:
> to quote the manpage:
> "It will append at most dstsize - strlen(dst) - 1 characters."
> So here with your version it will be n - wcslen(wab_months[i]) -1
> which won't fit what we want to do.
> 
> btw that makes me figure out that what I want is wcsncat because we do care to
> make sure we have appended the right number of spaces at the end of the
> abbreviated month based on character width, not the on the len of the wide
> string
> 
> so I changed it
> 
> if ((n = max_month_width - wab_months_width[i]) > 0)
> wcsncat(wab_months[i], L" "/* MAX_ABMON_WIDTH */, n);

Sorry, I initially mean wcsncat() functionality here, wcslcat() is
sneaked in due to wrong memorizing.

About width counting and fallback...
Without attempt to nicely truncate data damaged by unknown way the code
will be simpler. Instead all that loop adding width one by one wchar, just:

width = wcswidth(wab_months[i], MAX_ABMON_WIDTH);
if (width == -1) {
max_month_width = -1;
return;
}
wab_months_width[i] = width;

About
/* NULL terminate to simplify padding later */
wab_months[i][j] = L'\0';
You don't need it, mbstowcs() null-terminates result, if there is a room.
BTW, array size looks suspicious:
static wchar_t wab_months[12][MAX_ABMON_WIDTH * 2 * MB_LEN_MAX];
what MB_LEN_MAX doing here? This constant is for multiple-bytes encoded,
not for wide chars.

-- 
http://ache.vniz.net/



signature.asc
Description: OpenPGP digital signature

FreeBSD_HEAD_i386 - Build #1761 - Still Failing

2015-11-25 Thread jenkins-admin 
FreeBSD_HEAD_i386 - Build #1761 - Still Failing:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1761/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1761/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/1761/console

Change summaries:

291299 by ae:
Fix the build.

291298 by ume:
Fix udp entry of `netstat -TW'.



The end of the build log:

[...truncated 180716 lines...]
ctfconvert -L VERSION -g if_bridge.o
--- all_subdir_if_edsc ---
ctfconvert -L VERSION -g if_edsc.o
--- all_subdir_if_bridge ---
--- if_bridge.kld ---
ld -d -warn-common -r -d -o if_bridge.kld if_bridge.o
ctfmerge -L VERSION -g -o if_bridge.kld if_bridge.o
--- all_subdir_if_edsc ---
--- if_edsc.kld ---
ld -d -warn-common -r -d -o if_edsc.kld if_edsc.o
ctfmerge -L VERSION -g -o if_edsc.kld if_edsc.o
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk if_edsc.kld  export_syms | xargs -J% 
objcopy % if_edsc.kld
--- all_subdir_if_bridge ---
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk if_bridge.kld  export_syms | xargs -J% 
objcopy % if_bridge.kld
--- all_subdir_if_edsc ---
--- if_edsc.ko.full ---
ld -Bshareable -d -warn-common -o if_edsc.ko.full if_edsc.kld
--- all_subdir_if_enc ---
/usr/src/sys/net/if_enc.c:104:43: error: use of undeclared identifier 
'IPSEC_ENC_BEFORE'
--- all_subdir_if_edsc ---
--- if_edsc.ko.debug ---
objcopy --only-keep-debug if_edsc.ko.full if_edsc.ko.debug
--- all_subdir_if_bridge ---
--- if_bridge.ko.full ---
ld -Bshareable -d -warn-common -o if_bridge.ko.full if_bridge.kld
--- all_subdir_if_edsc ---
--- if_edsc.ko ---
objcopy --strip-debug --add-gnu-debuglink=if_edsc.ko.debug  if_edsc.ko.full 
if_edsc.ko
--- all_subdir_ibcs2 ---
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk ibcs2.kld  export_syms | xargs -J% 
objcopy % ibcs2.kld
--- tbinstal.o ---
--- modules-all ---
--- all_subdir_if_bridge ---
--- if_bridge.ko.debug ---
--- tbinstal.o ---
cc  -c -O -pipe  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt 
-D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h  -mno-mmx -mno-sse 
-msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall 
-Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes 
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign 
-D__printf__=__freebsd_kprintf__  -Wmissing-include-dirs 
-fdiagnostics-show-option  -Wno-unknown-pragmas  
-Wno-error-tautological-compare -Wno-error-empty-body  
-Wno-error-parentheses-equality -Wno-error-unused-function  
-Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-aes -mno-avx  
-std=iso9899:1999 -Werror  
/usr/src/sys/contrib/dev/acpica/components/tables/tbinstal.c
--- modules-all ---
objcopy --only-keep-debug if_bridge.ko.full if_bridge.ko.debug
--- all_subdir_if_enc ---
static VNET_DEFINE(int, filter_mask_in) = IPSEC_ENC_BEFORE;
  ^
/usr/src/sys/net/if_enc.c:105:40: error: use of undeclared identifier 
'IPSEC_ENC_BEFORE'
static VNET_DEFINE(int, bpf_mask_in) = IPSEC_ENC_BEFORE;
   ^
/usr/src/sys/net/if_enc.c:106:44: error: use of undeclared identifier 
'IPSEC_ENC_BEFORE'
static VNET_DEFINE(int, filter_mask_out) = IPSEC_ENC_BEFORE;
   ^
--- all_subdir_if_bridge ---
--- if_bridge.ko ---
objcopy --strip-debug --add-gnu-debuglink=if_bridge.ko.debug  if_bridge.ko.full 
if_bridge.ko
--- all_subdir_if_epair ---
===> if_epair (all)
--- all_subdir_if_enc ---
/usr/src/sys/net/if_enc.c:107:41: error: use of undeclared identifier 
'IPSEC_ENC_BEFORE'
--- all_subdir_ibcs2 ---
--- ibcs2.ko.full ---
ld -Bshareable -d -warn-common -o ibcs2.ko.full ibcs2.kld
--- all_subdir_if_enc ---
static VNET_DEFINE(int, bpf_mask_out) = IPSEC_ENC_BEFORE | IPSEC_ENC_AFTER;
^
/usr/src/sys/net/if_enc.c:107:60: error: use of undeclared identifier 
'IPSEC_ENC_AFTER'
static VNET_DEFINE(int, bpf_mask_out) = IPSEC_ENC_BEFORE | IPSEC_ENC_AFTER;
   ^
/usr/src/sys/net/if_enc.c:226:9: error: incomplete definition of type 'struct 
ipsec_ctx_data'
if (ctx->af != hhook_id)
~~~^
/usr/src/sys/netipsec/ipsec.h:261:8: note: forward declaration of 'struct 
ipsec_ctx_data'
struct ipsec_ctx_data;
   ^
/usr/src/sys/net/if_enc.c:229:22: error: use of undeclared identifier 
'HHOOK_TYPE_IPSEC_IN'
if (((hhook_type == HHOOK_TYPE_IPSEC_IN &&
^
/usr/src/sys/net/if_enc.c:230:10: error: incomplete definition of type 'struct 
ipsec_ctx_data'
(ctx->enc & V_bpf_mask_in) != 0) ||
 ~~~^
/usr/src/sys/netipsec/ipsec.h:261:8: note: forward declaration of 'struct 
ipsec_ctx_data'
struct ipsec_ctx_data;
   ^
--- all_subdir_ibcs2 ---
--- ibcs2.ko.debug ---
objcopy --only-keep-debug ibcs2.ko.full ibcs2.ko.debug
--- all_subdir_if_enc ---
/usr/src/sys/net/if_enc.c:231:21: error: use of

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Andrey Chernov 
On 25.11.2015 15:53, Baptiste Daroussin wrote:
> What I did for now is set max_month_width to -1 and in ls_strftime I fallback 
> on
> the plain strftime meaning you keep localized information but the alignement 
> is
> broken as of now.

It will be enough.

>> 3) wcwidth/wcswidth may return -1 too, it needs to be checked too.
> done and truncate the name of the month to the latest valid character

I think there is no point for sofisticated truncating, if locale is not
valid. F.e. you may truncate to just 1 char. The thing above will be
enough for all such cases.

> Review updated (if you prefer a diff by mail just tell me, given you do not 
> have
> a phabricator account.)

I don't have phabricator.

This one
if ((n = max_month_width - wab_months_width[i]) > 0) {
wcslcat(wab_months[i], L" "/* MAX_ABMON_WIDTH */,
max_month_width + 1);
}
should be
if ((n = max_month_width - wab_months_width[i]) > 0)
wcslcat(wab_months[i], L" "/* MAX_ABMON_WIDTH */, n);

I.e. you append n spaces and n is the difference between max and current.

-- 
http://ache.vniz.net/



signature.asc
Description: OpenPGP digital signature

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-25 Thread Baptiste Daroussin 
On Wed, Nov 25, 2015 at 05:06:17PM +0300, Andrey Chernov wrote:
> On 25.11.2015 16:51, Baptiste Daroussin wrote:
> > wcslcat works like strlcat:
> > to quote the manpage:
> > "It will append at most dstsize - strlen(dst) - 1 characters."
> > So here with your version it will be n - wcslen(wab_months[i]) -1
> > which won't fit what we want to do.
> > 
> > btw that makes me figure out that what I want is wcsncat because we do care 
> > to
> > make sure we have appended the right number of spaces at the end of the
> > abbreviated month based on character width, not the on the len of the wide
> > string
> > 
> > so I changed it
> > 
> > if ((n = max_month_width - wab_months_width[i]) > 0)
> > wcsncat(wab_months[i], L" "/* MAX_ABMON_WIDTH */, n);
> 
> Sorry, I initially mean wcsncat() functionality here, wcslcat() is
> sneaked in due to wrong memorizing.
> 
> About width counting and fallback...
> Without attempt to nicely truncate data damaged by unknown way the code
> will be simpler. Instead all that loop adding width one by one wchar, just:
> 
> width = wcswidth(wab_months[i], MAX_ABMON_WIDTH);
> if (width == -1) {
> max_month_width = -1;
> return;
> }
> wab_months_width[i] = width;
> 
> About
> /* NULL terminate to simplify padding later */
> wab_months[i][j] = L'\0';
> You don't need it, mbstowcs() null-terminates result, if there is a room.

right if should be only set on the month we do truncate to MAX_ABMON_WIDTH

> BTW, array size looks suspicious:
> static wchar_t wab_months[12][MAX_ABMON_WIDTH * 2 * MB_LEN_MAX];
> what MB_LEN_MAX doing here? This constant is for multiple-bytes encoded,
> not for wide chars.
Bad copy/paste sorry it should be "MAX_ABMON_WIDTH * 2"


I will fix
Bapt


signature.asc
Description: PGP signature