Re: setfacl Recursive Functionality

2011-02-08 Thread Tim Kientzle
On Feb 8, 2011, at 9:58 AM, Shawn Webb wrote: > I've just finished a patch to add recursive functionality to setfacl. Before > I officially submit it, I'd like a few suggestions on how to improve the > patch. > > The part I'm worried about involves the #define directive at top. I'm not > sure what

Re: setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
On Tue, Feb 8, 2011 at 7:35 PM, Tim Kientzle wrote: > On Feb 8, 2011, at 9:58 AM, Shawn Webb wrote: > > I've just finished a patch to add recursive functionality to setfacl. > Before > > I officially submit it, I'd like a few suggestions on how to improve the > > patch. > > > > The part I'm worri

Re: setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
Attached is the patch. I'm also storing my FreeBSD patches at https://github.com/lattera/patches Thanks, Shawn On Tue, Feb 8, 2011 at 11:30 AM, Miroslav Lachman <000.f...@quip.cz> wrote: > Shawn Webb wrote: > >> I've just finished a patch to add recursive functionality to setfacl. >> Before >>

Re: [PATCH] OpenSolaris/ZFS: C++ compatibility

2011-02-08 Thread Baptiste Daroussin
> I've developed similar API during HAST work, maybe it is a good starting > point? src/sbin/hastd/nv.{c,h}. > What about pushing this into some public libraries, I think this could be usefull in libc ou libutil or something like that? regards, Bapt ___

Re: setfacl Recursive Functionality

2011-02-08 Thread Miroslav Lachman
Shawn Webb wrote: I've just finished a patch to add recursive functionality to setfacl. Before I officially submit it, I'd like a few suggestions on how to improve the patch. The part I'm worried about involves the #define directive at top. I'm not sure what ramifications using that define might

Re: [RFC] removing broken includes

2011-02-08 Thread Roman Divacky
I see it crashes very early on ;) can you report: Assertion failed: (isValid()), function getSpellingLoc, file SourceLocation.cpp, line 84. this stuff to the developers? the tool looks pretty useful On Tue, Feb 08, 2011 at 11:58:27AM +, Alexander Best wrote: > On Fri Feb 4 11, Garrett Coop

setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
I've just finished a patch to add recursive functionality to setfacl. Before I officially submit it, I'd like a few suggestions on how to improve the patch. The part I'm worried about involves the #define directive at top. I'm not sure what ramifications using that define might have. I needed it f

Re: [RFC] removing broken includes

2011-02-08 Thread Alexander Best
On Fri Feb 4 11, Garrett Cooper wrote: > On Fri, Feb 4, 2011 at 10:53 PM, Roman Divacky wrote: > > alex, > > > > I think you are the kind of person to try out > > > > http://code.google.com/p/include-what-you-use/ > > > > with fbsd :) > > Please be careful with this tool though. There's head