Re: no X after installing xorg + xfce
On Sat, 17 Sep 2011 21:36:50 -0700 Garrett Cooper yaneg...@gmail.com wrote: On Sat, Sep 17, 2011 at 9:28 PM, Thomas Mueller mueller6727@bellsouth.net wrote: I have successfully installed FreeBSD-9.0-BETA2 to an amd64 bit machine, I have used the ports to install xfce and xorg. When I type startx, I get a screen with a bunch of colors no mouse, no keyboard, just colors. The machine has nvidia onboard graphics. I am trying to get kernel sources installed via sysinstall to install nvidia-driver but I can't get anywhere from any ftp site I select at random. I have updated to latest sources available on the ports and it comes up the same. I have to use the nv driver, should I try the nouveau driver? What should I do? I want to help in testing and have no way to report bugs as without X there's not much one can do :( Is it not automatically installed when one goes into /usr/ports/x11/xorg, and runs make install clean? You would get the xorg server with the xorg metaport/megaport. One thing I can think of is a little dirty trick I have seen in FreeBSD but not NetBSD or Linux, X comes up but no response to mouse or keyboard. I ran startx, got twm with its windows, but no response to mouse or keyboard. Cure was, to include in /etc/rc.conf hald_enable=YES dbus_enable=YES This seems like more of a question@ issue. I doubt that the above claim is at fault, given past experience. What does /var/log/Xorg.0.log say, and what does your xorg.conf contain? This may not be relevant, but I had a similar problem when I installed xorg-dev a few weeks ago. I'd forgotten to update the mouse and keyboard drivers and they apparently are not updated automatically. So try going into /usr/ports/x11-drivers and reinstalling xf86-input-mouse and xf86-input-keyboard. -- Gary Jennejohn ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 bata2 keymap
On 17 September 2011 22:42, Fbsd8 fb...@a1poweruser.com wrote:
Chris Rees wrote:
On 17 Sep 2011 17:25, Fbsd8 fb...@a1poweruser.com wrote:
Nathan Whitehorn wrote:
On 09/15/11 14:57, Fbsd8 wrote:
Out of the 9 USA maps only us.iso.acc.kbd worked somewhat.
The keyboard 9 key block above the arrow keys don't function.
Issuing the man cmd_name command doe's display the man page,
but the {Page up, Page down keys } don't work.
Also when using the ee edit command the {delete, Page up, Page down
keys } don't work. This does not happen in any of the previous
releases.
Further more, localization of the keyboard should not be forced on
the
user during the install process. This BSDinstall option should be
disabled or removed.
You can press Cancel there, which will cancel keymap selection and
keep the default. The utility being invoked is just kbdmap(1), and any
changes to it need to go there.
-Nathan
.. maybe name that button skip then?
The button is provided by kbdmap, as is the entire screen. We could add
an installer mode to kbdmap that names it skip instead of cancel, of
course. I'm traveling for another 2 weeks and won't have time to do
that,
however.
-Nathan
Nathan
Its good to be talking directly with the bsdinstall author.
Changing the cancel button in the kbdmap command to skip, does not
address
the problem, which is the lack of knowledge of the standard bsdinstall
user.
I've been using Freebsd since 4.0 and never used the kbdmap command or for
that matter even knew it existed.
Wait, are you suggesting that everyone on Earth can make do with the
standard keyboard layout until they learn rc.conf syntax?
I would strongly object if localisation of the keyboard were not forced
on
the user; we don't all use pc105-us, and the ability to use the keyboard
properly early on is kinda helpful.
Chris
You would help yourself a great deal if you read the complete post before
jumping in. The rest of the post (ie: the part you neglected to include in
your post) clearly describes what I am suggesting.
I had read the rest of your post, and found it rather difficult to
follow. The fact remains that every other installer I have ever used
gives the user the choice of keymap, so I don't really understand your
problem.
If you're not suggesting removing localisation from bsdinstall, then
please accept my apologies.
Chris
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 bata2 keymap
Hello, Chris. You wrote 18 сентября 2011 г., 12:03:34: I had read the rest of your post, and found it rather difficult to follow. The fact remains that every other installer I have ever used gives the user the choice of keymap, so I don't really understand your problem. IMHO, main problem is, that in bsdinstall it is completely unclear how to have English keymap and other one and switch between them. For example, it is very natural to select Russian in Russia, but, nobody (ok, may be ALMOST nobody) in Russia want to enter Russian hostname, usernames and root password. And it is completely unobvious how to switch back to English after selecting Russian keymap. I think, other national keymaps have exactly same problem. And if Western-European ones allow to enter basic ASCII letters (and only add some diacritics, and, maybe, alert keys placement, like Z-A swap), and things like Dvorak allows it too (for sure!), but more specific national keymaps doesn't contain ASCII (Latin) letters at all. IMHO, selecting one and only one keymap without selecting at leas two of them and switching key have very limited use. It could be used to select variants of English maps (QWERTY vs Dvorak, different placement of additional characters, etc) and to select Latin-based maps with some extended characters. All other (Russian and other Cyrillic, Japan, Arabic, etc.,) need TWO keymaps right at installation time and configurable/known way to switch between them. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 bata2 keymap
Hi all, Just keep in mind that Nathan is currently on holiday. Please don't be disenheartened if he doesn't reply or if bsdinstaller isn't 'fixed' until then. As always, patches == best. Adrian ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 beta2 the new bsdinstaller
Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). Another concern is updating to the next beta (BETA3?) without trashing the installed application software (from ports). So far, bsdinstaller hasn't offered any possibility of upgrading an existing installation. I don't think a user wants to rebuild all ports for every new beta or release candidate. Tom ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: cvsup broken on amd64?
Hi,
So I've taken a look at the csup source.
The problem here is the updater thread setting the closed state
(fixups_closed()) before calling updater_batch() again to handle
fixups.
Checking for size != 0 at that point may not be valid at the list size
may actually be 0 for a short period of time.
What about this patch:
Index: updater.c
===
--- updater.c (revision 224905)
+++ updater.c (working copy)
@@ -240,9 +240,9 @@
* Make sure to close the fixups even in case of an error,
* so that the lister thread doesn't block indefinitely.
*/
- fixups_close(up-config-fixups);
if (!error)
error = updater_batch(up, 1);
+ fixups_close(up-config-fixups);
switch (error) {
case UPDATER_ERR_PROTO:
xasprintf(args-errmsg, Updater failed: Protocol error);
Oliver, would you please try that?
Thanks,
Adrian
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: cvsup broken on amd64?
Adrian Chadd adr...@freebsd.org wrote: So I've taken a look at the csup source. [...] What about this patch: [...] Oliver, would you please try that? I have a problem with cvsup, not csup - Alexander mentioned a csup problem. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: cvsup broken on amd64?
On Sun, Sep 18, 2011 at 12:22:53PM +0200, Oliver Lehmann wrote: Adrian Chadd adr...@freebsd.org wrote: So I've taken a look at the csup source. [...] What about this patch: [...] Oliver, would you please try that? I have a problem with cvsup, not csup - Alexander mentioned a csup problem. Did you saw the message with the patch for tzcode I mailed to you ? pgpxG7jeO8J6E.pgp Description: PGP signature
Re: cvsup broken on amd64?
Ah, you're the one with the csup problem.
Would you mind trying csup again, and if it doesn't work, try this patch:
Index: updater.c
===
--- updater.c (revision 224905)
+++ updater.c (working copy)
@@ -240,9 +240,9 @@
* Make sure to close the fixups even in case of an error,
* so that the lister thread doesn't block indefinitely.
*/
- fixups_close(up-config-fixups);
if (!error)
error = updater_batch(up, 1);
+ fixups_close(up-config-fixups);
switch (error) {
case UPDATER_ERR_PROTO:
xasprintf(args-errmsg, Updater failed: Protocol error);
There's a PR open now (154954) but the patch may be wrong.
thanks,
Adrian
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: bsdgrep: does anyone see this?
FreeBSD 9.0-BETA2 #0 r225641 amd64 $ echo |grep -q '^'; echo $? 0 $ echo |grep -qv '^'; echo $? 1 $ echo |bsdgrep -q '^'; echo $? 1 $ echo |bsdgrep -qv '^'; echo $? 0 -- View this message in context: http://freebsd.1045724.n5.nabble.com/bsdgrep-does-anyone-see-this-tp4815133p4815764.html Sent from the freebsd-current mailing list archive at Nabble.com. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Kernel panic after an upgrade
I forgot to add. Following http://lists.freebsd.org/pipermail/freebsd-current/2011-September/027059.html I disabled vboxdrv and cuse4bsd modules. On Sun, Sep 18, 2011 at 12:44 PM, Piotr Kubaj pku...@gmail.com wrote: I upgraded on 16th September to the newest snapshot. Everything compiled well, but after rebooting to the new system, hal couldn't start. I tried to start it manually, however, there was a message that libcam.so.5 couldn't be found. Seeing that this library is in the base system, I recompiled hal and dbus. I rebooted and that's when kernel panics started. I've attached the core.txt file. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Segfault in libthr.so on 9.0-BETA2 (with stunnel FWIW)
On Wed, Sep 14, 2011 at 11:04:56PM +0300, Kostik Belousov wrote:
tzload() allocates ~80KB for the local variables. The backtrace you provided
shows the nested call to tzload(), so there is total 160KB of the stack
space consumed.
By default, stack for the amd64 thread is 4MB, that should be plenty. This
is not the case for ezm3. Possibly, stunnel also reduces the size of the
thread stack.
Please, try the patch below. I did not tested it, only compiled. I see
that now tzload allocates only ~300 bytes on the stack.
80KB seems quite a lot indeed, good to bring it down.
diff --git a/contrib/tzcode/stdtime/localtime.c
b/contrib/tzcode/stdtime/localtime.c
index 80b70ac..55d55e0 100644
--- a/contrib/tzcode/stdtime/localtime.c
+++ b/contrib/tzcode/stdtime/localtime.c
[snip]
@@ -406,16 +409,24 @@ register const int doextend;
** to hold the longest file name string that the implementation
** guarantees can be opened.
*/
- charfullname[FILENAME_MAX + 1];
+ char*fullname;
+
+ fullname = malloc(FILENAME_MAX + 1);
+ if (fullname == NULL)
+ goto out;
if (name[0] == ':')
++name;
doaccess = name[0] == '/';
if (!doaccess) {
- if ((p = TZDIR) == NULL)
+ if ((p = TZDIR) == NULL) {
+ free(fullname);
return -1;
- if ((strlen(p) + 1 + strlen(name) + 1) = sizeof
fullname)
+ }
+ if ((strlen(p) + 1 + strlen(name) + 1) = sizeof
fullname) {
This sizeof is now the sizeof of a pointer. The comparison should be
against FILENAME_MAX + 1 instead.
Alternatively, the name could be created using asprintf().
--
Jilles Tjoelker
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: cvsup broken on amd64?
Kostik Belousov kostik...@gmail.com wrote: Did you saw the message with the patch for tzcode I mailed to you ? Mmmh... no didn't reached my mailbox - can you resend it please? ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: svn commit: r225380 - head/sys/net
Andrew Thompson thom...@freebsd.org wrote: Author: thompsa Date: Sun Sep 4 22:06:32 2011 New Revision: 225380 URL: http://svn.freebsd.org/changeset/base/225380 Log: On the first loop for generating a bridge MAC address use the local hostid, this gives a good chance of keeping the same address over reboots. This is intended to help IPV6 and similar which generate their addresses from the mac. PR: kern/160300 Submitted by: mdodd Approved by:re (kib) Modified: head/sys/net/if_bridge.c Are there other places where the system advertises the hostid on the network? I always assumed it to be a somewhat private identifier, so I'm a bit surprised by this commit. BTW, the man page still claims that the MAC address is chosen randomly. Fabian signature.asc Description: PGP signature
Re: 9.0 beta2 the new bsdinstaller
On Sun, Sep 18, 2011 at 4:55 AM, Thomas Mueller mueller6727@bellsouth.net wrote: Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). Another concern is updating to the next beta (BETA3?) without trashing the installed application software (from ports). So far, bsdinstaller hasn't offered any possibility of upgrading an existing installation. I don't think a user wants to rebuild all ports for every new beta or release candidate. This also concerns me. I wanted to ask, if one updates 9.0-BETA 2 through ports, if it was the same as a possible BETA-3? and the big question, if updating, does one have to build all the ports? or when one updates BETA-2, do we really have BETA-3 already? What I would question, is that the choices are offered, but one has to use (+) or (-) keys instead of the up arrow/down arrow to select the packages. When I installed it on an amd64 bit machine, I wanted to select src/ and kernel + base, but I did not know how to change, later I found out that + or - keys would change the selections, I pressed enter and then I could not go back to previous screen. With sysinstall I knew how to go back and forth between the screens, but with bsdinstall it is completely revamped. Tom Regards, Antonio ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
How does one install kernel sources and base
Dear folks, I have installed 9.0 - BETA 2, and I had no x, when I typed startx, some folks have suggested to check if I have xorg-server, I will do that as soon as I get to my machine on Monday. Also I will check if I put into /etc/rc.conf, hald_enable=YES and dbus_enable=YES as well, otherwise startx will not work. But my question is as follows, How do I get kernel sources and base installed? I tried sysinstall and used configure - distributions - kernel + sys + base as outlined in http://www.cyberciti.biz/faq/freebsd-install-kernel-source-code/ Did not work, got mirrors but timed out errors, I went through most mirrors in Japan, Sweden, USA, and it appears not to be found. I tried bsdinstall and reinserted 9.0-BETA2-amd64-dvd1 into drive and it would not mount and would return an error. I have read about using cvs or something like it, but I have not used it and would like some pointers on how to use it, or other form that would work to install kernel sources so I could try nvidia-driver since X was not working and nv driver is too old and might not work as one would like it to. Thanks in Advance for comments/advice/suggestions. Regards, Antonio ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: no X after installing xorg + xfce
On Sat, Sep 17, 2011 at 11:36 PM, Garrett Cooper yaneg...@gmail.com wrote: On Sat, Sep 17, 2011 at 9:28 PM, Thomas Mueller mueller6727@bellsouth.net wrote: I have successfully installed FreeBSD-9.0-BETA2 to an amd64 bit machine, I have used the ports to install xfce and xorg. When I type startx, I get a screen with a bunch of colors no mouse, no keyboard, just colors. The machine has nvidia onboard graphics. I am trying to get kernel sources installed via sysinstall to install nvidia-driver but I can't get anywhere from any ftp site I select at random. I have updated to latest sources available on the ports and it comes up the same. I have to use the nv driver, should I try the nouveau driver? What should I do? I want to help in testing and have no way to report bugs as without X there's not much one can do :( Is it not automatically installed when one goes into /usr/ports/x11/xorg, and runs make install clean? You would get the xorg server with the xorg metaport/megaport. One thing I can think of is a little dirty trick I have seen in FreeBSD but not NetBSD or Linux, X comes up but no response to mouse or keyboard. I ran startx, got twm with its windows, but no response to mouse or keyboard. Cure was, to include in /etc/rc.conf hald_enable=YES dbus_enable=YES This seems like more of a question@ issue. I doubt that the above claim is at fault, given past experience. What does /var/log/Xorg.0.log say, and what does your xorg.conf contain? Thanks, -Garrett I will check on Monday as soon as I get to my machine to see if I have these in /etc/rc.conf and also output what is in /var/log/Xorg.0.log(if I can get to X to save it). Could it be that xorg-server is not installed? I have been fortunate to install xfce + xorg and things just worked(TM) for me. I will get back as soon as I have some results. Thank you all who have dropped some suggestions. Regards, Antonio ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: truss
On Wed, 14 Sep 2011 06:17:45 + (UTC) Anton Yuzhaninov wrote to Xin LI: AY On Fri, 09 Sep 2011 15:56:41 -0700, Xin LI wrote: XL -BEGIN PGP SIGNED MESSAGE- XL Hash: SHA256 XL XL On 08/31/11 07:35, Anton Yuzhaninov wrote: It seems to be truss(1) is broken on current :~ truss /bin/echo x x truss: can not get etype: No such process FreeBSD 9.0-BETA1 #0 r224884M i386 from ktrace of turss 3162 trussCALL __sysctl(0xbfbfea00,0x4,0xbfbfe9e0,0xbfbfea10,0,0) 3162 truss SCTL kern.proc.sv_name.3163 3162 trussRET __sysctl -1 errno 3 No such process XL XL Can't seem to be reproducable here, did I missed anything? (note that XL you may need a full world/kernel build). XL AY Problem still here after svn up and rebuild world/kernel AY :~ ktrace -t+ truss /usr/bin/true AY truss: can not get etype: No such process Could you please run ktrace with -i option? The behavior is like if ptrace(PT_TRACE_ME) failed in the child by some reason. Unfortunately, truss does not check this. AY Full ktrace: AY http://dl.dropbox.com/u/8798217/tmp/truss_ktrace.txt AY FreeBSD 9.0-BETA2 #1 r225504M AY i386 AY Kernel config is not GENERIC - main difference - DTrace added: AY http://dl.dropbox.com/u/8798217/tmp/kernconf.txt AY -- AY Anton Yuzhaninov AY ___ AY freebsd-current@freebsd.org mailing list AY http://lists.freebsd.org/mailman/listinfo/freebsd-current AY To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org -- Mikolaj Golub ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: How does one install kernel sources and base
On Sun, 2011-09-18 at 09:00 -0500, Antonio Olivares wrote: Dear folks, I have installed 9.0 - BETA 2, and I had no x, when I typed startx, some folks have suggested to check if I have xorg-server, I will do that as soon as I get to my machine on Monday. Also I will check if I put into /etc/rc.conf, hald_enable=YES and dbus_enable=YES as well, otherwise startx will not work. xorg works very well (and actually much better) without HAL and as far as I know, doesn't even use dbus. Try checking xorg port's config in: # cd /usr/ports/x11-servers/xorg-server/ # make config You can then rebuild your xorg-server port if necessary. Note that for using xorg server without HAL, you will need to configure it properly (see manuals/howtos on xorg.conf, if you never done it before), what was the main 'issue' HAL was originally trying to solve. It failed miserably, which is the reason why newer xorg generations moved away from it and nowadays is only to be found as a sad reminder on FreeBSD. Generally, you will be better off without HAL as it only leads to more failures than running without it. But my question is as follows, How do I get kernel sources and base installed? You can download them via csup with a config file similar to this: *default host=cvsup5.FreeBSD.org *default base=/var/db *default prefix=/usr *default release=cvs tag=. *default compress delete use-rel-suffix src-all Save your config file (or so called supfile) someplace and run it as: # csup your.supfile csup will download the latest source tree for kernel and base OS. Also, see FreeBSD Handbook for more information on using csup (or the older, but functionally identical cvsup), and for many other questions regarding general FreeBSD installation and maintenance: http://www.freebsd.org/doc/handbook/cvsup.html m. -- Michal Varga, Stonehenge (Gmail account) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Segfault in libthr.so on 9.0-BETA2 (with stunnel FWIW)
On Sun, Sep 18, 2011 at 01:56:50PM +0200, Jilles Tjoelker wrote:
On Wed, Sep 14, 2011 at 11:04:56PM +0300, Kostik Belousov wrote:
tzload() allocates ~80KB for the local variables. The backtrace you provided
shows the nested call to tzload(), so there is total 160KB of the stack
space consumed.
By default, stack for the amd64 thread is 4MB, that should be plenty. This
is not the case for ezm3. Possibly, stunnel also reduces the size of the
thread stack.
Please, try the patch below. I did not tested it, only compiled. I see
that now tzload allocates only ~300 bytes on the stack.
80KB seems quite a lot indeed, good to bring it down.
diff --git a/contrib/tzcode/stdtime/localtime.c
b/contrib/tzcode/stdtime/localtime.c
index 80b70ac..55d55e0 100644
--- a/contrib/tzcode/stdtime/localtime.c
+++ b/contrib/tzcode/stdtime/localtime.c
[snip]
@@ -406,16 +409,24 @@ register const intdoextend;
** to hold the longest file name string that the implementation
** guarantees can be opened.
*/
- charfullname[FILENAME_MAX + 1];
+ char*fullname;
+
+ fullname = malloc(FILENAME_MAX + 1);
+ if (fullname == NULL)
+ goto out;
if (name[0] == ':')
++name;
doaccess = name[0] == '/';
if (!doaccess) {
- if ((p = TZDIR) == NULL)
+ if ((p = TZDIR) == NULL) {
+ free(fullname);
return -1;
- if ((strlen(p) + 1 + strlen(name) + 1) = sizeof
fullname)
+ }
+ if ((strlen(p) + 1 + strlen(name) + 1) = sizeof
fullname) {
This sizeof is now the sizeof of a pointer. The comparison should be
against FILENAME_MAX + 1 instead.
Alternatively, the name could be created using asprintf().
You are right. I fixed the defect.
Updated patch below.
diff --git a/contrib/tzcode/stdtime/localtime.c
b/contrib/tzcode/stdtime/localtime.c
index 80b70ac..b1981b6 100644
--- a/contrib/tzcode/stdtime/localtime.c
+++ b/contrib/tzcode/stdtime/localtime.c
@@ -380,13 +380,16 @@ register const intdoextend;
int fid;
int stored;
int nread;
+ int res;
union {
struct tzhead tzhead;
charbuf[2 * sizeof(struct tzhead) +
2 * sizeof *sp +
4 * TZ_MAX_TIMES];
- } u;
+ } *u;
+ u = NULL;
+ res = -1;
sp-goback = sp-goahead = FALSE;
/* XXX The following is from OpenBSD, and I'm not sure it is correct */
@@ -406,16 +409,24 @@ register const intdoextend;
** to hold the longest file name string that the implementation
** guarantees can be opened.
*/
- charfullname[FILENAME_MAX + 1];
+ char*fullname;
+
+ fullname = malloc(FILENAME_MAX + 1);
+ if (fullname == NULL)
+ goto out;
if (name[0] == ':')
++name;
doaccess = name[0] == '/';
if (!doaccess) {
- if ((p = TZDIR) == NULL)
+ if ((p = TZDIR) == NULL) {
+ free(fullname);
return -1;
- if ((strlen(p) + 1 + strlen(name) + 1) = sizeof
fullname)
+ }
+ if (strlen(p) + 1 + strlen(name) = FILENAME_MAX) {
+ free(fullname);
return -1;
+ }
(void) strcpy(fullname, p);
(void) strcat(fullname, /);
(void) strcat(fullname, name);
@@ -426,37 +437,45 @@ register const intdoextend;
doaccess = TRUE;
name = fullname;
}
- if (doaccess access(name, R_OK) != 0)
+ if (doaccess access(name, R_OK) != 0) {
+ free(fullname);
return -1;
- if ((fid = _open(name, OPEN_MODE)) == -1)
+ }
+ if ((fid = _open(name, OPEN_MODE)) == -1) {
+ free(fullname);
return -1;
+ }
if ((_fstat(fid, stab) 0) || !S_ISREG(stab.st_mode)) {
+ free(fullname);
_close(fid);
return -1;
}
}
- nread = _read(fid, u.buf, sizeof u.buf);
+ u = malloc(sizeof(*u));
+ if (u == NULL)
+ goto out;
+
Re: cvsup broken on amd64?
On Sun, Sep 18, 2011 at 02:46:24PM +0200, Oliver Lehmann wrote: Kostik Belousov kostik...@gmail.com wrote: Did you saw the message with the patch for tzcode I mailed to you ? Mmmh... no didn't reached my mailbox - can you resend it please? See the Segfault in libthr.so on 9.0-BETA2 (with stunnel FWIW) thread on the current@, where you are explicitely Cc:ed. I posted updated patch a minute ago. pgpbmqafpbDxl.pgp Description: PGP signature
Re: 9.0 beta2 the new bsdinstaller
On Sep 18, 2011, at 2:55 AM, Thomas Mueller mueller6727@bellsouth.net wrote: Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). Another concern is updating to the next beta (BETA3?) without trashing the installed application software (from ports). So far, bsdinstaller hasn't offered any possibility of upgrading an existing installation. I don't think a user wants to rebuild all ports for every new beta or release candidate. Upgrading installs is nontrivial, depending on the install options. The fact that sysinstall allowed this was a mistake. -Garrett ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 beta2 the new bsdinstaller
On Sun, 18 Sep 2011, Thomas Mueller mueller6...@bellsouth.net wrote: Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me (Warning: guesswork and supposition ahead. Set your puzzler in low gear for traction.) AFAIK this is space for boot1 and boot2: http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/boot-blocks.html It used to be 16K, but newer boot code like gptzfsboot (33K) needs more room. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Very imprecise watchdogd(8) timeout
Hi, On Sat, Sep 17, 2011 at 2:17 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cacqu3mvf5mwqec+s9vkk4mljenmos9q_bjwkbyefzabfjo6...@mail.gmail.com , Arnaud Lacombe writes: I do not really care actually, but the manpage is wrong, and the code needlessly complicated. As I said: Feel free to improve. How can I expect anything to get through, when I cannot even get an obvious use-after-free in the ipfw code fixed after months ? Or when I've been waiting to play with Warner's external compiler support patch for months ? Or when I can not get a build fix for 7-STABLE to get committed ? [and the list goes on...] ? Thanks, - Arnaud ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Very imprecise watchdogd(8) timeout
In message cacqu3mv7mld1qrsd3c0ck2hjfferhbqtvbqxhhq62r6-pn8...@mail.gmail.com , Arnaud Lacombe writes: I do not really care actually, but the manpage is wrong, and the code needlessly complicated. As I said: Feel free to improve. How can I expect anything to get through, when I cannot even get an obvious use-after-free in the ipfw code fixed after months ? Or when I've been waiting to play with Warner's external compiler support patch for months ? Or when I can not get a build fix for 7-STABLE to get committed ? [and the list goes on...] The oracle says: Try next answer. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 beta2 the new bsdinstaller
On Sun, Sep 18, 2011 at 2:55 AM, Thomas Mueller mueller6727@bellsouth.net wrote: Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). The 64KB freebsd-boot partition is to contain the GPT boot code which is used by UEFI BIOS in place of the old MBR used by legacy BIOS. You need to use gpart(8) to write the GPT boot code to that partition, but I don't know if bsdinstall does so. It might just write the PMBR that is used for booting with legacy BIOS. I'll admit that I have not checked. (See the gpart(8) man page for details on writing the pmbr and gptboot.) I assume bsdinstall writes both so that AMD64 machines with EFI and 32-bit systems will both work. This is very different from the old traditional slice/partition system. -- R. Kevin Oberman, Network Engineer - Retired E-mail: kob6...@gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Very imprecise watchdogd(8) timeout
.. just a note: people who in your situation keep filing PRs, fixing bugs and hounding committers with tested, correct fixes - end up getting commit bits. :-) Adrian ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Very imprecise watchdogd(8) timeout
On 18 Sep 2011 20:31, Arnaud Lacombe lacom...@gmail.com wrote: Hi, On Sat, Sep 17, 2011 at 2:17 AM, Poul-Henning Kamp p...@phk.freebsd.dk wrote: In message cacqu3mvf5mwqec+s9vkk4mljenmos9q_bjwkbyefzabfjo6...@mail.gmail.com , Arnaud Lacombe writes: I do not really care actually, but the manpage is wrong, and the code needlessly complicated. As I said: Feel free to improve. How can I expect anything to get through, when I cannot even get an obvious use-after-free in the ipfw code fixed after months ? Or when I've been waiting to play with Warner's external compiler support patch for months ? Or when I can not get a build fix for 7-STABLE to get committed ? [and the list goes on...] ? Hey Arnaud, I'm sorry to hear you're having trouble getting your fixes included. If you provide some PR numbers I'll gladly try to get them in as quickly as possible. Chris ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 beta2 the new bsdinstaller
Kevin Oberman wrote: On Sun, Sep 18, 2011 at 2:55 AM, Thomas Mueller mueller6727@bellsouth.net wrote: Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). The 64KB freebsd-boot partition is to contain the GPT boot code which is used by UEFI BIOS in place of the old MBR used by legacy BIOS. You need to use gpart(8) to write the GPT boot code to that partition, but I don't know if bsdinstall does so. It might just write the PMBR that is used for booting with legacy BIOS. I'll admit that I have not checked. (See the gpart(8) man page for details on writing the pmbr and gptboot.) I assume bsdinstall writes both so that AMD64 machines with EFI and 32-bit systems will both work. This is very different from the old traditional slice/partition system. The above info is another example of the type of information that should be added to a help option on the dialog screen for the bsdinstall disk configuration function. I also think that the bsdinstaller should offer the user an option to select between using the old MBR configuration used by legacy BIOS that sysinstall uses and the new gpart configuration which bsdinstall offers now. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
bsdgrep-20110912: -F/fgrep enbug
Hi, I found another issue, this time in bsdgrep-20110912 in port. == #! /bin/sh echo 1 echo 90123456789.|grep -F 0123456789. echo 2 echo 90123456789.|grep0123456789. echo 3 echo 0123456789.|grep -F 0123456789. echo 4 echo 90123456789.|grep -F 0123456789 echo 5 echo 90123456789x|grep -F 0123456789x == result: 1 2 90123456789. 3 0123456789. 4 90123456789. 5 90123456789x == (1) this should match but does not. (2) without -F it matches. (3) trim leading 1 byte from input string it matches. (4) trim last period from query string it matches. (5) replace period with another character (no matter what it is) it matches. bsdgrep in -CURRENT and GNU grep match all cases. -- kuro ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: 9.0 beta2 the new bsdinstaller
On Sun, Sep 18, 2011 at 5:52 PM, Fbsd8 fb...@a1poweruser.com wrote: Kevin Oberman wrote: On Sun, Sep 18, 2011 at 2:55 AM, Thomas Mueller mueller6727@bellsouth.net wrote: Some more ideas on the new bsdinstaller cross my mind. Since the way the bsdinstaller would make partitions is unpredictable, at least to the uninitiated, and in all likelihood at variance with how much space the user wants to allocate, it might be better to offer a roadmap to help guide the user to allocating space for FreeBSD using gpart or Rod Smith's gdisk. Also, I can't see the function of the 64 KB boot partition with no file system, which does not boot for me, though I can boot the main partition using grub2 from the System Rescue CD (http://sysresccd.org/). The 64KB freebsd-boot partition is to contain the GPT boot code which is used by UEFI BIOS in place of the old MBR used by legacy BIOS. You need to use gpart(8) to write the GPT boot code to that partition, but I don't know if bsdinstall does so. It might just write the PMBR that is used for booting with legacy BIOS. I'll admit that I have not checked. (See the gpart(8) man page for details on writing the pmbr and gptboot.) I assume bsdinstall writes both so that AMD64 machines with EFI and 32-bit systems will both work. This is very different from the old traditional slice/partition system. The above info is another example of the type of information that should be added to a help option on the dialog screen for the bsdinstall disk configuration function. I also think that the bsdinstaller should offer the user an option to select between using the old MBR configuration used by legacy BIOS that sysinstall uses and the new gpart configuration which bsdinstall offers now. I can only see two advantages of the old MBR scheme over GPT. 1. Booteasy is not available, so you need to use gpart to designate booting from a different partition 2. Some other OSes don't support it. 32-bit Windows, Solaris, 64-bit Windows on systems lacking EFI While GPT has major advantages over the old MBR system, I think these two justify maintaining the ability to install FreeBSD with MBR. I also should be clear in that sysinstall does work fine on a disk that is already configured with MBR partitioning. I am sure of this because I have done it and had no problems with that part of the install. It's only if you want to partition a new disk with the intent of later installing an OS that does not support GPT. -- R. Kevin Oberman, Network Engineer - Retired E-mail: kob6...@gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
RE: cvsup broken on amd64?
Hi!
So I've taken a look at the csup source.
The problem here is the updater thread setting the closed state
(fixups_closed()) before calling updater_batch() again to handle
fixups.
Checking for size != 0 at that point may not be valid at the list size
may actually be 0 for a short period of time.
What about this patch:
Index: updater.c
===
--- updater.c (revision 224905)
+++ updater.c (working copy)
@@ -240,9 +240,9 @@
* Make sure to close the fixups even in case of an error,
* so that the lister thread doesn't block indefinitely.
*/
- fixups_close(up-config-fixups);
if (!error)
error = updater_batch(up, 1);
+ fixups_close(up-config-fixups);
switch (error) {
case UPDATER_ERR_PROTO:
xasprintf(args-errmsg, Updater failed:
Protocol error);
I've tried this patch. Now csup hangs before handling fixups.
So there is no message Applying fixups... at all.
--
Alexander Zagrebin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
