Re: pseudofs broken(?) with r351741
On 9/4/19 1:55 PM, Mateusz Guzik wrote: > have you tried with https://svnweb.freebsd.org/changeset/base/351815 ? That fixes it. Thanks! > > On 9/4/19, Johannes Lundberg wrote: >> Hey >> >> I noticed that linuxkpi's debugfs which is based on pfs stopped show any >> content in mounted folders. >> >> r351740 works as expected, r351741 does not. Just as if there are no files. >> >> Does this change require any patches to users of pfs to work or is pfs >> broken? >> >> >> commit 378285257117261aba3d181fff97da9d56d5f566 (HEAD) >> >> Author: mjg >> Date: Tue Sep 3 05:54:51 2019 >> >> pseudofs: fix a LOR pfs_node vs pidhash (sleepable after non-sleepable) >> >> Sponsored by: The FreeBSD Foundation >> >> Notes: >> svn path=/head/; revision=351741 >> >> >> >> > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: pseudofs broken(?) with r351741
have you tried with https://svnweb.freebsd.org/changeset/base/351815 ? On 9/4/19, Johannes Lundberg wrote: > Hey > > I noticed that linuxkpi's debugfs which is based on pfs stopped show any > content in mounted folders. > > r351740 works as expected, r351741 does not. Just as if there are no files. > > Does this change require any patches to users of pfs to work or is pfs > broken? > > > commit 378285257117261aba3d181fff97da9d56d5f566 (HEAD) > > Author: mjg > Date: Tue Sep 3 05:54:51 2019 > > pseudofs: fix a LOR pfs_node vs pidhash (sleepable after non-sleepable) > > Sponsored by: The FreeBSD Foundation > > Notes: > svn path=/head/; revision=351741 > > > > -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
pseudofs broken(?) with r351741
Hey I noticed that linuxkpi's debugfs which is based on pfs stopped show any content in mounted folders. r351740 works as expected, r351741 does not. Just as if there are no files. Does this change require any patches to users of pfs to work or is pfs broken? commit 378285257117261aba3d181fff97da9d56d5f566 (HEAD) Author: mjg Date: Tue Sep 3 05:54:51 2019 pseudofs: fix a LOR pfs_node vs pidhash (sleepable after non-sleepable) Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=351741 ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Weird goings on with make::empty()
> On Sep 4, 2019, at 07:58, Ian Lepore wrote:
>
>> On Wed, 2019-09-04 at 09:33 -0500, Kyle Evans wrote:
>> On Wed, Sep 4, 2019 at 9:27 AM Enji Cooper
>> wrote:
>>>
>>>
On Sep 4, 2019, at 04:59, Poul-Henning Kamp
wrote:
On:
Repository Root: svn+ssh://repo.freebsd.org/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 351809
I built a kernel, but drm-current-kmod did not get compiled
from the new world order in /usr/local/sys/modules
Debugging I ended up doing this to src/sys/conf/kern.post.mk:
Index: sys/conf/kern.post.mk
==
=
--- sys/conf/kern.post.mk(revision 351809)
+++ sys/conf/kern.post.mk(working copy)
@@ -77,12 +77,14 @@
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
.endif
.for module in ${LOCAL_MODULES}
-.if !empty(module)
+true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
${MODULES_WITH_WORLD}"
+#.if !empty(module)
+true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
${MODULES_WITH_WORLD}"
@${ECHODIR} "===> ${module}
(${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV}
${MAKE} \
DIRPRFX="${module}/" \
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
-.endif
+#.endif
.endfor
.endif
.endfor
This gives me the expected output from buildkernel:
true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
"
true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
"
If I leave in the ".if !empty(module)" line in, I only get:
true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
"
suggestions welcome...
>>>
>>> (CCing Kyle)
>>>
>>> This behavior change is probably caused by r351799.
>>>
>>> I personally think the code before Kyle’s change and after it was
>>> buggy. It’s not word splitting LOCAL_MODULES before iterating over
>>> it.
>>>
>>
>> I've backed out r351799 since it breaks usage of LOCAL_MODULES
>> (though
>> I really don't understand how empty works, apparently, and that makes
>> me sad)... please advise on a correct path forward, because it's not
>> clear to me.
>>
>> Thanks,
>>
>> Kyle Evans
>>
>
> I'm not positive, but I suspect this has to do with when variables are
> expanded. In particular, the loop variable for a .for is expanded on
> each loop iteration, but doesn't yet exist during parsing. I suspect
> that the .if is evaluated earlier, during parsing. For example, this
> makefile:
>
> all:
> .for x in a "" b
> .if empty(x)
> @echo empty
> .endif
> @echo ${x}
> .endfor
> @echo done
>
> gives this output:
>
> revolution > make -f /tmp/Makefile
> empty
> a
> empty
>
> empty
> b
> done
>
> The way I interpret that is that empty(x) is true during parsing, so
> the for loop is generated to contain "@echo empty" and "@echo ${x}",
> then the for loop actually runs and prints both "empty" and the value
> of ${x} on each iteration.
Correct. Word splitting is the key. I’ll take a stab at this later on today.
Thanks,
-Enji
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Weird goings on with make::empty()
On Wed, 2019-09-04 at 09:33 -0500, Kyle Evans wrote:
> On Wed, Sep 4, 2019 at 9:27 AM Enji Cooper
> wrote:
> >
> >
> > > On Sep 4, 2019, at 04:59, Poul-Henning Kamp
> > > wrote:
> > >
> > > On:
> > >
> > >Repository Root: svn+ssh://repo.freebsd.org/base
> > >Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
> > >Revision: 351809
> > >
> > > I built a kernel, but drm-current-kmod did not get compiled
> > > from the new world order in /usr/local/sys/modules
> > >
> > > Debugging I ended up doing this to src/sys/conf/kern.post.mk:
> > >
> > >Index: sys/conf/kern.post.mk
> > >==
> > > =
> > >--- sys/conf/kern.post.mk(revision 351809)
> > >+++ sys/conf/kern.post.mk(working copy)
> > >@@ -77,12 +77,14 @@
> > >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > > .endif
> > > .for module in ${LOCAL_MODULES}
> > >-.if !empty(module)
> > >+true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > > ${MODULES_WITH_WORLD}"
> > >+#.if !empty(module)
> > >+true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > > ${MODULES_WITH_WORLD}"
> > >@${ECHODIR} "===> ${module}
> > > (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
> > >@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV}
> > > ${MAKE} \
> > >DIRPRFX="${module}/" \
> > >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > >-.endif
> > >+#.endif
> > > .endfor
> > > .endif
> > > .endfor
> > >
> > > This gives me the expected output from buildkernel:
> > >
> > >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
> > > "
> > >true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
> > > "
> > >
> > > If I leave in the ".if !empty(module)" line in, I only get:
> > >
> > >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4
> > > "
> > >
> > > suggestions welcome...
> >
> > (CCing Kyle)
> >
> > This behavior change is probably caused by r351799.
> >
> > I personally think the code before Kyle’s change and after it was
> > buggy. It’s not word splitting LOCAL_MODULES before iterating over
> > it.
> >
>
> I've backed out r351799 since it breaks usage of LOCAL_MODULES
> (though
> I really don't understand how empty works, apparently, and that makes
> me sad)... please advise on a correct path forward, because it's not
> clear to me.
>
> Thanks,
>
> Kyle Evans
>
I'm not positive, but I suspect this has to do with when variables are
expanded. In particular, the loop variable for a .for is expanded on
each loop iteration, but doesn't yet exist during parsing. I suspect
that the .if is evaluated earlier, during parsing. For example, this
makefile:
all:
.for x in a "" b
.if empty(x)
@echo empty
.endif
@echo ${x}
.endfor
@echo done
gives this output:
revolution > make -f /tmp/Makefile
empty
a
empty
empty
b
done
The way I interpret that is that empty(x) is true during parsing, so
the for loop is generated to contain "@echo empty" and "@echo ${x}",
then the for loop actually runs and prints both "empty" and the value
of ${x} on each iteration.
-- Ian
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Weird goings on with make::empty()
On Wed, 4 Sep 2019 09:33:08 -0500
Kyle Evans wrote:
> On Wed, Sep 4, 2019 at 9:27 AM Enji Cooper wrote:
> >
> >
> > > On Sep 4, 2019, at 04:59, Poul-Henning Kamp wrote:
> > >
> > > On:
> > >
> > >Repository Root: svn+ssh://repo.freebsd.org/base
> > >Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
> > >Revision: 351809
> > >
> > > I built a kernel, but drm-current-kmod did not get compiled
> > > from the new world order in /usr/local/sys/modules
> > >
> > > Debugging I ended up doing this to src/sys/conf/kern.post.mk:
> > >
> > >Index: sys/conf/kern.post.mk
> > >===
> > >--- sys/conf/kern.post.mk(revision 351809)
> > >+++ sys/conf/kern.post.mk(working copy)
> > >@@ -77,12 +77,14 @@
> > >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > > .endif
> > > .for module in ${LOCAL_MODULES}
> > >-.if !empty(module)
> > >+true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > > ${MODULES_WITH_WORLD}"
> > >+#.if !empty(module)
> > >+true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > > ${MODULES_WITH_WORLD}"
> > >@${ECHODIR} "===> ${module}
> > > (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
> > >@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
> > >DIRPRFX="${module}/" \
> > >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > >-.endif
> > >+#.endif
> > > .endfor
> > > .endif
> > > .endfor
> > >
> > > This gives me the expected output from buildkernel:
> > >
> > >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > >true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > >
> > > If I leave in the ".if !empty(module)" line in, I only get:
> > >
> > >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > >
> > > suggestions welcome...
> >
> > (CCing Kyle)
> >
> > This behavior change is probably caused by r351799.
> >
> > I personally think the code before Kyle___s change and after it was buggy.
> > It___s not word splitting LOCAL_MODULES before iterating over it.
> >
>
> I've backed out r351799 since it breaks usage of LOCAL_MODULES (though
> I really don't understand how empty works, apparently, and that makes
> me sad)... please advise on a correct path forward, because it's not
> clear to me.
>
In Kyle's defence my testing of his patch was only with
LOCAL_MODULES= and LOCAL_MODULES="" in /etc/src.conf. I don't
have any ports modules to be compiled with the kernel.
--
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Weird goings on with make::empty()
On Wed, Sep 4, 2019 at 9:27 AM Enji Cooper wrote:
>
>
> > On Sep 4, 2019, at 04:59, Poul-Henning Kamp wrote:
> >
> > On:
> >
> >Repository Root: svn+ssh://repo.freebsd.org/base
> >Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
> >Revision: 351809
> >
> > I built a kernel, but drm-current-kmod did not get compiled
> > from the new world order in /usr/local/sys/modules
> >
> > Debugging I ended up doing this to src/sys/conf/kern.post.mk:
> >
> >Index: sys/conf/kern.post.mk
> >===
> >--- sys/conf/kern.post.mk(revision 351809)
> >+++ sys/conf/kern.post.mk(working copy)
> >@@ -77,12 +77,14 @@
> >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > .endif
> > .for module in ${LOCAL_MODULES}
> >-.if !empty(module)
> >+true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > ${MODULES_WITH_WORLD}"
> >+#.if !empty(module)
> >+true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> > ${MODULES_WITH_WORLD}"
> >@${ECHODIR} "===> ${module}
> > (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
> >@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
> >DIRPRFX="${module}/" \
> >${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> >-.endif
> >+#.endif
> > .endfor
> > .endif
> > .endfor
> >
> > This gives me the expected output from buildkernel:
> >
> >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> >true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> >
> > If I leave in the ".if !empty(module)" line in, I only get:
> >
> >true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> >
> > suggestions welcome...
>
> (CCing Kyle)
>
> This behavior change is probably caused by r351799.
>
> I personally think the code before Kyle’s change and after it was buggy. It’s
> not word splitting LOCAL_MODULES before iterating over it.
>
I've backed out r351799 since it breaks usage of LOCAL_MODULES (though
I really don't understand how empty works, apparently, and that makes
me sad)... please advise on a correct path forward, because it's not
clear to me.
Thanks,
Kyle Evans
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Weird goings on with make::empty()
> On Sep 4, 2019, at 04:59, Poul-Henning Kamp wrote:
>
> On:
>
>Repository Root: svn+ssh://repo.freebsd.org/base
>Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
>Revision: 351809
>
> I built a kernel, but drm-current-kmod did not get compiled
> from the new world order in /usr/local/sys/modules
>
> Debugging I ended up doing this to src/sys/conf/kern.post.mk:
>
>Index: sys/conf/kern.post.mk
>===
>--- sys/conf/kern.post.mk(revision 351809)
>+++ sys/conf/kern.post.mk(working copy)
>@@ -77,12 +77,14 @@
>${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> .endif
> .for module in ${LOCAL_MODULES}
>-.if !empty(module)
>+true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> ${MODULES_WITH_WORLD}"
>+#.if !empty(module)
>+true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
> ${MODULES_WITH_WORLD}"
>@${ECHODIR} "===> ${module}
> (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
>@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
>DIRPRFX="${module}/" \
>${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
>-.endif
>+#.endif
> .endfor
> .endif
> .endfor
>
> This gives me the expected output from buildkernel:
>
>true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
>true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
>
> If I leave in the ".if !empty(module)" line in, I only get:
>
>true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
>
> suggestions welcome...
(CCing Kyle)
This behavior change is probably caused by r351799.
I personally think the code before Kyle’s change and after it was buggy. It’s
not word splitting LOCAL_MODULES before iterating over it.
Cheers,
-Enji
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Weird goings on with make::empty()
On:
Repository Root: svn+ssh://repo.freebsd.org/base
Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
Revision: 351809
I built a kernel, but drm-current-kmod did not get compiled
from the new world order in /usr/local/sys/modules
Debugging I ended up doing this to src/sys/conf/kern.post.mk:
Index: sys/conf/kern.post.mk
===
--- sys/conf/kern.post.mk (revision 351809)
+++ sys/conf/kern.post.mk (working copy)
@@ -77,12 +77,14 @@
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
.endif
.for module in ${LOCAL_MODULES}
-.if !empty(module)
+ true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
${MODULES_WITH_WORLD}"
+#.if !empty(module)
+ true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4
${MODULES_WITH_WORLD}"
@${ECHODIR} "===> ${module}
(${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
@cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
DIRPRFX="${module}/" \
${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
-.endif
+#.endif
.endfor
.endif
.endfor
This gives me the expected output from buildkernel:
true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
If I leave in the ".if !empty(module)" line in, I only get:
true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
suggestions welcome...
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
p...@freebsd.org | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Is the LSI/AVAGO/Broadcom 9280-16i4e supported?
Just a huge thank you to you, and everyone else for all the information. Greatly appreciated! On 2019-09-03 11:29, Jung-uk Kim wrote: On 19. 9. 1., Chris wrote: Hello all, I recently picked up an LSI/AVAGO/Broadcom 9280-16i4e card with the intent of flashing it to IT mode (pass through). So as to use it in one of my (FreeBSD) servers. However; looking through the Hardware (support) section of the release notes for 12; the closest I found was the 9260. Does anyone have any experience with the 9280-16i4e on FreeBSD? Does it work? Well? If not, anytime soon? I have one of these. % uname -rs FreeBSD 13.0-CURRENT % mfiutil show adapter mfi0 Adapter: Product Name: LSI MegaRAID SAS 9280-16i4e Serial Number: XX Firmware: 12.15.0-0239 RAID Levels: JBOD, RAID0, RAID1, RAID5, RAID6, RAID10, RAID50 Battery Backup: present NVRAM: 32K Onboard Memory: 512M Minimum Stripe: 8K Maximum Stripe: 1M % mfiutil show volumes mfi0 Volumes: Id SizeLevel Stripe State Cache Name mfid0 ( 36T) RAID-6 64K OPTIMAL Disabled FYI, it's been working fine for 7 years. Jung-uk Kim ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
