Re: CFT: major update to if_ure (patch did not apply cleanly for head -r363510)

2020-07-26 Thread John-Mark Gurney
Mark Millard wrote this message on Sat, Jul 25, 2020 at 19:13 -0700:
> For reference for what applying the patch
> reported (see Hunk #14):

Ok, updated it to be relative to r363583...

I had made a white spcae commit to if_ure.c, but hadn't made the
patch relative to it after that commit.. should work now..

-- 
  John-Mark Gurney  Voice: +1 415 225 5579

 "All that I will do, has been done, All that I have, has not."
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


is updated if_bridge included in current 13.0 or stable 12

2020-07-26 Thread Ernie Luzar

Know if_bridge is being worked on to make its performance faster.

Has this new if_bridge been merged into 13.0 current head or stable 12.2?

If so I would like to give it a test ride by installing last weeks 
snapshot.

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: CFT: major update to if_ure

2020-07-26 Thread John-Mark Gurney
Ganbold Tsagaankhuu wrote this message on Sun, Jul 26, 2020 at 11:05 +0800:
> On Sun, Jul 26, 2020 at 7:13 AM John-Mark Gurney  wrote:
> 
> > Hello,
> >
> > I'd like people who have ure (RealTek) based USB devices to test
> > review D25809[0].
> >
> > This update adds support for:
> > - HW VLAN tagging
> > - HW checksum offload for IPv4 and IPv6
> > - tx and rx aggreegation (for full gige speeds)
> > - multiple transactions
> >
> > In my testing, I am able to get 900-950Mbps depending upon
> > TCP or UDP, which is a significant improvement over the previous
> > 91Mbps (~8kint/sec*1500bytes/packet*1packet/int).
> 
> Does performance improve for if_ure device on USB2?
> I will try to test it in a couple of days on NanoPI R1 and R1S boards.

Yes, it should.

I never tested the before driver on USB2, but I'm now able to get
211Mbps TX and 190Mbps RX TCP, and 227Mbps TX and 225Mbps RX UDP.

I believe it is likely that the same 91Mbps speed limit applied to
USB2 as well.

> > [0] https://reviews.freebsd.org/D25809

-- 
  John-Mark Gurney  Voice: +1 415 225 5579

 "All that I will do, has been done, All that I have, has not."
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: CFT: major update to if_ure (patch did not apply cleanly for head -r363510)

2020-07-26 Thread Mark Millard


For reference for what applying the patch
reported (see Hunk #14):

# patch < D25809.diff 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--
|Index: sys/dev/usb/net/if_ure.c
|===
|--- sys/dev/usb/net/if_ure.c
|+++ sys/dev/usb/net/if_ure.c
--
Patching file sys/dev/usb/net/if_ure.c using Plan A...
Hunk #1 succeeded at 43.
Hunk #2 succeeded at 64.
Hunk #3 succeeded at 75.
Hunk #4 succeeded at 149.
Hunk #5 succeeded at 503.
Hunk #6 succeeded at 561.
Hunk #7 succeeded at 607.
Hunk #8 succeeded at 658.
Hunk #9 succeeded at 764.
Hunk #10 succeeded at 880.
Hunk #11 succeeded at 935.
Hunk #12 succeeded at 977.
Hunk #13 succeeded at 1007.
Hunk #14 failed at 1033.
Hunk #15 succeeded at 1057.
Hunk #16 succeeded at 1071.
Hunk #17 succeeded at 1153.
Hunk #18 succeeded at 1250.
Hunk #19 succeeded at 1282.
Hunk #20 succeeded at 1340 with fuzz 2.
Hunk #21 succeeded at 1492.
Hunk #22 succeeded at 1519.
Hunk #23 succeeded at 1652.
1 out of 23 hunks failed--saving rejects to sys/dev/usb/net/if_ure.c.rej
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: sys/dev/usb/net/if_urereg.h
|===
|--- sys/dev/usb/net/if_urereg.h
|+++ sys/dev/usb/net/if_urereg.h
--
Patching file sys/dev/usb/net/if_urereg.h using Plan A...
Hunk #1 succeeded at 391.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--
|Index: sys/modules/usb/ure/Makefile
|===
|--- sys/modules/usb/ure/Makefile
|+++ sys/modules/usb/ure/Makefile
--
Patching file sys/modules/usb/ure/Makefile using Plan A...
Hunk #1 succeeded at 5.
done

As for the .rej file content:

# more sys/dev/usb/net/if_ure.c.rej
@@ -752,6 +1033,18 @@
ure_read_2(sc, URE_PLA_FMC, URE_MCU_TYPE_PLA) |
URE_FMC_FCR_MCU_EN);
 
+   /* Enable RX VLANs if enabled */
+   cpcr = ure_read_2(sc, URE_PLA_CPCR, URE_MCU_TYPE_PLA);
+   if (if_getcapenable(ifp) & IFCAP_VLAN_HWTAGGING) {
+   DEVPRINTFN(13, sc->sc_ue.ue_dev, "enabled hw vlan tag\n");
+   cpcr |= URE_CPCR_RX_VLAN;
+   } else {
+   DEVPRINTFN(13, sc->sc_ue.ue_dev, "disabled hw vlan tag\n");
+   cpcr &= ~URE_CPCR_RX_VLAN;
+   }
+   ure_write_2(sc, URE_PLA_CPCR, URE_MCU_TYPE_PLA,
+   cpcr);
+
/* Enable transmit and receive. */
ure_write_1(sc, URE_PLA_CR, URE_MCU_TYPE_PLA,
ure_read_1(sc, URE_PLA_CR, URE_MCU_TYPE_PLA) | URE_CR_RE |



===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"