Quoting Warner Losh <i...@bsdimp.com> (from Fri, 11 Mar 2022 08:57:33 -0700):
On Fri, Mar 11, 2022 at 2:52 AM Alexander Leidinger <alexan...@leidinger.net> wrote:Hi, I'm looking for a function to convert bintime to a human readable format in the kernel... and what is the usual format we use?Yes. We don't generally log it.
Would it be acceptable in this particular case (or should I keep this change for me)?
I have to check out the kern.msgbuf_show_timestamp part in this thread, which looks interesting. It may fit my needs here.
The use case for this is: if something throws a log from the kernel about a signal, I want to know when it happened, or in terms of code see below (tabs are most probably messed up). Do we have some kind of policy in terms of kernel messages and timestamps? Like "do not commit logging with timestamps"?Correct. The kernel doesn't know enough to properly render timestamps, nor should it. It's a lot more complicated than you'd expect, and the simple, naive implementation has too many flaws...
I'm aware that it is complicated. IMO too complicated for a full implementation which will satisfy all needs.
I have the code below because I needed it at least once and think something like this (in a human readably shape) would be beneficial to have in the tree.I really don't want to see code like that in the tree. Having it per-message in an ad-hoc manner strikes me as quite unwise, since how do you interpret it after the fact, especially in the face of adjustments to boottime for any time adjustments that happen after the event.
Sorry, I was not verbose enough in my mail it seems. I do _not_ want to commit this code like it is. I was looking for stuff which could print something human readable, like "2022-12-03 14:23:22.45 'kernel-time'" (just as an example). I don't want to push the TZ into the kernel, or the knowledge if the cmos clock is set to localtime or UTC. I want to provide an admin with a way to determine when such a message may have printed. Currently there is no way to know at which time it was printed. The admin needs to know if the clock is set in UTC or localtime, and how to calculate the wall-clock time from this, which is less heavy on the implementation and provides a mean to correlate the mesage with some action on the machine.
Now, having said that, having good timestamps in the dmesg buffer is a desirable feature. 'Good' is subjective here, and there are times early in boot where it's simply not possible to get a time better than '0' until the timehands are ticking... But the dmesg buffer has more than what dmesg prints: it has syslog'd things (at least some of them) as well. There's also a priority that some lines have. <3>Foo, for example. It would be better, imho, to add a timestamp to the start of the lines (perhaps optionally since that might be expensive in $HUGE systems, or at times of extreme dmesg spew and the could be omitted in those cases). If you are interested in just the log messages, it wouldn't be terrible since we already add stuff to what's printed for the priority. We could say <3,seconds-since-boot.fracsec> instead of just <3> and hack dmesg to print the right thing.
From the other message in the thread it looks like kern.msgbuf_show_timestamp is what you describe here? And it looks like kern.msgbuf_show_timestamp is not the same as printing a timestamp to the console... (it looks like the timestamp is printed in the dmesg, but not to the console, which is what I have in mind for this particular message... respectively could be added log() with a sysctl to activate it or not).
Bye, Alexander.
WarnerCode: ---snip--- diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index 4a15bd45355..a83eebe0736 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -80,6 +80,7 @@ __FBSDID("$FreeBSD$"); #include <sys/sysent.h> #include <sys/syslog.h> #include <sys/sysproto.h> +#include <sys/time.h> #include <sys/timers.h> #include <sys/unistd.h> #include <sys/wait.h> @@ -3440,14 +3441,18 @@ sigexit(struct thread *td, int sig) */ if (coredump(td) == 0) sig |= WCOREFLAG; - if (kern_logsigexit) + if (kern_logsigexit) { + struct bintime now; + + getbintime(&now); log(LOG_INFO, - "pid %d (%s), jid %d, uid %d: exited on " - "signal %d%s\n", p->p_pid, p->p_comm, + "%zd: pid %d (%s), jid %d, uid %d: exited on " + "signal %d%s\n", now.sec, p->p_pid, p->p_comm, p->p_ucred->cr_prison->pr_id, td->td_ucred->cr_uid, sig &~ WCOREFLAG, sig & WCOREFLAG ? " (core dumped)" : ""); + } } else PROC_UNLOCK(p); exit1(td, 0, sig); ---snip--- Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netch...@freebsd.org : PGP 0x8F31830F9F2772BF
-- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netch...@freebsd.org : PGP 0x8F31830F9F2772BF
pgpqxkcaXncOV.pgp
Description: Digitale PGP-Signatur
