Re: RFC: NFS over TLS stats

2023-10-25 Thread Simon J. Gerraty
Rick Macklem wrote: > > kern.rpctls.tls.snd_msgbytes: 20828 > > kern.rpctls.tls.snd_msgcnt: 57 > > kern.rpctls.tls.rcv_tmsgbytes: 12336 > > kern.rpctls.tls.rcv_msgcnt: 57 > > > > which allows for sysctl kern.rpctls.tls > Not sure what you mean? If for some reason I only care about tls I can do

Re: RFC: NFS over TLS stats

2023-10-25 Thread Rick Macklem
On Wed, Oct 25, 2023 at 6:33 PM Simon J. Gerraty wrote: > > Freddie Cash wrote: > > Have no technical comments, but a style suggestion: put the tls at the end > > to make the output look nicer. :) > > > > kern.rpctls.snd_msgbytes: 21508 > > kern.rpctls.snd_msgbytes_tls: 20828 > >

Re: RFC: NFS over TLS stats

2023-10-25 Thread Rick Macklem
Thanks for all the suggestions. I've modified the patch for all of them. (tx/rx instead of snd/rcv, _tls at the end of the names so the order is more readable.) There aren't really errors visible at the RPC/TLS boundary, but I have added counts of successful/failed handshakes and a count of

Re: RFC: NFS over TLS stats

2023-10-25 Thread Simon J. Gerraty
Freddie Cash wrote: > Have no technical comments, but a style suggestion: put the tls at the end > to make the output look nicer. :) > > kern.rpctls.snd_msgbytes: 21508 > kern.rpctls.snd_msgbytes_tls: 20828 > kern.rpctls.snd_msgcnt: 58 > kern.rpctls.snd_msgcnt_tls: 57 >

Re: RFC: NFS over TLS stats

2023-10-25 Thread Freddie Cash
On Tue, Oct 24, 2023 at 10:56 PM Rick Macklem wrote: > Garrett Wollman asked me via email how a server > admin could tell what usage NFS over TLS was > happening. > > I admitted that there was nothing. I have come up > with a patch that generates the following: > kern.rpctls.snd_tls_msgbytes:

Re: RFC: NFS over TLS stats

2023-10-25 Thread Alastair Hogge
On 2023-10-25 10:50, Rick Macklem wrote: > Garrett Wollman asked me via email how a server > admin could tell what usage NFS over TLS was > happening. > > I admitted that there was nothing. I have come up > with a patch that generates the following: > kern.rpctls.snd_tls_msgbytes: 21508 >

Re: d_map_single - how should it work?

2023-10-25 Thread Konstantin Belousov
On Wed, Oct 25, 2023 at 07:58:41AM +, Marcin Cieslak wrote: > Hello, > > is there any documentation for cdevsw methods? > I am interested in knowing how d_map_single should > be written. > > Most specifically, I want to know if the driver > has a chance to track mmaped allocations on its own

Re: RFC: NFS over TLS stats

2023-10-25 Thread Ronald Klop
Maybe tracking of errors can be useful. Great work on this! Regards, Ronald. Van: Rick Macklem Datum: woensdag, 25 oktober 2023 04:50 Aan: FreeBSD CURRENT , Garrett Wollman Onderwerp: RFC: NFS over TLS stats Garrett Wollman asked me via email how a server admin could tell what usage NFS