Re: [Xen-devel] [PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2014-02-17 Thread Roger Pau Monné 
On 14/02/14 18:51, John Baldwin wrote:
 On Thursday, February 13, 2014 8:49:24 pm Andrew Cooper wrote:
 On 08/02/2014 21:42, John Baldwin wrote:
 On Tuesday, December 24, 2013 12:20:58 PM Roger Pau Monne wrote:
 Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can
 force the usage of the Xen mptable enumerator even when ACPI is
 detected.
 Hmm, so I think one question is why does the existing MADT parser
 not work with the MADT table provided by Xen?  This may very well
 be correct, but if it's only a small change to make the existing
 MADT parser work with Xen's MADT table, that route might be
 preferable.


 For dom0, the MADT seen is the system MADT, which does not bear any
 reality to dom0's topology.  For PV domU, no MADT will be found.  For
 HVM domU, the MADT seen ought to represent (virtual) reality.
 
 Hmm, the other changes suggested that you do want to use the I/O APIC
 entries and interrupt overrides from the system MADT for dom0?  Just
 not the CPU entries.  Is that correct?

Yes, we need the interrupt entries in order to interact with the
underlying hardware, but not the CPU entries/topology.

Roger.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: [Xen-devel] [PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2014-02-14 Thread John Baldwin 
On Thursday, February 13, 2014 8:49:24 pm Andrew Cooper wrote:
 On 08/02/2014 21:42, John Baldwin wrote:
  On Tuesday, December 24, 2013 12:20:58 PM Roger Pau Monne wrote:
  Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can
  force the usage of the Xen mptable enumerator even when ACPI is
  detected.
  Hmm, so I think one question is why does the existing MADT parser
  not work with the MADT table provided by Xen?  This may very well
  be correct, but if it's only a small change to make the existing
  MADT parser work with Xen's MADT table, that route might be
  preferable.
 
 
 For dom0, the MADT seen is the system MADT, which does not bear any
 reality to dom0's topology.  For PV domU, no MADT will be found.  For
 HVM domU, the MADT seen ought to represent (virtual) reality.

Hmm, the other changes suggested that you do want to use the I/O APIC
entries and interrupt overrides from the system MADT for dom0?  Just
not the CPU entries.  Is that correct?

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: [PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2014-02-13 Thread John Baldwin 
On Tuesday, December 24, 2013 12:20:58 PM Roger Pau Monne wrote:
 Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can
 force the usage of the Xen mptable enumerator even when ACPI is
 detected.

Hmm, so I think one question is why does the existing MADT parser
not work with the MADT table provided by Xen?  This may very well
be correct, but if it's only a small change to make the existing
MADT parser work with Xen's MADT table, that route might be
preferable.

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: [Xen-devel] [PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2014-02-13 Thread Andrew Cooper 
On 08/02/2014 21:42, John Baldwin wrote:
 On Tuesday, December 24, 2013 12:20:58 PM Roger Pau Monne wrote:
 Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can
 force the usage of the Xen mptable enumerator even when ACPI is
 detected.
 Hmm, so I think one question is why does the existing MADT parser
 not work with the MADT table provided by Xen?  This may very well
 be correct, but if it's only a small change to make the existing
 MADT parser work with Xen's MADT table, that route might be
 preferable.


For dom0, the MADT seen is the system MADT, which does not bear any
reality to dom0's topology.  For PV domU, no MADT will be found.  For
HVM domU, the MADT seen ought to represent (virtual) reality.

~Andrew
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

[PATCH RFC 09/13] xen: change quality of the MADT ACPI enumerator

2013-12-24 Thread Roger Pau Monne 
Lower the quality of the MADT ACPI enumerator, so on Xen Dom0 we can
force the usage of the Xen mptable enumerator even when ACPI is
detected.
---
 sys/x86/acpica/madt.c |2 +-
 sys/x86/xen/mptable.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/x86/acpica/madt.c b/sys/x86/acpica/madt.c
index 6f3b591..897189c 100644
--- a/sys/x86/acpica/madt.c
+++ b/sys/x86/acpica/madt.c
@@ -104,7 +104,7 @@ madt_probe(void)
madt_physaddr = acpi_find_table(ACPI_SIG_MADT);
if (madt_physaddr == 0)
return (ENXIO);
-   return (0);
+   return (-50);
 }
 
 /*
diff --git a/sys/x86/xen/mptable.c b/sys/x86/xen/mptable.c
index 46b03f3..a9704ab 100644
--- a/sys/x86/xen/mptable.c
+++ b/sys/x86/xen/mptable.c
@@ -76,7 +76,7 @@ static struct apic_enumerator xenpv_enumerator = {
 static int
 xenpv_probe(void)
 {
-   return (-100);
+   return (0);
 }
 
 /*
-- 
1.7.7.5 (Apple Git-26)

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org