Re: About the type of physaddr in struct usb_page.

2014-06-02 Thread Hans Petter Selasky 

On 06/02/14 03:22, Kohji Okuno wrote:

Hi HPS,

I think the type of physaddr in struct usb_page is incorrect.
We shuld use bus_addr_t for physaddr.
What do you think about this?

60   * The following structure defines physical and non kernel virtual
61   * address of a memory page having size USB_PAGE_SIZE.
62   */
63  struct usb_page {
64  #if USB_HAVE_BUSDMA
65  bus_size_t physaddr;
66  void   *buffer; /* non Kernel Virtual Address */
67  #endif
68  };

Regards,
  Kohji Okuno


Hi,

http://svnweb.freebsd.org/changeset/base/266969

--HPS
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

About the type of physaddr in struct usb_page.

2014-06-01 Thread Kohji Okuno 
Hi HPS,

I think the type of physaddr in struct usb_page is incorrect.
We shuld use bus_addr_t for physaddr.
What do you think about this?

60   * The following structure defines physical and non kernel virtual
61   * address of a memory page having size USB_PAGE_SIZE.
62   */
63  struct usb_page {
64  #if USB_HAVE_BUSDMA
65  bus_size_t physaddr;
66  void   *buffer; /* non Kernel Virtual Address */
67  #endif
68  };

Regards,
 Kohji Okuno
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org