Re: CFR: extend use of nitems() macro in the kernel.

2016-04-21 Thread Pedro Giffuni
On 04/18/16 13:27, John Baldwin wrote: On Saturday, April 16, 2016 01:25:09 PM Pedro Giffuni wrote: Hello; Using coccinelle, and some hand re-formatting, I generated a patch to make use of the nitems() macro in sys, which is too big for phabricator [1]. I was careful to exclude anything

Re: CFR: extend use of nitems() macro in the kernel.

2016-04-18 Thread John Baldwin
On Saturday, April 16, 2016 01:25:09 PM Pedro Giffuni wrote: > Hello; > > Using coccinelle, and some hand re-formatting, I generated a patch to > make use of the nitems() macro in sys, which is too big for > phabricator [1]. > > I was careful to exclude anything from the contrib directory or >

Re: CFR: extend use of nitems() macro in the kernel.

2016-04-18 Thread Pedro Giffuni
On 04/18/16 01:56, Hans Petter Selasky wrote: On 04/16/16 20:25, Pedro Giffuni wrote: M sys/dev/usb/input/ukbd.c M sys/dev/usb/serial/u3g.c M sys/dev/usb/serial/uchcom.c M sys/dev/usb/serial/umcs.c M sys/dev/usb/serial/uplcom.c Approved. Maybe you can remove

Re: CFR: extend use of nitems() macro in the kernel.

2016-04-18 Thread Hans Petter Selasky
On 04/16/16 20:25, Pedro Giffuni wrote: M sys/dev/usb/input/ukbd.c M sys/dev/usb/serial/u3g.c M sys/dev/usb/serial/uchcom.c M sys/dev/usb/serial/umcs.c M sys/dev/usb/serial/uplcom.c Approved. Maybe you can remove the superfluous pair of parenthesis after the

Re: CFR: extend use of nitems() macro in the kernel.

2016-04-16 Thread Conrad Meyer
On Sat, Apr 16, 2016 at 11:25 AM, Pedro Giffuni wrote: > Hello; > > Using coccinelle, and some hand re-formatting, I generated a patch to > make use of the nitems() macro in sys, which is too big for > phabricator [1]. > > I was careful to exclude anything from the contrib

CFR: extend use of nitems() macro in the kernel.

2016-04-16 Thread Pedro Giffuni
Hello; Using coccinelle, and some hand re-formatting, I generated a patch to make use of the nitems() macro in sys, which is too big for phabricator [1]. I was careful to exclude anything from the contrib directory or any code that is shared with userland (as to not have to include additional