Re: Correct PCI suspend and resume operations [ was Re: cirrus ich3doesn't work after suspend to disk ]
Orion Hodson wrote: It looks like the pci configuration space state has been lost during the suspend and resume. This may be because the bus has removed power from the devices attached to it on suspend. I've been through a cross section of drivers this morning and some explicitly save and restore the PCI configuration state space and others don't. The former seems like the safest path in most cases. AFAICT, we don't common code for handling this and maybe there should be some rather than have each driver replicate this behaviour. I like this idea; are there driver-specific bits, or can it all be done at a higher level? If it can't, at least a means of recording the space the driver looks at or touches might be the ticket... -- Terry ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: Correct PCI suspend and resume operations [ was Re: cirrus ich3doesn't work after suspend to disk ]
On Tue, Jun 10, 2003 at 09:44:36AM -0700, Orion Hodson wrote: It looks like the pci configuration space state has been lost during the suspend and resume. This may be because the bus has removed power from the devices attached to it on suspend. For sure, in S4 mode the devices are powered down totally. I've been through a cross section of drivers this morning and some explicitly save and restore the PCI configuration state space and others don't. The former seems like the safest path in most cases. Yes, it is absolutely necessary even. (For the reason stated above) AFAICT, we don't common code for handling this and maybe there should be some rather than have each driver replicate this behaviour. In general, that would of course be better. However, I don't know if the PCI layer (in this case) always knows enough. On the other side, if the device itself has to do some special things, the PCI layer could at least do the generic stuff. (Warner, will this also be covered by the stuff you are doing?) Mark -- Mark SantcroosRIPE Network Coordination Centre http://www.ripe.net/home/mark/New Projects Group/TTM ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: Correct PCI suspend and resume operations [ was Re: cirrus ich3doesn't work after suspend to disk ]
On Tue, Jun 10, 2003 at 09:15:05PM +0200, Mark Santcroos wrote: AFAICT, we don't common code for handling this and maybe there should be some rather than have each driver replicate this behaviour. In general, that would of course be better. However, I don't know if the PCI layer (in this case) always knows enough. On the other side, if the device itself has to do some special things, the PCI layer could at least do the generic stuff. To be more precise, the suspend function should know the powerstate it is transitioning to. If it keeps context (D0-D2) it doesn't need to do much special, if it will loose context (D3) it should save the state at suspend, and restore the state at resume. Mark -- Mark SantcroosRIPE Network Coordination Centre http://www.ripe.net/home/mark/New Projects Group/TTM ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
