Re: Latest fetch on current broken

2002-10-28 Thread Dag-Erling Smorgrav
Craig Rodrigues [EMAIL PROTECTED] writes:
 I tracked this down further to the _fetch_writev() function
 in libfetch/common.c.  Try this patch:

Stupid, dumb bug.  Of course it is only triggered by specific packet
lengths which just happened not to occur during testing :(

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Latest fetch on current broken

2002-10-27 Thread Manfred Antar
I just did a build-install world plus new kernel
with current sources as of 3pm PST Sunday the 27th
fetch is broken:

(src)4190}fetch -vv 
ftp://ftp.fokus.gmd.de/pub/unix/cdrecord/alpha//cdrtools-1.11a39.tar.gz
--- ftp.fokus.gmd.de:21
looking up ftp.fokus.gmd.de
connecting to ftp.fokus.gmd.de:21
 220-
 220-You have reached ftp.FOKUS.FRAUNHOFER.de.
 220-Please login as `ftp' to access our archive.
 220-
 220-  Hello UNKNOWN at pozo.com,
 220-  our local time is Mon Oct 28 00:33:25 2002.
 220-
 220-There are currently 0 users connected of a limit of 35.
 220-
 220-All transfers are logged with your username and hostname (as printed above).
 220-If you don't like this policy, disconnect NOW!
 220-
 220 FTP server Fraunhofer FOKUS ready.
 USER anonymous
fetch: cdrtools-1.11a39.tar.gz: Broken pipe

ncftp works fine:

(src)4191}ncftp ftp.fokus.gmd.de:/pub/unix/cdrecord/alpha//cdrtools-1.11a39.tar.gz

You have reached ftp.FOKUS.FRAUNHOFER.de.
Please login as `ftp' to access our archive.

 Hello UNKNOWN at pozo.com,
 our local time is Mon Oct 28 00:33:57 2002.

There are currently 0 users connected of a limit of 35.

All transfers are logged with your username and hostname (as printed above).
If you don't like this policy, disconnect NOW!

Receiving file: cdrtools-1.11a39.tar.gz 
100%  0   1577294 bytes. ETA:  0:00
cdrtools-1.11a39.tar.gz: 1577294 bytes received in 40.24 seconds, 38.28 K/s.

Manfred



==
||  [EMAIL PROTECTED]   ||
||  Ph. (415) 681-6235  ||
==


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Latest fetch on current broken

2002-10-27 Thread Craig Rodrigues
On Sun, Oct 27, 2002 at 06:31:27PM -0800, Manfred Antar wrote:
 I noticed it when doing a portupgrade cdrtools
 So yes anything that uses fetch is not going to work

OK, I started tracing this down.

Here's how to get debugging versions:
cd /usr/src/lib/libfetch
make clean
make DEBUG_FLAGS=-g 
make DEBUG_FLAGS=-g  install

cd /usr/src/usr.bin/fetch
make clean
make DEBUG_FLAGS=-g NOSHARED=yes
make DEBUG_FLAGS=-g NOSHARED=yes install

I traced down the broken pipe.

It is happening somewhere in /usr/src/lib/libfetch/ftp.c
in the _ftp_authenticate() function.

I did an Ethereal capture of my ftp session, and here are the ftp
protocol messages:

220 ftp.beastie.tdk.net FTP server (Version 6.00LS) ready.
USER anonymous
331 Guest login ok, send your email address as password.
221 You could at least say goodbye.
 

-- 
Craig Rodrigues
http://www.gis.net/~craigr
[EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Latest fetch on current broken

2002-10-27 Thread Craig Rodrigues
On Sun, Oct 27, 2002 at 10:21:02PM -0500, Craig Rodrigues wrote:
 On Sun, Oct 27, 2002 at 06:31:27PM -0800, Manfred Antar wrote:
  I noticed it when doing a portupgrade cdrtools
  So yes anything that uses fetch is not going to work
 
 OK, I started tracing this down.
 
 Here's how to get debugging versions:
 cd /usr/src/lib/libfetch
 make clean
 make DEBUG_FLAGS=-g 
 make DEBUG_FLAGS=-g  install
 
 cd /usr/src/usr.bin/fetch
 make clean
 make DEBUG_FLAGS=-g NOSHARED=yes
 make DEBUG_FLAGS=-g NOSHARED=yes install


I tracked this down further to the _fetch_writev() function
in libfetch/common.c.  Try this patch:

--- lib/libfetch/common.c.orig  Sun Oct 27 22:38:16 2002
+++ lib/libfetch/common.c   Sun Oct 27 22:40:12 2002
@@ -525,7 +525,7 @@
return (-1);
}
total += wlen;
-   while (iovcnt  0  wlen  iov-iov_len) {
+   while (iovcnt  0  wlen = iov-iov_len) {
wlen -= iov-iov_len;
iov++;
iovcnt--;

-- 
Craig Rodrigues
http://www.gis.net/~craigr
[EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Latest fetch on current broken

2002-10-27 Thread Manfred Antar
At 10:38 PM 10/27/2002 -0500, Craig Rodrigues wrote:
On Sun, Oct 27, 2002 at 10:21:02PM -0500, Craig Rodrigues wrote:
 On Sun, Oct 27, 2002 at 06:31:27PM -0800, Manfred Antar wrote:
  I noticed it when doing a portupgrade cdrtools
  So yes anything that uses fetch is not going to work
 
 OK, I started tracing this down.
 
 Here's how to get debugging versions:
 cd /usr/src/lib/libfetch
 make clean
 make DEBUG_FLAGS=-g 
 make DEBUG_FLAGS=-g  install
 
 cd /usr/src/usr.bin/fetch
 make clean
 make DEBUG_FLAGS=-g NOSHARED=yes
 make DEBUG_FLAGS=-g NOSHARED=yes install


I tracked this down further to the _fetch_writev() function
in libfetch/common.c.  Try this patch:

--- lib/libfetch/common.c.orig  Sun Oct 27 22:38:16 2002
+++ lib/libfetch/common.c   Sun Oct 27 22:40:12 2002
@@ -525,7 +525,7 @@
return (-1);
}
total += wlen;
-   while (iovcnt  0  wlen  iov-iov_len) {
+   while (iovcnt  0  wlen = iov-iov_len) {
wlen -= iov-iov_len;
iov++;
iovcnt--;

-- 
Craig Rodrigues
http://www.gis.net/~craigr
[EMAIL PROTECTED] 

This change makes it work here

Manfred

==
||  [EMAIL PROTECTED]   ||
||  Ph. (415) 681-6235  ||
==


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Latest fetch on current broken

2002-10-27 Thread Carl Schmidt
On Sun, Oct 27, 2002 at 10:38:36PM -0500, Craig Rodrigues wrote:
 On Sun, Oct 27, 2002 at 10:21:02PM -0500, Craig Rodrigues wrote:
  On Sun, Oct 27, 2002 at 06:31:27PM -0800, Manfred Antar wrote:
   I noticed it when doing a portupgrade cdrtools
   So yes anything that uses fetch is not going to work
  
  OK, I started tracing this down.
  
  Here's how to get debugging versions:
  cd /usr/src/lib/libfetch
  make clean
  make DEBUG_FLAGS=-g 
  make DEBUG_FLAGS=-g  install
  
  cd /usr/src/usr.bin/fetch
  make clean
  make DEBUG_FLAGS=-g NOSHARED=yes
  make DEBUG_FLAGS=-g NOSHARED=yes install
 
 
 I tracked this down further to the _fetch_writev() function
 in libfetch/common.c.  Try this patch:
 
 --- lib/libfetch/common.c.origSun Oct 27 22:38:16 2002
 +++ lib/libfetch/common.c Sun Oct 27 22:40:12 2002
 @@ -525,7 +525,7 @@
   return (-1);
   }
   total += wlen;
 - while (iovcnt  0  wlen  iov-iov_len) {
 + while (iovcnt  0  wlen = iov-iov_len) {
   wlen -= iov-iov_len;
   iov++;
   iovcnt--;

Yay, this works for me. :)
-- 
Carl Schmidt

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message