Re: No human readable message with g_vfs

2011-01-03 Thread Ivan Voras

On 12/29/10 11:32, David Demelier wrote:

Hello,

Sometimes when I use my external harddrive I get these awful message :

g_vfs_done():da1[WRITE(offset=34590720, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
g_vfs_done():da1[WRITE(offset=34656256, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
g_vfs_done():da1[WRITE(offset=34721792, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
g_vfs_done():da1[WRITE(offset=34787328, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
g_vfs_done():da1[WRITE(offset=34852864, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel:
g_vfs_done():ufs/public[WRITE(offset=244271529984, length=16384)]error = 5
/var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel:
g_vfs_done():ufs/public[READ(offset=244563705856, length=131072)]error = 5
/var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error = 5

I think for a lambda user these are absolutely not understandable. I


Would a better message be WRITE error on da0, offset=34590720. 
length=65536, errno=5?



___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Matthias Andree
Am 03.01.2011 14:14, schrieb Ivan Voras:
 On 12/29/10 11:32, David Demelier wrote:
 Hello,

 Sometimes when I use my external harddrive I get these awful message :

 g_vfs_done():da1[WRITE(offset=34590720, length=65536)]error = 5
 /var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
 g_vfs_done():da1[WRITE(offset=34656256, length=65536)]error = 5
 /var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
 g_vfs_done():da1[WRITE(offset=34721792, length=65536)]error = 5
 /var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
 g_vfs_done():da1[WRITE(offset=34787328, length=65536)]error = 5
 /var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel:
 g_vfs_done():da1[WRITE(offset=34852864, length=65536)]error = 5
 /var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel:
 g_vfs_done():ufs/public[WRITE(offset=244271529984, length=16384)]error
 = 5
 /var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=244563705856, length=131072)]error
 = 5
 /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
 = 5

 I think for a lambda user these are absolutely not understandable. I
 
 Would a better message be WRITE error on da0, offset=34590720.
 length=65536, errno=5?

nah, strerror(errno) isn't that much of an effort

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Kostik Belousov
On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote:
 Am 03.01.2011 14:14, schrieb Ivan Voras:
  On 12/29/10 11:32, David Demelier wrote:
  /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
  g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
  = 5
 
  I think for a lambda user these are absolutely not understandable. I
  
  Would a better message be WRITE error on da0, offset=34590720.
  length=65536, errno=5?
 
 nah, strerror(errno) isn't that much of an effort
In kernel ? There is no strerror, and there is no great need to import the
sys_errlist.


pgpQs7tVRFpdU.pgp
Description: PGP signature


Re: No human readable message with g_vfs

2011-01-03 Thread Edward Tomasz Napierała
Wiadomość napisana przez Kostik Belousov w dniu 2011-01-03, o godz. 15:18:
 On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote:
 Am 03.01.2011 14:14, schrieb Ivan Voras:
 On 12/29/10 11:32, David Demelier wrote:
 /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
 = 5
 
 I think for a lambda user these are absolutely not understandable. I
 
 Would a better message be WRITE error on da0, offset=34590720.
 length=65536, errno=5?
 
 nah, strerror(errno) isn't that much of an effort
 In kernel ? There is no strerror, and there is no great need to import the
 sys_errlist.

I had code that adds strerror() to the kernel in one of my old p4 branches.
Error messages like the one above look much better this way, but I didn't
have time to push it into the tree, and there is a risk of yet another i18n
discussion.  If someone is interested - let me know; I'll try to find it.

--
If you cut off my head, what would I say?  Me and my head, or me and my body?

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Garrett Cooper
On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napierała tr...@freebsd.org wrote:

 Wiadomość napisana przez Kostik Belousov w dniu 2011-01-03, o godz. 15:18:
 On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote:
 Am 03.01.2011 14:14, schrieb Ivan Voras:
 On 12/29/10 11:32, David Demelier wrote:
 /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
 = 5
 
 I think for a lambda user these are absolutely not understandable. I
 
 Would a better message be WRITE error on da0, offset=34590720.
 length=65536, errno=5?
 
 nah, strerror(errno) isn't that much of an effort
 In kernel ? There is no strerror, and there is no great need to import the
 sys_errlist.
 
 I had code that adds strerror() to the kernel in one of my old p4 branches.
 Error messages like the one above look much better this way, but I didn't
 have time to push it into the tree, and there is a risk of yet another i18n
 discussion.  If someone is interested - let me know; I'll try to find it.

Some thoughts:
- It's a pain to parse (before I just had to scan for an int -- now it's a 
string?!?)
- It slows down printing (slow kernel - dog slow system).
- Fills up logs quicker if a subsystem or piece of hardware is going south and 
these messages slam syslog, which means I have to scan more logs looking for 
useful data, the likelihood of messages being lost in various buffers is 
higher, etc.

Why not just provide a more standard sensical printout for the messages and 
provide a secret decoder ring in userland or something for interested parties 
the don't know that error is an errno value (eg my mom and dad because they're 
unix illiterate), or just copyout all of the error data via an ioctl, print out 
the ioctl failures, and skip the kernel level printing altogether?

Thanks!
-Garrett___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Anonymous
Garrett Cooper yaneg...@gmail.com writes:

 On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napierała tr...@freebsd.org wrote:

 Wiadomość napisana przez Kostik Belousov w dniu 2011-01-03, o godz. 15:18:
 On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote:
 Am 03.01.2011 14:14, schrieb Ivan Voras:
 On 12/29/10 11:32, David Demelier wrote:
 /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
 = 5
 
 I think for a lambda user these are absolutely not understandable. I
 
 Would a better message be WRITE error on da0, offset=34590720.
 length=65536, errno=5?
 
 nah, strerror(errno) isn't that much of an effort
 In kernel ? There is no strerror, and there is no great need to import the
 sys_errlist.
 
 I had code that adds strerror() to the kernel in one of my old p4 branches.
 Error messages like the one above look much better this way, but I didn't
 have time to push it into the tree, and there is a risk of yet another i18n
 discussion.  If someone is interested - let me know; I'll try to find it.

 Some thoughts:
 - It's a pain to parse (before I just had to scan for an int -- now it's a 
 string?!?)
 - It slows down printing (slow kernel - dog slow system).
 - Fills up logs quicker if a subsystem or piece of hardware is going
 south and these messages slam syslog, which means I have to scan more
 logs looking for useful data, the likelihood of messages being lost in
 various buffers is higher, etc.

 Why not just provide a more standard sensical printout for the
 messages and provide a secret decoder ring in userland or something

Do you mean perror(1)?

  $ perror 5
  Input/output error

 for interested parties the don't know that error is an errno value (eg
 my mom and dad because they're unix illiterate), or just copyout all
 of the error data via an ioctl, print out the ioctl failures, and skip
 the kernel level printing altogether?
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Garrett Cooper
On Jan 3, 2011, at 10:20 AM, Anonymous wrote:

 Garrett Cooper yaneg...@gmail.com writes:
 
 On Jan 3, 2011, at 8:33 AM, Edward Tomasz Napierała tr...@freebsd.org 
 wrote:
 
 Wiadomość napisana przez Kostik Belousov w dniu 2011-01-03, o godz. 15:18:
 On Mon, Jan 03, 2011 at 02:16:37PM +0100, Matthias Andree wrote:
 Am 03.01.2011 14:14, schrieb Ivan Voras:
 On 12/29/10 11:32, David Demelier wrote:
 /var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel:
 g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error
 = 5
 
 I think for a lambda user these are absolutely not understandable. I
 
 Would a better message be WRITE error on da0, offset=34590720.
 length=65536, errno=5?
 
 nah, strerror(errno) isn't that much of an effort
 In kernel ? There is no strerror, and there is no great need to import the
 sys_errlist.
 
 I had code that adds strerror() to the kernel in one of my old p4 branches.
 Error messages like the one above look much better this way, but I didn't
 have time to push it into the tree, and there is a risk of yet another i18n
 discussion.  If someone is interested - let me know; I'll try to find it.
 
 Some thoughts:
 - It's a pain to parse (before I just had to scan for an int -- now it's a 
 string?!?)
 - It slows down printing (slow kernel - dog slow system).
 - Fills up logs quicker if a subsystem or piece of hardware is going
 south and these messages slam syslog, which means I have to scan more
 logs looking for useful data, the likelihood of messages being lost in
 various buffers is higher, etc.
 
 Why not just provide a more standard sensical printout for the
 messages and provide a secret decoder ring in userland or something
 
 Do you mean perror(1)?
 
  $ perror 5
  Input/output error

Heh -- didn't realize that someone made a userland app for that libcall already 
:D... You learn new things everyday I guess :).

In that case IMO nothing needs to be done minus (if you're interested) creating 
a parser that data mines stuff to make it more human readable in a common 
format, i.e.

error: 5 (Input/output error)
subsystem specific information does here

that would make life when reporting PRs or issues on the list a lot more 
uniform and easier to follow, and could apply to several utilities (atacontrol, 
camcontrol, etc). My company has a similar in-house tool that does that, but 
it's not necessarily the easiest tool to deal with nor the most correct when it 
comes to some issues in FreeBSD.

 for interested parties the don't know that error is an errno value (eg
 my mom and dad because they're unix illiterate), or just copyout all
 of the error data via an ioctl, print out the ioctl failures, and skip
 the kernel level printing altogether?

Thanks!
-Garrett___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Bakul Shah
On Mon, 03 Jan 2011 21:20:42 +0300 Anonymous swel...@gmail.com  wrote:
 
 Do you mean perror(1)?
 
   $ perror 5
   Input/output error

I prefer mine:

$ errno () { grep ^#.*\\$*\\ /usr/include/sys/errno.h }
$ errno 5
#define EIO 5   /* Input/output error */
$ errno EIO
#define EIO 5   /* Input/output error */
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Anonymous
Bakul Shah ba...@bitblocks.com writes:

 On Mon, 03 Jan 2011 21:20:42 +0300 Anonymous swel...@gmail.com  wrote:
 
 Do you mean perror(1)?
 
   $ perror 5
   Input/output error

 I prefer mine:

 $ errno () { grep ^#.*\\$*\\ /usr/include/sys/errno.h }
 $ errno 5
 #define EIO 5   /* Input/output error */
 $ errno EIO
 #define EIO 5   /* Input/output error */

perror(1) displays localized messages

  $ LANG=ja_JP.UTF-8 perror 5
  入出力エラーです

  $ LANG=uk_UA.UTF-8 perror 5
  Помилка вводу-виводу

but I have to agree that knowing errno macro is useful
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: No human readable message with g_vfs

2011-01-03 Thread Bakul Shah
On Mon, 03 Jan 2011 22:21:51 +0300 Anonymous swel...@gmail.com  wrote:
 Bakul Shah ba...@bitblocks.com writes:
 
  On Mon, 03 Jan 2011 21:20:42 +0300 Anonymous swel...@gmail.com  wrote:
 =20
  Do you mean perror(1)?
 =20
$ perror 5
Input/output error
 
  I prefer mine:
 
  $ errno () { grep ^#.*\\$*\\ /usr/include/sys/errno.h }
  $ errno 5
  #define EIO 5   /* Input/output error */
  $ errno EIO
  #define EIO 5   /* Input/output error */
 
 perror(1) displays localized messages
 
   $ LANG=3Dja_JP.UTF-8 perror 5
   =E5=85=A5=E5=87=BA=E5=8A=9B=E3=82=A8=E3=83=A9=E3=83=BC=E3=81=A7=E3=81=99
 
   $ LANG=3Duk_UA.UTF-8 perror 5
   =D0=9F=D0=BE=D0=BC=D0=B8=D0=BB=D0=BA=D0=B0 =D0=B2=D0=B2=D0=BE=D0=B4=D1=83=
 -=D0=B2=D0=B8=D0=B2=D0=BE=D0=B4=D1=83

Yes, definitely useful. Perhaps strerror would be a better name?

 but I have to agree that knowing errno macro is useful

And you can use grep tricks :-)

$ errno '[dD]evice'
#define ENXIO   6   /* Device not configured */
#define ENOTBLK 15  /* Block device required */
#define EBUSY   16  /* Device busy */
#define EXDEV   18  /* Cross-device link */
#define ENODEV  19  /* Operation not supported by device */
#define ENOTTY  25  /* Inappropriate ioctl for device */
#define ENOSPC  28  /* No space left on device */
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


No human readable message with g_vfs

2010-12-29 Thread David Demelier

Hello,

Sometimes when I use my external harddrive I get these awful message :

g_vfs_done():da1[WRITE(offset=34590720, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel: 
g_vfs_done():da1[WRITE(offset=34656256, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel: 
g_vfs_done():da1[WRITE(offset=34721792, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel: 
g_vfs_done():da1[WRITE(offset=34787328, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 18:36:07 Abricot kernel: 
g_vfs_done():da1[WRITE(offset=34852864, length=65536)]error = 5
/var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel: 
g_vfs_done():ufs/public[WRITE(offset=244271529984, length=16384)]error = 5
/var/log/messages.1.bz2:Dec 21 22:50:28 Abricot kernel: 
g_vfs_done():ufs/public[READ(offset=244563705856, length=131072)]error = 5
/var/log/messages.5.bz2:Nov 29 16:36:52 Abricot kernel: 
g_vfs_done():ufs/public[READ(offset=232718991360, length=131072)]error = 5


I think for a lambda user these are absolutely not understandable. I 
think these message could be enabled with a little options in the kernel 
config.


why not something like options GPART_DEBUG or something else? And 
do something more readable without.


Kind regards,

--
David Demelier
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org