Re: OpenSSL breaks factor(6)

2020-01-06 Thread Steve Kargl
On Sun, Dec 29, 2019 at 08:02:47AM -0800, Steve Kargl wrote: > Here's a final attempt at fixing and documenting FreeBSD's factor(6). > Do what you want with the patch. With and without OpenSSL, one now > gets > > % factor +123 123 123 123zabc 123abc +123abc 0x123abc +0x123abc > 123: 3 41 >

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Steve Kargl
On Sun, Dec 29, 2019 at 05:14:28PM -0500, Garance A Drosehn wrote: > On 29 Dec 2019, at 2:17, Steve Kargl wrote: > > > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > >>> > >>> An interested user will need to add that support. AFAIK, factor(6) > >>> has never recognized the

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Steve Kargl
On Sun, Dec 29, 2019 at 01:31:26PM -0900, Robert Wing wrote: > Have y'all ever seen reviews.freebsd.org? > I have a FreeBSD login account and a FreeBSD bugzilla account. I don't need yet another FreeBSD account. If bugzilla were set up to parse email replies, this would be attached a bug

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Robert Wing
Have y'all ever seen reviews.freebsd.org? On Sunday, December 29, 2019, Garance A Drosehn wrote: > On 29 Dec 2019, at 2:17, Steve Kargl wrote: > > > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > >>> > >>> An interested user will need to add that support. AFAIK, factor(6)

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Garance A Drosehn
On 29 Dec 2019, at 2:17, Steve Kargl wrote: > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: >>> >>> An interested user will need to add that support. AFAIK, factor(6) >>> has never recognized the 0x prefix, and I'm not trying to add new >>> features. I'm simply fixing

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Steve Kargl
On Sun, Dec 29, 2019 at 08:02:47AM -0800, Steve Kargl wrote: > Here's a final attempt at fixing and documenting FreeBSD's factor(6). > Do what you want with the patch. With and without OpenSSL, one now > gets > > % factor +123 123 123 123zabc 123abc +123abc 0x123abc +0x123abc > 123: 3 41 >

Re: OpenSSL breaks factor(6)

2019-12-29 Thread Steve Kargl
Here's a final attempt at fixing and documenting FreeBSD's factor(6). Do what you want with the patch. With and without OpenSSL, one now gets % factor +123 123 123 123zabc 123abc +123abc 0x123abc +0x123abc 123: 3 41 123: 3 41 123: 3 41 123: 3 41 1194684: 2 2 3 29 3433 1194684: 2 2 3 29 3433

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Steve Kargl
On Sat, Dec 28, 2019 at 11:17:31PM -0800, Steve Kargl wrote: > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > > On 29 Dec 2019, at 0:10, Steve Kargl wrote: > > > > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > >> > > >> What if the user wants to

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Steve Kargl
On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > On 29 Dec 2019, at 0:10, Steve Kargl wrote: > > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > >> > >> What if the user wants to factor a hexadecimal value which does not > >> happen to include [a...f]? >

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Steve Kargl
On Sat, Dec 28, 2019 at 09:34:52PM -0800, Rodney W. Grimes wrote: > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > > simple scans the string

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Garance A Drosehn
On 29 Dec 2019, at 0:10, Steve Kargl wrote: > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: >> >> What if the user wants to factor a hexadecimal value which does not >> happen to include [a...f]? >> >> How about recognizing a prefix of '0x' as a way to indicate the value >>

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Rodney W. Grimes
> On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > simple scans the string for a hex digit in [a,...,f] and assumes > > > that a hexadecimal string has

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Steve Kargl
On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > This patch now includes a fix for hexadecimal conversion. It > > simple scans the string for a hex digit in [a,...,f] and assumes > > that a hexadecimal string has been

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Garance A Drosehn
On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > This patch now includes a fix for hexadecimal conversion. It > simple scans the string for a hex digit in [a,...,f] and assumes > that a hexadecimal string has been entered. A string that includes > character from the decimal digits is assumed to

Re: OpenSSL breaks factor(6)

2019-12-28 Thread Steve Kargl
On Fri, Dec 27, 2019 at 09:15:33PM -0800, Steve Kargl wrote: > On Fri, Dec 27, 2019 at 08:42:53PM -0800, Rodney W. Grimes wrote: > > > On Fri, Dec 27, 2019 at 07:00:04PM -0800, Rodney W. Grimes wrote: > > > > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > > > > > > > > This

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
On Fri, Dec 27, 2019 at 08:42:53PM -0800, Rodney W. Grimes wrote: > > On Fri, Dec 27, 2019 at 07:00:04PM -0800, Rodney W. Grimes wrote: > > > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > >

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Rodney W. Grimes
> On Fri, Dec 27, 2019 at 07:00:04PM -0800, Rodney W. Grimes wrote: > > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > > > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > > > > its

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
On Fri, Dec 27, 2019 at 07:00:04PM -0800, Rodney W. Grimes wrote: > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > > > its documentation.

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Rodney W. Grimes
> On Fri, Dec 27, 2019 at 02:42:12PM -0800, Steve Kargl wrote: > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > > > its documentation. > >

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Rodney W. Grimes
> On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > > its documentation. > > > > > > % man factor > > > ... > > > Numbers may be preceded by a

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
On Fri, Dec 27, 2019 at 02:42:12PM -0800, Steve Kargl wrote: > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > > its documentation. > > > > > >

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > > The use of OpenSSL in factor(6) breaks factor(6) with respect to > > its documentation. > > > > % man factor > > ... > > Numbers may be preceded by a single '+'. > >

Re: OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
On Fri, Dec 27, 2019 at 01:25:30PM -0800, Steve Kargl wrote: > The use of OpenSSL in factor(6) breaks factor(6) with respect to > its documentation. > > % man factor > ... > Numbers may be preceded by a single '+'. > ... > > % factor +125 > factor: +125: illegal numeric format. > This

OpenSSL breaks factor(6)

2019-12-27 Thread Steve Kargl
The use of OpenSSL in factor(6) breaks factor(6) with respect to its documentation. % man factor ... Numbers may be preceded by a single '+'. ... % factor +125 factor: +125: illegal numeric format. without OpenSSL one gets % factor +125 125: 5 5 5 Although undocumented, factor(6) seems