Re: Remove debug echo
Garrett, On Thu, Dec 15, 2011 at 10:39 AM, Garrett Cooper yaneg...@gmail.com wrote: If someone would please, PLEASE commit this.. I will give you beer, or wine, or a copy of Skyrim, or a few months subscription to WoW, or something else of value to you that we could negotiate :)... I'm quite frankly tired of having to playing guessing games fishing through logs trying to determine build errors on FreeBSD if and when they do occur with pmake, and I'm sure that a number of developers and build/release engineers out there are in the same boat as I am. Can you explain why did you remove MESSAGE() invocations in your patch? Other than that the patch looks good to me. I thought that printing out MESSAGE and the more informative *printf was kind of redundant. Thanks! -Garrett PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make would segfault as MESSAGE depends on targFmt and targPrefix being set to something sane (they both default to NULL -- one explicitly, the other implicitly because it's in the .BSS). These vars are only set in one section of code, but I took the easy route out to avoid accidentally breaking other code paths and because what I did in the previously attached patch was simple to implement and test. I did not mean that you should use MESSAGE() for your purposes, but removing existing invocations seems to be unnecessary. Max ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
Garrett,
On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper yaneg...@gmail.com wrote:
I've attached a patch that makes make do what I would like it to do;
there are some other items that require cleanup to achieve the `argv0'
prefixing that's available in gmake, but this is good enough for a
meaningful traceback when things fail. Pastebin available here, just
in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
$ cat ~/Makefile
all:
cd $$HOME/foo; ${MAKE} $@
$ cat ~/foo/Makefile
all: foo bar barf yadda
foo bar yadda:
@true
baz:
@false
barf: baz
$ $PWD/make -j4 -f ~/Makefile all
cd $HOME/foo; /usr/src/usr.bin/make/make all
*** [baz] Error code 1
1 error
*** [all] Error code 2
1 error
$
If someone would please, PLEASE commit this.. I will give you beer, or
wine, or a copy of Skyrim, or a few months subscription to WoW, or
something else of value to you that we could negotiate :)... I'm quite
frankly tired of having to playing guessing games fishing through logs
trying to determine build errors on FreeBSD if and when they do occur
with pmake, and I'm sure that a number of developers and build/release
engineers out there are in the same boat as I am.
Can you explain why did you remove MESSAGE() invocations in your patch?
Other than that the patch looks good to me.
Max
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed, Dec 14, 2011 at 7:27 PM, Max Khon f...@samodelkin.net wrote:
Garrett,
On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper yaneg...@gmail.com wrote:
I've attached a patch that makes make do what I would like it to do;
there are some other items that require cleanup to achieve the `argv0'
prefixing that's available in gmake, but this is good enough for a
meaningful traceback when things fail. Pastebin available here, just
in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
$ cat ~/Makefile
all:
cd $$HOME/foo; ${MAKE} $@
$ cat ~/foo/Makefile
all: foo bar barf yadda
foo bar yadda:
@true
baz:
@false
barf: baz
$ $PWD/make -j4 -f ~/Makefile all
cd $HOME/foo; /usr/src/usr.bin/make/make all
*** [baz] Error code 1
1 error
*** [all] Error code 2
1 error
$
If someone would please, PLEASE commit this.. I will give you beer, or
wine, or a copy of Skyrim, or a few months subscription to WoW, or
something else of value to you that we could negotiate :)... I'm quite
frankly tired of having to playing guessing games fishing through logs
trying to determine build errors on FreeBSD if and when they do occur
with pmake, and I'm sure that a number of developers and build/release
engineers out there are in the same boat as I am.
Can you explain why did you remove MESSAGE() invocations in your patch?
Other than that the patch looks good to me.
I thought that printing out MESSAGE and the more informative
*printf was kind of redundant.
Thanks!
-Garrett
PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make
would segfault as MESSAGE depends on targFmt and targPrefix being set
to something sane (they both default to NULL -- one explicitly, the
other implicitly because it's in the .BSS). These vars are only set in
one section of code, but I took the easy route out to avoid
accidentally breaking other code paths and because what I did in the
previously attached patch was simple to implement and test.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Thursday, December 01, 2011 2:15:11 am Garrett Cooper wrote:
On Wed, Nov 30, 2011 at 5:59 PM, Garrett Cooper yaneg...@gmail.com wrote:
On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best arun...@freebsd.org
wrote:
On Wed Nov 30 11, Garrett Cooper wrote:
On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org
wrote:
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077
by Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those
module
printfs? i see messages for cleandir, obj, depend and all. i
think for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times
4 and
you'll get 2680 lines of output. not really *silent*, is it? ;)
pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the Error
Code output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
ehmmm...a noisy silent flag? i totally agree, if we're talking about
'make' in
its default mode, but what's the point of a silent flag, if it produces
2500
lines of output? nobody uses the -s flag for diagnostics. its purpose is
to
build a kernel without producing a lot of output and also not fiddling
with
stdout/stderr to achieve that goal.
What I really want is this:
$ cat Makefile
all: foo bar baz yadda
foo bar yadda:
baz:
false
$ gmake
false
gmake: *** [baz] Error 1
$ make all
false
*** Error code 1
Stop in /tmp.
Otherwise diagnosing issues becomes a PITA with -j 1 (with pmake I
have to start using some serious grep'ing, and if I'm lucky I can find
the source of error). If I get a few spare cycles I might just
implement it and post a patch somewhere (the entering and leaving
directory feature of gmake is really nice too, but it's less
important.. unless you have the same target in multiple directories)..
I've attached a patch that makes make do what I would like it to do;
there are some other items that require cleanup to achieve the `argv0'
prefixing that's available in gmake, but this is good enough for a
meaningful traceback when things fail. Pastebin available here, just
in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
I think this is useful, perhaps send it to harti@ or jilles@ for review?
--
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
So, now that you've improved the default diagnostic output of make, how about the OP's original request: make -s truly silent by removing unnecessary diagnostic messages when -s is used? :) [Thought I'd bring the thread back around to it's original purpose.] -- Freddie Cash fjwc...@gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
Garrett,
On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper yaneg...@gmail.com wrote:
What I really want is this:
$ cat Makefile
all: foo bar baz yadda
foo bar yadda:
baz:
false
$ gmake
false
gmake: *** [baz] Error 1
$ make all
false
*** Error code 1
Stop in /tmp.
Otherwise diagnosing issues becomes a PITA with -j 1 (with pmake I
have to start using some serious grep'ing, and if I'm lucky I can find
the source of error). If I get a few spare cycles I might just
implement it and post a patch somewhere (the entering and leaving
directory feature of gmake is really nice too, but it's less
important.. unless you have the same target in multiple directories)..
I've attached a patch that makes make do what I would like it to do;
there are some other items that require cleanup to achieve the `argv0'
prefixing that's available in gmake, but this is good enough for a
meaningful traceback when things fail. Pastebin available here, just
in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
$ cat ~/Makefile
all:
cd $$HOME/foo; ${MAKE} $@
$ cat ~/foo/Makefile
all: foo bar barf yadda
foo bar yadda:
@true
baz:
@false
barf: baz
$ $PWD/make -j4 -f ~/Makefile all
cd $HOME/foo; /usr/src/usr.bin/make/make all
*** [baz] Error code 1
1 error
*** [all] Error code 2
1 error
$
If someone would please, PLEASE commit this.. I will give you beer, or
wine, or a copy of Skyrim, or a few months subscription to WoW, or
something else of value to you that we could negotiate :)... I'm quite
frankly tired of having to playing guessing games fishing through logs
trying to determine build errors on FreeBSD if and when they do occur
with pmake, and I'm sure that a number of developers and build/release
engineers out there are in the same boat as I am.
I hit the same problem regularly. The patch looks good to me as well.
Max
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Thu, Dec 1, 2011 at 9:17 AM, Freddie Cash fjwc...@gmail.com wrote: So, now that you've improved the default diagnostic output of make, how about the OP's original request: make -s truly silent by removing unnecessary diagnostic messages when -s is used? :) [Thought I'd bring the thread back around to it's original purpose.] Sure. I'd be more than happy if someone would review and commit my proposed patches as well :). Thanks! -Garrett ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed, Nov 30, 2011 at 05:59:33PM -0800, Garrett Cooper wrote: On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best arun...@freebsd.org wrote: On Wed Nov 30 11, Garrett Cooper wrote: On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org wrote: ? ? pmake sucks as far as diagnostic output is concerned when compared with gmake. I'd rather not have to fish through with -j1 (if I'm lucky and it's not a race) to determine what directory created the Error Code output. With the printouts discussed here, at least you have a chance at determining what the issue was. ? ? Maybe it's just me, but I like noisy builds -- otherwise the amount of time I have to spend root-causing the issue becomes expensive. [...] Otherwise diagnosing issues becomes a PITA with -j 1 (with pmake I have to start using some serious grep'ing, and if I'm lucky I can find the source of error). Well its a PITA mostly because we disabled Pmake's -j job-markers back in 1998 (r41151). If you build with 'make -v -j1' you get much more debugable output. bmake (NetBSD's make) is even nicer in this regard. I was *amazed* when I joined $WORK and a '-j16' build was debugable. -- -- David (obr...@freebsd.org) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Thu, Dec 01, 2011 at 10:04:08AM -0500, John Baldwin wrote: I think this is useful, perhaps send it to harti@ or jilles@ for review? I'd like to get some NetBSD bmake maintainers POV too. We should reduce the needless diversion between the two makes. -- -- David (obr...@freebsd.org) ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Thu, Dec 1, 2011 at 6:08 PM, David O'Brien obr...@freebsd.org wrote: On Thu, Dec 01, 2011 at 10:04:08AM -0500, John Baldwin wrote: I think this is useful, perhaps send it to harti@ or jilles@ for review? I'd like to get some NetBSD bmake maintainers POV too. We should reduce the needless diversion between the two makes. Agreed, but this is also a more extensive project. I just implemented the patch shown above because it makes pmake in FreeBSD match GNU make's behavior with printouts, which is a plus for people like me who have scripts that parse for errors messages like that. Thanks! -Garrett ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077 by
Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those module
printfs? i see messages for cleandir, obj, depend and all. i think for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and
you'll get 2680 lines of output. not really *silent*, is it? ;)
cheers.
alex
--
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org wrote:
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077 by
Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those module
printfs? i see messages for cleandir, obj, depend and all. i think for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and
you'll get 2680 lines of output. not really *silent*, is it? ;)
pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the Error
Code output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
Thanks,
-Garrett
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed Nov 30 11, Garrett Cooper wrote:
On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org wrote:
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077 by
Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those module
printfs? i see messages for cleandir, obj, depend and all. i think
for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and
you'll get 2680 lines of output. not really *silent*, is it? ;)
pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the Error
Code output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make' in
its default mode, but what's the point of a silent flag, if it produces 2500
lines of output? nobody uses the -s flag for diagnostics. its purpose is to
build a kernel without producing a lot of output and also not fiddling with
stdout/stderr to achieve that goal.
cheers.
alex
Thanks,
-Garrett
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best arun...@freebsd.org wrote:
On Wed Nov 30 11, Garrett Cooper wrote:
On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org wrote:
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077 by
Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those module
printfs? i see messages for cleandir, obj, depend and all. i think
for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4
and
you'll get 2680 lines of output. not really *silent*, is it? ;)
pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the Error
Code output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make' in
its default mode, but what's the point of a silent flag, if it produces 2500
lines of output? nobody uses the -s flag for diagnostics. its purpose is to
build a kernel without producing a lot of output and also not fiddling with
stdout/stderr to achieve that goal.
What I really want is this:
$ cat Makefile
all: foo bar baz yadda
foo bar yadda:
baz:
false
$ gmake
false
gmake: *** [baz] Error 1
$ make all
false
*** Error code 1
Stop in /tmp.
Otherwise diagnosing issues becomes a PITA with -j 1 (with pmake I
have to start using some serious grep'ing, and if I'm lucky I can find
the source of error). If I get a few spare cycles I might just
implement it and post a patch somewhere (the entering and leaving
directory feature of gmake is really nice too, but it's less
important.. unless you have the same target in multiple directories)..
Thanks,
-Garrett
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On Wed, Nov 30, 2011 at 5:59 PM, Garrett Cooper yaneg...@gmail.com wrote:
On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best arun...@freebsd.org wrote:
On Wed Nov 30 11, Garrett Cooper wrote:
On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best arun...@freebsd.org wrote:
On Tue Nov 29 11, Warner Losh wrote:
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s
buildworld'
output and I think it was debugging accidentally left in in 213077 by
Warner:
Index: newvers.sh
===
--- newvers.sh (revision 228074)
+++ newvers.sh (working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
also...
when running buildkernel via 'make -s', do we really need all those module
printfs? i see messages for cleandir, obj, depend and all. i
think for
'make -s', that's pure overkill!
for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4
and
you'll get 2680 lines of output. not really *silent*, is it? ;)
pmake sucks as far as diagnostic output is concerned when compared
with gmake. I'd rather not have to fish through with -j1 (if I'm lucky
and it's not a race) to determine what directory created the Error
Code output. With the printouts discussed here, at least you have a
chance at determining what the issue was.
Maybe it's just me, but I like noisy builds -- otherwise the
amount of time I have to spend root-causing the issue becomes
expensive.
ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make'
in
its default mode, but what's the point of a silent flag, if it produces
2500
lines of output? nobody uses the -s flag for diagnostics. its purpose is to
build a kernel without producing a lot of output and also not fiddling with
stdout/stderr to achieve that goal.
What I really want is this:
$ cat Makefile
all: foo bar baz yadda
foo bar yadda:
baz:
false
$ gmake
false
gmake: *** [baz] Error 1
$ make all
false
*** Error code 1
Stop in /tmp.
Otherwise diagnosing issues becomes a PITA with -j 1 (with pmake I
have to start using some serious grep'ing, and if I'm lucky I can find
the source of error). If I get a few spare cycles I might just
implement it and post a patch somewhere (the entering and leaving
directory feature of gmake is really nice too, but it's less
important.. unless you have the same target in multiple directories)..
I've attached a patch that makes make do what I would like it to do;
there are some other items that require cleanup to achieve the `argv0'
prefixing that's available in gmake, but this is good enough for a
meaningful traceback when things fail. Pastebin available here, just
in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
$ cat ~/Makefile
all:
cd $$HOME/foo; ${MAKE} $@
$ cat ~/foo/Makefile
all: foo bar barf yadda
foo bar yadda:
@true
baz:
@false
barf: baz
$ $PWD/make -j4 -f ~/Makefile all
cd $HOME/foo; /usr/src/usr.bin/make/make all
*** [baz] Error code 1
1 error
*** [all] Error code 2
1 error
$
If someone would please, PLEASE commit this.. I will give you beer, or
wine, or a copy of Skyrim, or a few months subscription to WoW, or
something else of value to you that we could negotiate :)... I'm quite
frankly tired of having to playing guessing games fishing through logs
trying to determine build errors on FreeBSD if and when they do occur
with pmake, and I'm sure that a number of developers and build/release
engineers out there are in the same boat as I am.
Thanks,
-Garrett
more-meaningful-make-errors.patch
Description: Binary data
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
On 11/29/2011 13:07, John Baldwin wrote:
Any objections to this?
Nope. I wondered why it was there myself, but didn't care enough to ask. :)
It removes a weird line during 'make -s buildworld'
output and I think it was debugging accidentally left in in 213077 by Warner:
Index: newvers.sh
===
--- newvers.sh(revision 228074)
+++ newvers.sh(working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
--
We could put the whole Internet into a book.
Too practical.
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Remove debug echo
kill it.
Warner
On Nov 29, 2011, at 2:07 PM, John Baldwin wrote:
Any objections to this? It removes a weird line during 'make -s buildworld'
output and I think it was debugging accidentally left in in 213077 by Warner:
Index: newvers.sh
===
--- newvers.sh(revision 228074)
+++ newvers.sh(working copy)
@@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do
done
if [ -n $svnversion ] ; then
- echo $svnversion
svn=`cd ${SYSDIR} $svnversion`
case $svn in
[0-9]*) svn= r${svn} ;;
--
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
