Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 07:06:54PM -0800, Kris Kennaway wrote: If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. The difference is _impending_. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Tue, Feb 05, 2002 at 07:20:46AM -0800, David O'Brien wrote: On Mon, Feb 04, 2002 at 07:06:54PM -0800, Kris Kennaway wrote: If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. The difference is _impending_. EPARSE. Kris msg34142/pgp0.pgp Description: PGP signature
Re: pam_ssh world breakage
In message: [EMAIL PROTECTED] Kris Kennaway [EMAIL PROTECTED] writes: : On Tue, Feb 05, 2002 at 07:20:46AM -0800, David O'Brien wrote: : On Mon, Feb 04, 2002 at 07:06:54PM -0800, Kris Kennaway wrote: : If you use the argument that one shouldn't set WARNS because a new : compiler will cause the tree to break, then there's no point having it : at all since that condition will always be true. : : The difference is _impending_. : : EPARSE. I think that David is trying to say that Look guys, I'm this close to importing gcc3. It does warnings differently. Cranking up the WARNS level now will get in the way of my work and will lead to unnecessary build breakage on some platforms that I don't compile for all the time. Please go ahead and fix the warnings at the higher levels, but don't put WARNS=x into the Makefile* until I'm done importing things. Warner To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: This delta breaks buildworld. gcc(1) has a known bug-feature of hiding some errors in standard system headers, making them invisible without -I. ... and compile now can't survive the WARNS=4. Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. Well, of course feel free to make the code changes, but PLEASE do not commit any stronger WARNS levels to Makefiles. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
David O'Brien [EMAIL PROTECTED] writes: Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. Well, of course feel free to make the code changes, but PLEASE do not commit any stronger WARNS levels to Makefiles. Alternatively, developers working on WARNS could use a newer GCC from the ports collection. Best regards, Mike Barcroft To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 09:17:17AM -0800, David O'Brien wrote: On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: This delta breaks buildworld. gcc(1) has a known bug-feature of hiding some errors in standard system headers, making them invisible without -I. ... and compile now can't survive the WARNS=4. Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. If a new compiler generates more warnings then we should temporarily disable the warnings when the compiler is imported by setting WARNS=0 in bsd.sys.mk. All of the Makefile.inc's which set a default WARNS value for a subdirectory use WARNS?= for this reason (so they can be globally overridden until someone goes through and fixes the new ones). If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. Kris msg34130/pgp0.pgp Description: PGP signature
