fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Ruslan Ermilov
Should I commit the attached patch then? On Tue, Jun 12, 2001 at 02:35:39PM +1000, Bruce Evans wrote: For those interested, here's the missing patch. Index: lib/libc/gen/fts.c === RCS file: /home/ncvs/src/lib/libc/gen/fts.c,v

Re: fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Bruce Evans
On Wed, 13 Jun 2001, Ruslan Ermilov wrote: Should I commit the attached patch then? I don't like changing the documented interface of fts_open() but all the alternatives that I can think of aren't appealing: 1. Provide a glue function that converts what qsort expects to the documented

Re: fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Garrett Wollman
On Wed, 13 Jun 2001 23:28:29 +1000 (EST), Bruce Evans [EMAIL PROTECTED] said: 3. Provide an alternative to qsort() that takes an comparison function that takes an additional function pointer arg (use this arg to avoid the global in (1)). Actually, doing this would solve a number of

Re: fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Ruslan Ermilov
On Wed, Jun 13, 2001 at 11:16:57AM -0400, Garrett Wollman wrote: On Wed, 13 Jun 2001 23:28:29 +1000 (EST), Bruce Evans [EMAIL PROTECTED] said: 3. Provide an alternative to qsort() that takes an comparison function that takes an additional function pointer arg (use this arg to avoid

Re: fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Garrett Wollman
On Wed, 13 Jun 2001 11:55:30 -0400, Alfred Perlstein [EMAIL PROTECTED] said: Why not do something like the rpc code does? Check if threaded, if so cons up a thread specific key otherwise use a global. The Standard does not appear to say whether qsort() is reentrant, but I believe that it

Re: fts_open() (was: Re: Patch to restore WARNS feature)

2001-06-13 Thread Bruce Evans
On Wed, 13 Jun 2001, Garrett Wollman wrote: On Wed, 13 Jun 2001 23:28:29 +1000 (EST), Bruce Evans [EMAIL PROTECTED] said: 3. Provide an alternative to qsort() that takes an comparison function that takes an additional function pointer arg (use this arg to avoid the global in (1)).