gccmakedep fix - 20130619

2013-06-18 Thread Oliver Pinter
Hi all!

Attached a fix to gccmakedep.
diff --git a/devel/gccmakedep/Makefile b/devel/gccmakedep/Makefile
index b7e8cf6..07c3ef3 100644
--- a/devel/gccmakedep/Makefile
+++ b/devel/gccmakedep/Makefile
@@ -20,6 +20,7 @@ PLIST_FILES=	bin/gccmakedep
 .if (${OSVERSION} = 900506  ${OSVERSION}  100) || \
 ${OSVERSION} = 110
 CONFIGURE_ENV+=	ac_cv_path_RAWCPP=gcpp
+.endif
 
 post-patch:
 	@${REINPLACE_CMD} 's/test.*-traditional.*;/true;/' ${WRKSRC}/configure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: gccmakedep fix - 20130619

2013-06-18 Thread Oliver Pinter
On 6/19/13, John Marino dragonfly...@marino.st wrote:
 On 6/19/2013 01:00, Oliver Pinter wrote:
 Hi all!

 Attached a fix to gccmakedep.


 So
 1) There's already multiple PRs on this, including one I just submitted:
 http://www.freebsd.org/cgi/query-pr.cgi?pr=179571

 2) Your patch adds an .endif which is already there
Hmm.. now I checked in github too:
https://github.com/freebsd/freebsd-ports/blob/master/devel/gccmakedep/Makefile
. Sure. Then my local git repo was broken.


 3) Is not it better to submit via PR (GNATS) rather than a mailing list?
   That's what PRs are for...

Mail are faster than PR-s.


 John


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: gccmakedep fix - 20130619

2013-06-18 Thread Mark Linimon
On Wed, Jun 19, 2013 at 01:51:42AM +0200, Oliver Pinter wrote:
  3) Is not it better to submit via PR (GNATS) rather than a mailing list?
That's what PRs are for...
 
 Mail are faster than PR-s.

If we all go down that route, it means less and less people will try
to read all the traffic on ports@.  Please, use the PR database for
what's it's intended for.  Thanks.

mcl
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: gccmakedep fix - 20130619

2013-06-18 Thread John Marino

On 6/19/2013 01:00, Oliver Pinter wrote:

Hi all!

Attached a fix to gccmakedep.



So
1) There's already multiple PRs on this, including one I just submitted:
http://www.freebsd.org/cgi/query-pr.cgi?pr=179571

2) Your patch adds an .endif which is already there

3) Is not it better to submit via PR (GNATS) rather than a mailing list? 
 That's what PRs are for...


John

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org