Re: named crashes on assertion in rbtdb.c o? sparc64/SMP
On Wed, Jul 06, 2011 at 11:55:15AM +0200, Marius Strobl wrote: > On Tue, Jul 05, 2011 at 05:55:09PM -0700, Doug Barton wrote: > > On 06/28/2011 08:58, Marius Strobl wrote: > > >Uhm, we once fixed a problem in the MD atomic implementation which > > >still seems to present in the ISC copy. Could you please test whether > > >the following patch makes a difference? > > >http://people.freebsd.org/~marius/sparc64_isc_atomic.h.diff > > > > I haven't seen any verification from the OP that this patch solved the > > problem, > > It simply doesn't so apparently there's another bug in other parts of > BIND causing it to trip over that assertion. Still, the clobber lists > of the sparc64 atomic bits were incomplete and fixing that IMO was the > right thing to do. > MATPOCKuH, could you please test the following patch? http://people.freebsd.org/~marius/sparc64_isc_disable_atomic.diff That one simple disables the use of atomic operations for sparc64 as I doubt that these have seen much testing except on x86, be it on sparc64 or in general; given that they are also used for reference counting they should provide acquire and release semantics for that purpose which include the necessary memory barriers for these but the ISC atomic API simply doesn't account for that. Moreover, the sparc64 implementation of the ISC atomic operations is FreeBSD-specific as it's the only OS I'm aware of using the primary instead of the secondary MMU context for the userland (i.e. ASI_P; generally this is a wise choice though), i.e. don't work on the other *BSDs, Linux or Solaris. Marius ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: named crashes on assertion in rbtdb.c o? sparc64/SMP
On Tue, Jul 05, 2011 at 05:55:09PM -0700, Doug Barton wrote: > On 06/28/2011 08:58, Marius Strobl wrote: > >Uhm, we once fixed a problem in the MD atomic implementation which > >still seems to present in the ISC copy. Could you please test whether > >the following patch makes a difference? > >http://people.freebsd.org/~marius/sparc64_isc_atomic.h.diff > > I haven't seen any verification from the OP that this patch solved the > problem, It simply doesn't so apparently there's another bug in other parts of BIND causing it to trip over that assertion. Still, the clobber lists of the sparc64 atomic bits were incomplete and fixing that IMO was the right thing to do. > however it did pass 'make universe' on both 9-current and > RELENG_8, so I've committed it to those 2 branches along with the recent > update. I'll also submit it upstream. > Thanks! Marius ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: named crashes on assertion in rbtdb.c o? sparc64/SMP
On 06/28/2011 08:58, Marius Strobl wrote: Uhm, we once fixed a problem in the MD atomic implementation which still seems to present in the ISC copy. Could you please test whether the following patch makes a difference? http://people.freebsd.org/~marius/sparc64_isc_atomic.h.diff I haven't seen any verification from the OP that this patch solved the problem, however it did pass 'make universe' on both 9-current and RELENG_8, so I've committed it to those 2 branches along with the recent update. I'll also submit it upstream. Thanks, Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: named crashes on assertion in rbtdb.c o? sparc64/SMP
On Mon, Jun 27, 2011 at 07:19:33PM +0400, KOT MATPOCKuH wrote: > Hello! > > I'm got a problem with named on FreeBSD-CURRENT/sparc64. > Up to 5 times a day it crashes with these messages: > 27-Jun-2011 03:42:14.384 general: > /usr/src/lib/bind/dns/../../../contrib/bind9/lib/dns/rbtdb.c:1614: > REQUIRE(prev > 0) failed > 27-Jun-2011 03:42:14.385 general: exiting (due to assertion failure) > > The problem is still in latest system's bind: > # named -v > BIND 9.6.-ESV-R4-P1 > > This problem exists only on SMP sparc64 system. On my another sparc64, > with 1 processor, I does not have this problem. > > I found a some similar problems on alpha and IA64, which was related > to problems with isc_atomic_xadd() function in include/isc/atomic.h. > But I don't understand that there may be incorrect for sparc64 and > this function was not changed for a minimum 4 years... > > How can I help solve this problem? > Uhm, we once fixed a problem in the MD atomic implementation which still seems to present in the ISC copy. Could you please test whether the following patch makes a difference? http://people.freebsd.org/~marius/sparc64_isc_atomic.h.diff Marius ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
