Brooks Davis wrote this message on Mon, Oct 22, 2018 at 16:05 +:
> > + switch (len) {
> > + case (sizeof(struct oexport_args)):
> > + case (sizeof(struct o2export_args)):
> > + memset(, 0, sizeof(export));
>
> I
> On Oct 22, 2018, at 09:49, Josh Paetzel wrote:
>
>
>
>> On Mon, Oct 22, 2018, at 11:05 AM, Brooks Davis wrote:
>>
>>
>> This is the direction I'd been thinking. FWIW, the usecase is more that
>> once you've moved away from the struct it's easy to make incremental
>> changes then to use a
> Subject: Re: which way to update export_args structure?
>
> Brooks Davis wrote:
> On Sat, Oct 20, 2018 at 01:17:37AM +, Rick Macklem wrote:
> [lots of stuff snipped]
> >> + if (vfs_getopt(mp->mnt_optnew, "export", , ) == 0) {
> >>
From: owner-freebsd-curr...@freebsd.org on
behalf of Rick Macklem
Sent: Monday, October 22, 2018 5:24 PM
To: Brooks Davis
Cc: FreeBSD Current; Josh Paetzel
Subject: Re: which way to update export_args structure?
Brooks Davis wrote:
On Sat, Oct 20
Brooks Davis wrote:
On Sat, Oct 20, 2018 at 01:17:37AM +, Rick Macklem wrote:
[lots of stuff snipped]
>> + if (error == 0) {
>> + gotexp = 0;
>> + memset(, 0, sizeof(export));
>> + if (vfs_getopt(mp->mnt_optnew, "export.exflags", ,
>> + )
On Mon, Oct 22, 2018 at 11:49:23AM -0500, Josh Paetzel wrote:
>
>
> On Mon, Oct 22, 2018, at 11:05 AM, Brooks Davis wrote:
>
> >
> > This is the direction I'd been thinking. FWIW, the usecase is more that
> > once you've moved away from the struct it's easy to make incremental
> > changes
On Mon, Oct 22, 2018, at 11:05 AM, Brooks Davis wrote:
>
> This is the direction I'd been thinking. FWIW, the usecase is more that
> once you've moved away from the struct it's easy to make incremental
> changes then to use a 32-bit mountd on a 64-bit kernel. Moving toward
>
On Sat, Oct 20, 2018 at 01:17:37AM +, Rick Macklem wrote:
> Brooks Davis wrote:
> > Yes, I think that's the right way foward. Thanks for following up.
> >Rick Macklem wrote:
> >> Just in case you missed it in the email thread, in your general question
> >> below...
> >> Did you mean/suggest
Brooks Davis wrote:
> Yes, I think that's the right way foward. Thanks for following up.
>Rick Macklem wrote:
>> Just in case you missed it in the email thread, in your general question
>> below...
>> Did you mean/suggest that the fields of "struct export_args" be passed in as
>> separate
Brooks Davis wrote:
>On Wed, Oct 03, 2018 at 12:40:27AM +, Rick Macklem wrote:
>> Hi,
>>
>> I am working on updating "struct export_args" to fix/add a few things.
>> One of these is that "ex_flags" is an int, but the flags are defined in
>> mount.h
>> as MNT_xx bits that now exceed 32bits
On Wed, Oct 03, 2018 at 12:40:27AM +, Rick Macklem wrote:
> Hi,
>
> I am working on updating "struct export_args" to fix/add a few things.
> One of these is that "ex_flags" is an int, but the flags are defined in
> mount.h
> as MNT_xx bits that now exceed 32bits (mnt_flag is now uint64_t).
>
Gary Jennejohn wrote:
[stuff snipped]
>In B, shouldn't ex_flags become uint32_t if all 32 bits can contain
>flag bits?
You could. For B) my intent was to leave the structure exactly the same as the
old versions and only add new fields at the end. The current compatibility
code in head does
On Wed, 3 Oct 2018 00:40:27 +
Rick Macklem wrote:
> Hi,
>
> I am working on updating "struct export_args" to fix/add a few things.
> One of these is that "ex_flags" is an int, but the flags are defined in
> mount.h
> as MNT_xx bits that now exceed 32bits (mnt_flag is now uint64_t).
> For
I wrote:
>Hi,
>
>I am working on updating "struct export_args" to fix/add a few things.
>One of these is that "ex_flags" is an int, but the flags are defined in mount.h
>as MNT_xx bits that now exceed 32bits (mnt_flag is now uint64_t).
>For now, this doesn't break anything, since the flags used by
Hi,
I am working on updating "struct export_args" to fix/add a few things.
One of these is that "ex_flags" is an int, but the flags are defined in mount.h
as MNT_xx bits that now exceed 32bits (mnt_flag is now uint64_t).
For now, this doesn't break anything, since the flags used by ex_flags are
15 matches
Mail list logo
