Re: /sys/boot compile broken

2017-10-22 Thread Warner Losh
On Sun, Oct 22, 2017 at 10:53 AM, Gary Jennejohn 
wrote:

> On Sun, 22 Oct 2017 08:59:52 -0600
> Warner Losh  wrote:
>
> > On Sun, Oct 22, 2017 at 1:39 AM, Gary Jennejohn 
> > wrote:
> >
> > > On Sat, 21 Oct 2017 09:33:41 -0600
> > > Warner Losh  wrote:
> > >
> > > > On Oct 21, 2017 8:02 AM, "Allan Jude"  wrote:
> > > >
> > > > On 2017-10-21 02:41, Gary Jennejohn wrote:
> > > > > SVN for HEAD source at 324810.
> > > > >
> > > > > Compiling /sys/boot is totally screwed up.  The failure is that
> > > > > geliboot.c cannot be found.
> > > > >
> > > > > This prevents a successful ``make buildworld''.
> > > > >
> > > > > This error occurs despite the fact that I have
> LOADER_NO_GELI_SUPPORT
> > > > > set to yes in src.conf.
> > > > >
> > > > > Looking at the various Makefiles this option is supposed to prevent
> > > > > using GELI.
> > > > >
> > > > > Even if the user wanted to use GELI the compile of the boot code
> > > > > would probably fail.
> > > > >
> > > > > imp@ has had his fingers in the boot code lately.
> > > > >
> > > >
> > > > Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no
> > > >
> > > > And so you ended up with some code not guarded. Add the additional
> > > > src.conf knob for now, and Warner will get it fixed up
> > > >
> > > >
> > > > I fly back from legoland today and will touch this up. I'm in the
> process
> > > > of changing them into real config knobs from the weird things that
> have
> > > > leaked out... sys/boot is likely moving my up to boot as well in the
> near
> > > > future.
> > > >
> > >
> > > Thanks for the info.
> > >
> > > I see that this change was made fairly late in my time zone.
> >
> >
> > mine too :) I was going to reply to this thread, but it was too late...
> >
> > Please let me know if it works for you. I was able to do builds both
> ways.
> >
>
> It worked.  It was good to see that you put an entry in UPDATING.
>

People noticing was a good clue I'd been remiss in the initial round of
commits.

Warner
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: /sys/boot compile broken

2017-10-22 Thread Gary Jennejohn
On Sun, 22 Oct 2017 08:59:52 -0600
Warner Losh  wrote:

> On Sun, Oct 22, 2017 at 1:39 AM, Gary Jennejohn 
> wrote:
> 
> > On Sat, 21 Oct 2017 09:33:41 -0600
> > Warner Losh  wrote:
> >  
> > > On Oct 21, 2017 8:02 AM, "Allan Jude"  wrote:
> > >
> > > On 2017-10-21 02:41, Gary Jennejohn wrote:  
> > > > SVN for HEAD source at 324810.
> > > >
> > > > Compiling /sys/boot is totally screwed up.  The failure is that
> > > > geliboot.c cannot be found.
> > > >
> > > > This prevents a successful ``make buildworld''.
> > > >
> > > > This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
> > > > set to yes in src.conf.
> > > >
> > > > Looking at the various Makefiles this option is supposed to prevent
> > > > using GELI.
> > > >
> > > > Even if the user wanted to use GELI the compile of the boot code
> > > > would probably fail.
> > > >
> > > > imp@ has had his fingers in the boot code lately.
> > > >  
> > >
> > > Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no
> > >
> > > And so you ended up with some code not guarded. Add the additional
> > > src.conf knob for now, and Warner will get it fixed up
> > >
> > >
> > > I fly back from legoland today and will touch this up. I'm in the process
> > > of changing them into real config knobs from the weird things that have
> > > leaked out... sys/boot is likely moving my up to boot as well in the near
> > > future.
> > >  
> >
> > Thanks for the info.
> >
> > I see that this change was made fairly late in my time zone.  
> 
> 
> mine too :) I was going to reply to this thread, but it was too late...
> 
> Please let me know if it works for you. I was able to do builds both ways.
> 

It worked.  It was good to see that you put an entry in UPDATING.

-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: /sys/boot compile broken

2017-10-22 Thread Warner Losh
On Sun, Oct 22, 2017 at 1:39 AM, Gary Jennejohn 
wrote:

> On Sat, 21 Oct 2017 09:33:41 -0600
> Warner Losh  wrote:
>
> > On Oct 21, 2017 8:02 AM, "Allan Jude"  wrote:
> >
> > On 2017-10-21 02:41, Gary Jennejohn wrote:
> > > SVN for HEAD source at 324810.
> > >
> > > Compiling /sys/boot is totally screwed up.  The failure is that
> > > geliboot.c cannot be found.
> > >
> > > This prevents a successful ``make buildworld''.
> > >
> > > This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
> > > set to yes in src.conf.
> > >
> > > Looking at the various Makefiles this option is supposed to prevent
> > > using GELI.
> > >
> > > Even if the user wanted to use GELI the compile of the boot code
> > > would probably fail.
> > >
> > > imp@ has had his fingers in the boot code lately.
> > >
> >
> > Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no
> >
> > And so you ended up with some code not guarded. Add the additional
> > src.conf knob for now, and Warner will get it fixed up
> >
> >
> > I fly back from legoland today and will touch this up. I'm in the process
> > of changing them into real config knobs from the weird things that have
> > leaked out... sys/boot is likely moving my up to boot as well in the near
> > future.
> >
>
> Thanks for the info.
>
> I see that this change was made fairly late in my time zone.


mine too :) I was going to reply to this thread, but it was too late...

Please let me know if it works for you. I was able to do builds both ways.

Warner
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: /sys/boot compile broken

2017-10-22 Thread Gary Jennejohn
On Sat, 21 Oct 2017 09:33:41 -0600
Warner Losh  wrote:

> On Oct 21, 2017 8:02 AM, "Allan Jude"  wrote:
> 
> On 2017-10-21 02:41, Gary Jennejohn wrote:
> > SVN for HEAD source at 324810.
> >
> > Compiling /sys/boot is totally screwed up.  The failure is that
> > geliboot.c cannot be found.
> >
> > This prevents a successful ``make buildworld''.
> >
> > This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
> > set to yes in src.conf.
> >
> > Looking at the various Makefiles this option is supposed to prevent
> > using GELI.
> >
> > Even if the user wanted to use GELI the compile of the boot code
> > would probably fail.
> >
> > imp@ has had his fingers in the boot code lately.
> >  
> 
> Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no
> 
> And so you ended up with some code not guarded. Add the additional
> src.conf knob for now, and Warner will get it fixed up
> 
> 
> I fly back from legoland today and will touch this up. I'm in the process
> of changing them into real config knobs from the weird things that have
> leaked out... sys/boot is likely moving my up to boot as well in the near
> future.
> 

Thanks for the info.

I see that this change was made fairly late in my time zone.

-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: /sys/boot compile broken

2017-10-21 Thread Warner Losh
On Oct 21, 2017 8:02 AM, "Allan Jude"  wrote:

On 2017-10-21 02:41, Gary Jennejohn wrote:
> SVN for HEAD source at 324810.
>
> Compiling /sys/boot is totally screwed up.  The failure is that
> geliboot.c cannot be found.
>
> This prevents a successful ``make buildworld''.
>
> This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
> set to yes in src.conf.
>
> Looking at the various Makefiles this option is supposed to prevent
> using GELI.
>
> Even if the user wanted to use GELI the compile of the boot code
> would probably fail.
>
> imp@ has had his fingers in the boot code lately.
>

Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no

And so you ended up with some code not guarded. Add the additional
src.conf knob for now, and Warner will get it fixed up


I fly back from legoland today and will touch this up. I'm in the process
of changing them into real config knobs from the weird things that have
leaked out... sys/boot is likely moving my up to boot as well in the near
future.

Warner
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: /sys/boot compile broken

2017-10-21 Thread Allan Jude
On 2017-10-21 02:41, Gary Jennejohn wrote:
> SVN for HEAD source at 324810.
> 
> Compiling /sys/boot is totally screwed up.  The failure is that
> geliboot.c cannot be found.
> 
> This prevents a successful ``make buildworld''.
> 
> This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
> set to yes in src.conf.
> 
> Looking at the various Makefiles this option is supposed to prevent
> using GELI.
> 
> Even if the user wanted to use GELI the compile of the boot code
> would probably fail.
> 
> imp@ has had his fingers in the boot code lately.
> 

Some of the boot code has been changed over to LOADER_GELI_SUPPORT=no

And so you ended up with some code not guarded. Add the additional
src.conf knob for now, and Warner will get it fixed up shortly.

-- 
Allan Jude



signature.asc
Description: OpenPGP digital signature


Re: /sys/boot compile broken

2017-10-21 Thread David Wolfskill
On Sat, Oct 21, 2017 at 08:41:04AM +0200, Gary Jennejohn wrote:
> SVN for HEAD source at 324810.
> 
> Compiling /sys/boot is totally screwed up.  The failure is that
> geliboot.c cannot be found.
> 
> This prevents a successful ``make buildworld''.

I did not encounter this issue in my upgrade from:

FreeBSD g1-252.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #437  
r324795M/324801:1200051: Fri Oct 20 04:36:06 PDT 2017 
r...@g1-252.catwhisker.org:/common/S4/obj/usr/src/sys/CANARY  amd64

to:

FreeBSD g1-252.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #438  
r324811M/324812:1200051: Sat Oct 21 04:44:50 PDT 2017 
r...@g1-252.catwhisker.org:/common/S4/obj/usr/src/sys/CANARY  amd64

Granted, that was to r324811, not r3248110, but r324811 was for sys/dev/pms.

>... 

> imp@ has had his fingers in the boot code lately.

He has, yes -- mostly (IIRC, from discussions at work) in support
of UEFI booting.

> ...

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Unsubstantiated claims of "Fake News" are evidence that the claimant lies again.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature


/sys/boot compile broken

2017-10-20 Thread Gary Jennejohn
SVN for HEAD source at 324810.

Compiling /sys/boot is totally screwed up.  The failure is that
geliboot.c cannot be found.

This prevents a successful ``make buildworld''.

This error occurs despite the fact that I have LOADER_NO_GELI_SUPPORT
set to yes in src.conf.

Looking at the various Makefiles this option is supposed to prevent
using GELI.

Even if the user wanted to use GELI the compile of the boot code
would probably fail.

imp@ has had his fingers in the boot code lately.

-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"