Yes, that seems to fix it, although I had a spontaneous system lockup while I was running with this patch. I have no idea wether the lockup was connected to that patch; I am running that code again right now and it does not lockup.
Many thanks to Munehiro and Takanori. Maybe someone else with a VMWare license could retest and then commit it? -- Regards, Georg. At Sun, 10 Feb 2002 03:01:57 +0900, Takanori Saneto wrote: > > Re: "Re: /dev/rtc not configured message when starting VMWare2 on -current" > In article <[EMAIL PROTECTED]>, > Munehiro Matsuda <[EMAIL PROTECTED]> wrote: > >I have a hack^Wpatch that should fix your problem. > > I think you need to prevent returning the value of uninitialized > variable (``error'') when no error should be returned. > > How about following patch? (just added "error = 0;" line) > > Index: rtc.c > =================================================================== > RCS file: /export/cvsup/cvs/ports/emulators/rtc/files/rtc.c,v > retrieving revision 1.6 > diff -u -r1.6 rtc.c > --- rtc.c 16 Sep 2001 07:05:18 -0000 1.6 > +++ rtc.c 9 Feb 2002 17:54:44 -0000 > @@ -266,10 +266,32 @@ > { > int error; > > +#if __FreeBSD_version >= 500023 > +dev_t dev; > +struct rtc_softc *sc; > + > + if (rtc_sc!=NULL) > + return (EINVAL); > + > + dev = make_dev(&rtc_cdevsw, 0, UID_ROOT, GID_WHEEL, 0644, DEVICE_NAME); > + if (dev==NULL) > + return (EINVAL); > + > + MALLOC(sc, struct rtc_softc*, sizeof(*sc), M_DEVBUF, M_WAITOK); > + if (sc==NULL) > + return (EINVAL); > + > + bzero(sc, sizeof(*sc)); > + rtc_sc = sc; > + dev->si_drv1 = sc; /* Link together */ > + sc->dev = dev; > + error = 0; > +#else > error = cdevsw_add(&rtc_cdevsw); > if (error) > return error; > > +#endif > return error; > } > > > -- > $B$5$M$r(B (SANETO Takanori) // [$B<qL#(B] $BK\6H$r$9$k$3$H(B // > $B!&!&!&!&!&!&!&!&!&!&!&!&!&!&!&!&!&(B // Bonjour Chapeau // > <URL:mailto:[EMAIL PROTECTED]> // [$BK\6H(B] $B<qL#$KAv$k$3$H(B // > > To Unsubscribe: send mail to [EMAIL PROTECTED] > with "unsubscribe freebsd-current" in the body of the message > > To Unsubscribe: send mail to [EMAIL PROTECTED] > with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
