On Mon, Oct 11, 2010 at 07:19:14PM -0700, David O'Brien wrote:
At $WORK we hit a bug where ${var%/*} was not producing the correct
expansion. There are two patches to fix this. I prefer the first
as I feel it is cleaner from an API perspective. I've also added
a regression testcase that
On Wed, Oct 13, 2010 at 11:42:48PM +0200, Jilles Tjoelker wrote:
Style bug:
+growstrstackblock(int n) {
The opening brace should be on its own line.
Indeed. I'm surprised I did that. Thank you for catching it.
Your test is too fragile: it often fails to detect the bug. Calling like
sh
At $WORK we hit a bug where ${var%/*} was not producing the correct
expansion. There are two patches to fix this. I prefer the first
as I feel it is cleaner from an API perspective. I've also added
a regression testcase that shows the problem.
Thoughts?
--
-- David (obr...@freebsd.org)
