Re: 5.2-BETA dsp.c duplicate lock

2003-12-02 Thread Jesse Guardiani
Maxime Henrion wrote: Mathew Kanner wrote: [patch ripped] Maxime, I think it would be better to isolate the changes (DUP_OK flag and lock creation) to just the channel code, no need to touch every driver. Yes, but to do this I'd need either to make the channel code use mtx_init()

Re: 5.2-BETA dsp.c duplicate lock

2003-12-02 Thread Mathew Kanner
On Dec 01, Maxime Henrion wrote: Mathew Kanner wrote: [patch ripped] Maxime, I think it would be better to isolate the changes (DUP_OK flag and lock creation) to just the channel code, no need to touch every driver. Yes, but to do this I'd need either to make the channel

Re: 5.2-BETA dsp.c duplicate lock

2003-12-02 Thread Mathew Kanner
On Dec 02, Mathew Kanner wrote: On Dec 01, Maxime Henrion wrote: [snip] I believe that your patch should fix the problem. In general I see one of three strategies, 1)Your patch, 2)create a new snd_mtxcreate_chan for channels that sets the flags DUP_OK. 3)Fix locking to

Re: 5.2-BETA dsp.c duplicate lock

2003-12-01 Thread Jesse Guardiani
Jesse Guardiani wrote: I get this every time I `startx`. I didn't see it in the archive either: acquiring duplicate lock of same type: pcm channel 1st pcm0:record:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:144 2nd pcm0:virtual:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:146 Stack backtrace:

Re: 5.2-BETA dsp.c duplicate lock

2003-12-01 Thread Maxime Henrion
Jesse Guardiani wrote: Jesse Guardiani wrote: I get this every time I `startx`. I didn't see it in the archive either: acquiring duplicate lock of same type: pcm channel 1st pcm0:record:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:144 2nd pcm0:virtual:0 @

Re: 5.2-BETA dsp.c duplicate lock

2003-12-01 Thread Mathew Kanner
On Dec 01, Maxime Henrion wrote: Jesse Guardiani wrote: Jesse Guardiani wrote: Index: isa/ad1816.c === RCS file: /space2/ncvs/src/sys/dev/sound/isa/ad1816.c,v retrieving revision 1.29 diff -u -p -r1.29 ad1816.c ---

Re: 5.2-BETA dsp.c duplicate lock

2003-12-01 Thread Maxime Henrion
Mathew Kanner wrote: [patch ripped] Maxime, I think it would be better to isolate the changes (DUP_OK flag and lock creation) to just the channel code, no need to touch every driver. Yes, but to do this I'd need either to make the channel code use mtx_init() directly, which

5.2-BETA dsp.c duplicate lock

2003-11-27 Thread Jesse Guardiani
I get this every time I `startx`. I didn't see it in the archive either: acquiring duplicate lock of same type: pcm channel 1st pcm0:record:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:144 2nd pcm0:virtual:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:146 Stack backtrace: