Re: ACPI Error: No handler for Region [ECOR]
In message <10399.1543270...@critter.freebsd.dk>, "Poul-Henning Kamp" writes: >>I'm seeing it on my ThinkPad x230 as well > >and on T480 running 13.0-CURRENT r340932M as well: And seems to be gone with this kernel: 13.0-CURRENT r341006M Havn't tried the ones in between. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 26/11/18 19:59, Yuri Pankov wrote: > Renato Botelho wrote: >> On 26/11/18 19:32, Florian Limberger wrote: >>> Hi, >>> >>> On 20.11.18 14:46, Charlie Li wrote: >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] >>>> (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >>>> (ID=3) has no handler (20181031/exfldio-428) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >>>> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) >>> >>> On my Thinkpad T410 I get exactly the same error, but it prevents the >>> ACPI poweroff. Instead following lines are printed: >> >> I'm seeing it on my ThinkPad x230 as well > > Looks like r340993 should be the fix? > If fixed it to me. Thanks! -- Renato Botelho signature.asc Description: OpenPGP digital signature
Re: ACPI Error: No handler for Region [ECOR]
Renato Botelho wrote: > On 26/11/18 19:32, Florian Limberger wrote: >> Hi, >> >> On 20.11.18 14:46, Charlie Li wrote: >>> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] >>> (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) >>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >>> (ID=3) has no handler (20181031/exfldio-428) >>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >>> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) >> >> On my Thinkpad T410 I get exactly the same error, but it prevents the >> ACPI poweroff. Instead following lines are printed: > > I'm seeing it on my ThinkPad x230 as well Looks like r340993 should be the fix? signature.asc Description: OpenPGP digital signature
Re: ACPI Error: No handler for Region [ECOR]
On 26/11/18 19:32, Florian Limberger wrote: > Hi, > > On 20.11.18 14:46, Charlie Li wrote: >> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] >> (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) >> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >> (ID=3) has no handler (20181031/exfldio-428) >> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) > > On my Thinkpad T410 I get exactly the same error, but it prevents the > ACPI poweroff. Instead following lines are printed: I'm seeing it on my ThinkPad x230 as well -- Renato Botelho ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
ACPI Error: No handler for Region [ECOR]
Hi, On 20.11.18 14:46, Charlie Li wrote: > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] > (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl > (ID=3) has no handler (20181031/exfldio-428) > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) On my Thinkpad T410 I get exactly the same error, but it prevents the ACPI poweroff. Instead following lines are printed: > The operating system has halted. > Please press any key to reboot. Additional info on my system: $ uname -a FreeBSD hostname 13.0-CURRENT FreeBSD 13.0-CURRENT #6 r340926: Mon Nov 26 00:19:49 CET 2018 root@hostname:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64 $ sysctl dev.acpi_ec dev.acpi_ec.0.%parent: acpi0 dev.acpi_ec.0.%pnpinfo: _HID=PNP0C09 _UID=0 dev.acpi_ec.0.%location: handle=\_SB_.PCI0.LPC_.EC__ dev.acpi_ec.0.%driver: acpi_ec dev.acpi_ec.0.%desc: Embedded Controller: GPE 0x11, ECDT dev.acpi_ec.%parent: Regards, flo ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 18-11-23 13:05:00, Charlie Li wrote: > On 23/11/2018 00:02, Ben Widawsky wrote: > > Thanks both of you. Here's another shot at roughly the same thing I asked > > the > > first reporter to try (that patch was wrong). If it doesn't work, can you > > please > > post the dmesg? > > > This patch works on my machine as well. > Thanks all. Here is the differential in phabricator: https://reviews.freebsd.org/D18311 > -- > Charlie Li > Can't think of a witty .sigline today… > > (This email address is for mailing list use only; replace local-part > with vishwin for off-list communication) > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 23/11/2018 00:02, Ben Widawsky wrote: > Thanks both of you. Here's another shot at roughly the same thing I asked the > first reporter to try (that patch was wrong). If it doesn't work, can you > please > post the dmesg? > This patch works on my machine as well. -- Charlie Li Can't think of a witty .sigline today… (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) signature.asc Description: OpenPGP digital signature
Re: ACPI Error: No handler for Region [ECOR]
On 18-11-23 16:42:22, Mateusz Piotrowski wrote: > On Tue, 20 Nov 2018 at 15:47, Charlie Li wrote: > > > Somewhere between r340491 and r340650, probably starting from r340595, > > my ThinkPad W550s started spewing these messages repeatedly in the > > system log since boot: > > > > ... > > > > As a result, I am now unable to query battery information at the very > > least. r340490 is my last built revision with this working. > > > > There's a bug report for a similar issue after r330957: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191 This is unrelated. The issue in this thread has to do with a regression I introduced when an ECDT, and an EC device is present (not uncommon). I am going to post a review momentarily for this. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On Tue, 20 Nov 2018 at 15:47, Charlie Li wrote: > Somewhere between r340491 and r340650, probably starting from r340595, > my ThinkPad W550s started spewing these messages repeatedly in the > system log since boot: > > ... > > As a result, I am now unable to query battery information at the very > least. r340490 is my last built revision with this working. > There's a bug report for a similar issue after r330957: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227191 ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
With your patch applied, normal behavior seems back again. "dmesg" output and other relevent files are availabe at: http://imp.ovh/acpi > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
Hi all, "patch -p 1 < your_patch" gives me the following *.rej file: @@ -362,7 +362,8 @@ ret = 0; goto out; -} +} else + ecdt = 0; ret = ACPI_ID_PROBE(device_get_parent(dev), dev, ec_ids, NULL); if (ret > 0) @@ -422,16 +434,6 @@ /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); -/* - * Check for a duplicate probe. This can happen when a probe via ECDT - * succeeded already. If this is a duplicate, disable this device. - */ -peer = devclass_get_device(acpi_ec_devclass, params->uid); -if (peer == NULL || !device_is_alive(peer)) - ret = 0; -else - device_disable(dev); - if (buf.Pointer) AcpiOsFree(buf.Pointer); out: Reject of hunk 1 and hunk 3 may be due to indentation. Anyway, I manually patched these two parts and I am now waiting for kernel build. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
Thanks both of you. Here's another shot at roughly the same thing I asked the
first reporter to try (that patch was wrong). If it doesn't work, can you please
post the dmesg?
diff --git a/sys/dev/acpica/acpi_ec.c b/sys/dev/acpica/acpi_ec.c
index a21dbc963af..666aba2b3c8 100644
--- a/sys/dev/acpica/acpi_ec.c
+++ b/sys/dev/acpica/acpi_ec.c
@@ -362,7 +362,8 @@ acpi_ec_probe(device_t dev)
ret = 0;
goto out;
-}
+} else
+ ecdt = 0;
ret = ACPI_ID_PROBE(device_get_parent(dev), dev, ec_ids, NULL);
if (ret > 0)
@@ -382,6 +383,17 @@ acpi_ec_probe(device_t dev)
if (ACPI_FAILURE(status))
params->uid = 0;
+/*
+ * Check for a duplicate probe. This can happen when a probe via ECDT
+ * succeeded already. If this is a duplicate, disable this device.
+ */
+peer = devclass_get_device(acpi_ec_devclass, params->uid);
+if (peer && device_is_alive(peer)) {
+ device_disable(dev);
+ ret = ENXIO;
+ goto out;
+}
+
status = acpi_GetInteger(h, "_GLK", >glk);
if (ACPI_FAILURE(status))
params->glk = 0;
@@ -422,16 +434,6 @@ acpi_ec_probe(device_t dev)
/* Store the values we got from the namespace for attach. */
acpi_set_private(dev, params);
-/*
- * Check for a duplicate probe. This can happen when a probe via ECDT
- * succeeded already. If this is a duplicate, disable this device.
- */
-peer = devclass_get_device(acpi_ec_devclass, params->uid);
-if (peer == NULL || !device_is_alive(peer))
- ret = 0;
-else
- device_disable(dev);
-
if (buf.Pointer)
AcpiOsFree(buf.Pointer);
out:
On 18-11-21 17:08:15, Samy Mahmoudi wrote:
> Hi again,
>
> Please find the requested files:
>
> http://imp.ovh/18.2.0/acpidump_-dt_output
> http://imp.ovh/18.2.0/acpi_ec_values
> http://imp.ovh/18.2.0/dmesg_output
>
> Best regards,
> Samy
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 21/11/2018 11:21, Charlie Li wrote: > On 20/11/2018 14:37, Ben Widawsky wrote: >> On 18-11-20 11:28:56, Ben Widawsky wrote: >>> On 18-11-20 14:09:08, Jung-uk Kim wrote: I am pretty sure r340644 caused the regression. >>> >>> Seems like a good bet. Could you please add the full dmesg as well as an >>> ACPI >>> dump and the output of `sysctl dev.acpi_ec.` Thanks. > Going to try backing out r340644 in my tree. > This revision is indeed the culprit. No more log spam and battery info querying works after backing out. -- Charlie Li Can't think of a witty .sigline today… (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) signature.asc Description: OpenPGP digital signature
Re: ACPI Error: No handler for Region [ECOR]
On 20/11/2018 14:37, Ben Widawsky wrote: > On 18-11-20 11:28:56, Ben Widawsky wrote: >> On 18-11-20 14:09:08, Jung-uk Kim wrote: >>> On 18. 11. 20., Charlie Li wrote: >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] >>>> (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >>>> (ID=3) has no handler (20181031/exfldio-428) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >>>> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) >>>> >>> I am pretty sure r340644 caused the regression. >>> >>> https://svnweb.freebsd.org/changeset/base/340644 >>> >>> Jung-uk Kim >> >> Seems like a good bet. Could you please add the full dmesg as well as an ACPI >> dump and the output of `sysctl dev.acpi_ec.` Thanks. The full dmesg is flooded. sysctl dev.acpi_ec: dev.acpi_ec.0.%parent: acpi0 dev.acpi_ec.0.%pnpinfo: _HID=PNP0C09 _UID=0 dev.acpi_ec.0.%location: handle=\_SB_.PCI0.LPC_.EC__ dev.acpi_ec.0.%driver: acpi_ec dev.acpi_ec.0.%desc: Embedded Controller: GPE 0x25, ECDT dev.acpi_ec.%parent: > > Just for a quick eyeball, this looks suspicious. You could also try this: > I had to remove another line due to -Wunused-variable. In any case, the log spam continues unabated and battery status querying continues to fail. Going to try backing out r340644 in my tree. -- Charlie Li Can't think of a witty .sigline today… (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) diff -r 531cf2dab058 sys/dev/acpica/acpi_ec.c --- a/sys/dev/acpica/acpi_ec.c Mon Nov 19 17:31:36 2018 -0500 +++ b/sys/dev/acpica/acpi_ec.c Wed Nov 21 10:52:58 2018 -0500 @@ -338,7 +338,6 @@ ACPI_HANDLE h; ACPI_OBJECT *obj; ACPI_STATUS status; -device_t peer; char desc[64]; int ecdt; int ret; @@ -422,6 +421,7 @@ /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); +#if 0 /* * Check for a duplicate probe. This can happen when a probe via ECDT * succeeded already. If this is a duplicate, disable this device. @@ -431,6 +431,7 @@ ret = 0; else device_disable(dev); +#endif if (buf.Pointer) AcpiOsFree(buf.Pointer); signature.asc Description: OpenPGP digital signature
Re: ACPI Error: No handler for Region [ECOR]
Hi again, Please find the requested files: http://imp.ovh/18.2.0/acpidump_-dt_output http://imp.ovh/18.2.0/acpi_ec_values http://imp.ovh/18.2.0/dmesg_output Best regards, Samy > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
Same problem/output as Charlie Li, with a Lenovo T520. I will post requested output files as soon as possible. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
Hi, I have the same problem as Charlie Li. In case it could help you address this I put up the data you requested in a gist: https://gist.github.com/rebost/f8f231662a7501b14d63f348ee5e4ca2 you can also download it as a zip file: https://gist.github.com/rebost/f8f231662a7501b14d63f348ee5e4ca2/archive/6af9d446aaef167fc8c72c56f1cae9f7be1fff97.zip # uname -a FreeBSD lenovo01.x.xx 13.0-CURRENT FreeBSD 13.0-CURRENT r340703+73a91fe29c4(svn_head) GENERIC-NODEBUG amd64 # sysctl dev.acpi_ec dev.acpi_ec.0.%parent: acpi0 dev.acpi_ec.0.%pnpinfo: _HID=PNP0C09 _UID=0 dev.acpi_ec.0.%location: handle=\_SB_.PCI0.LPCB.EC__ dev.acpi_ec.0.%driver: acpi_ec dev.acpi_ec.0.%desc: Embedded Controller: GPE 0x16, ECDT dev.acpi_ec.%parent: Best, -- matías ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 18-11-20 11:28:56, Ben Widawsky wrote: > On 18-11-20 14:09:08, Jung-uk Kim wrote: > > On 18. 11. 20., Charlie Li wrote: > > > Somewhere between r340491 and r340650, probably starting from r340595, > > > my ThinkPad W550s started spewing these messages repeatedly in the > > > system log since boot: > > > > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] > > > (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl > > > (ID=3) has no handler (20181031/exfldio-428) > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution > > > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) > > > > > > As a result, I am now unable to query battery information at the very > > > least. r340490 is my last built revision with this working. > > > > I am pretty sure r340644 caused the regression. > > > > https://svnweb.freebsd.org/changeset/base/340644 > > > > Jung-uk Kim > > Seems like a good bet. Could you please add the full dmesg as well as an ACPI > dump and the output of `sysctl dev.acpi_ec.` Thanks. Just for a quick eyeball, this looks suspicious. You could also try this: diff --git a/sys/dev/acpica/acpi_ec.c b/sys/dev/acpica/acpi_ec.c index a21dbc963af..5d6dba6a887 100644 --- a/sys/dev/acpica/acpi_ec.c +++ b/sys/dev/acpica/acpi_ec.c @@ -422,6 +422,7 @@ acpi_ec_probe(device_t dev) /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); +#if 0 /* * Check for a duplicate probe. This can happen when a probe via ECDT * succeeded already. If this is a duplicate, disable this device. @@ -431,6 +432,7 @@ acpi_ec_probe(device_t dev) ret = 0; else device_disable(dev); +#endif if (buf.Pointer) AcpiOsFree(buf.Pointer); -- Ben Widawsky, Intel Open Source Technology Center ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 18-11-20 14:09:08, Jung-uk Kim wrote: > On 18. 11. 20., Charlie Li wrote: > > Somewhere between r340491 and r340650, probably starting from r340595, > > my ThinkPad W550s started spewing these messages repeatedly in the > > system log since boot: > > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] > > (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl > > (ID=3) has no handler (20181031/exfldio-428) > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution > > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) > > > > As a result, I am now unable to query battery information at the very > > least. r340490 is my last built revision with this working. > > I am pretty sure r340644 caused the regression. > > https://svnweb.freebsd.org/changeset/base/340644 > > Jung-uk Kim Seems like a good bet. Could you please add the full dmesg as well as an ACPI dump and the output of `sysctl dev.acpi_ec.` Thanks. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: ACPI Error: No handler for Region [ECOR]
On 18. 11. 20., Charlie Li wrote: > Somewhere between r340491 and r340650, probably starting from r340595, > my ThinkPad W550s started spewing these messages repeatedly in the > system log since boot: > > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] > (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl > (ID=3) has no handler (20181031/exfldio-428) > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) > > As a result, I am now unable to query battery information at the very > least. r340490 is my last built revision with this working. I am pretty sure r340644 caused the regression. https://svnweb.freebsd.org/changeset/base/340644 Jung-uk Kim ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
ACPI Error: No handler for Region [ECOR]
Somewhere between r340491 and r340650, probably starting from r340595, my ThinkPad W550s started spewing these messages repeatedly in the system log since boot: Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] (0xf80003662300) [EmbeddedControl] (20181031/evregion-288) Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl (ID=3) has no handler (20181031/exfldio-428) Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) As a result, I am now unable to query battery information at the very least. r340490 is my last built revision with this working. -- Charlie Li Can't think of a witty .sigline today… (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) signature.asc Description: OpenPGP digital signature
