Re: CAM Shingled Disk support patches available

2016-03-02 Thread Scott Long
> On Mar 2, 2016, at 2:25 PM, Kenneth D. Merry wrote: > >> >> >> void scsi_ata_pass(struct ccb_scsiio *csio, u_int32_t retries, >> void (*cbfcnp)(struct cam_periph *, union ccb *), >> u_int32_t flags, u_int8_t tag_action, >>

Re: CAM Shingled Disk support patches available

2016-03-02 Thread Kenneth D. Merry
On Tue, Mar 01, 2016 at 20:07:19 -0700, Scott Long wrote: > Hi Ken, > > I???m against changing the function signature of scsi_ata_pass_16(). Even > if you manage to get things right with symbol versioning, it still leads to > problems of code compatibility. Maybe pre-existing binaries will

Re: CAM Shingled Disk support patches available

2016-03-02 Thread Douglas Gilbert
On 16-03-01 10:07 PM, Scott Long via freebsd-scsi wrote: Hi Ken, I’m against changing the function signature of scsi_ata_pass_16(). Even if you manage to get things right with symbol versioning, it still leads to problems of code compatibility. Maybe pre-existing binaries will work, but

Re: CAM Shingled Disk support patches available

2016-03-01 Thread Scott Long
Hi Ken, I’m against changing the function signature of scsi_ata_pass_16(). Even if you manage to get things right with symbol versioning, it still leads to problems of code compatibility. Maybe pre-existing binaries will work, but source code will forever have to include an #if

Re: CAM Shingled Disk support patches available

2016-03-01 Thread Kenneth D. Merry
I have a new set of SMR patches available. (See the original message below for a more detailed description of what these patches do.) The primary change is to add library versioning to libcam so that we can change the function prototype of scsi_ata_pass_16() in a way that won't break existing

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Slawa Olhovchenkov
On Mon, Jan 18, 2016 at 05:37:04PM -0500, Kenneth D. Merry wrote: > I have a new set of SMR patches available. See below for the full > explanation. > > The primary change here is that I have added SMR support to the ada(4) > driver. I spent some time considering whether to try to make the

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Scott Long
> On Jan 19, 2016, at 8:25 AM, Kenneth D. Merry wrote: > > >>> In the ada(4) case, we need to add the register to struct ccb_ataio and >>> add support in one or more of the underlying SATA drivers, e.g. ahci(4). >> >> I believe that changes the size of the CCB, so I tried to

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Slawa Olhovchenkov
On Tue, Jan 19, 2016 at 12:06:41PM -0500, Kenneth D. Merry wrote: > On Tue, Jan 19, 2016 at 20:02:52 +0300, Slawa Olhovchenkov wrote: > > On Tue, Jan 19, 2016 at 11:38:31AM -0500, Kenneth D. Merry wrote: > > > > > On Tue, Jan 19, 2016 at 14:45:23 +0300, Slawa Olhovchenkov wrote: > > > > On Mon,

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Kenneth D. Merry
On Mon, Jan 18, 2016 at 16:50:34 -0800, Warner Losh wrote: > > > On Jan 18, 2016, at 2:37 PM, Kenneth D. Merry wrote: > > > > I have a new set of SMR patches available. See below for the full > > explanation. > > > > The primary change here is that I have added SMR support

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Kenneth D. Merry
On Tue, Jan 19, 2016 at 14:45:23 +0300, Slawa Olhovchenkov wrote: > On Mon, Jan 18, 2016 at 05:37:04PM -0500, Kenneth D. Merry wrote: > > > I have a new set of SMR patches available. See below for the full > > explanation. > > > > The primary change here is that I have added SMR support to the

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Slawa Olhovchenkov
On Tue, Jan 19, 2016 at 11:38:31AM -0500, Kenneth D. Merry wrote: > On Tue, Jan 19, 2016 at 14:45:23 +0300, Slawa Olhovchenkov wrote: > > On Mon, Jan 18, 2016 at 05:37:04PM -0500, Kenneth D. Merry wrote: > > > > > I have a new set of SMR patches available. See below for the full > > >

Re: CAM Shingled Disk support patches available

2016-01-19 Thread Kenneth D. Merry
On Tue, Jan 19, 2016 at 20:02:52 +0300, Slawa Olhovchenkov wrote: > On Tue, Jan 19, 2016 at 11:38:31AM -0500, Kenneth D. Merry wrote: > > > On Tue, Jan 19, 2016 at 14:45:23 +0300, Slawa Olhovchenkov wrote: > > > On Mon, Jan 18, 2016 at 05:37:04PM -0500, Kenneth D. Merry wrote: > > > > > > > I

Re: CAM Shingled Disk support patches available

2016-01-18 Thread Warner Losh
> On Jan 18, 2016, at 2:37 PM, Kenneth D. Merry wrote: > > I have a new set of SMR patches available. See below for the full > explanation. > > The primary change here is that I have added SMR support to the ada(4) > driver. I spent some time considering whether to try to

Re: CAM Shingled Disk support patches available

2016-01-18 Thread Kenneth D. Merry
I have a new set of SMR patches available. See below for the full explanation. The primary change here is that I have added SMR support to the ada(4) driver. I spent some time considering whether to try to make the da(4) and ada(4) probe infrastructure somewhat common, but in the end concluded

Re: CAM Shingled Disk support patches available

2015-11-20 Thread Don Lewis
On 19 Nov, Kenneth D. Merry wrote: > On Thu, Nov 19, 2015 at 12:48:41 -0600, Matthew D. Fuller wrote: >> On Wed, Nov 18, 2015 at 12:13:09PM -0500 I heard the voice of >> Kenneth D. Merry, and lo! it spake thus: >> > >> > Testing and comments are welcome. >> >> GELI does explicit handling of each

Re: CAM Shingled Disk support patches available

2015-11-19 Thread Matthew D. Fuller
On Wed, Nov 18, 2015 at 12:13:09PM -0500 I heard the voice of Kenneth D. Merry, and lo! it spake thus: > > Testing and comments are welcome. GELI does explicit handling of each BIO type, so will need to be updated to pass it through (possibly in the form of inverting the default handling?) or

Re: CAM Shingled Disk support patches available

2015-11-19 Thread Kenneth D. Merry
On Thu, Nov 19, 2015 at 12:48:41 -0600, Matthew D. Fuller wrote: > On Wed, Nov 18, 2015 at 12:13:09PM -0500 I heard the voice of > Kenneth D. Merry, and lo! it spake thus: > > > > Testing and comments are welcome. > > GELI does explicit handling of each BIO type, so will need to be > updated to

CAM Shingled Disk support patches available

2015-11-18 Thread Kenneth D. Merry
I have work in progress patches to add SMR (Shingled Magnetic Recording) support to CAM and GEOM here: FreeBSD/head as of SVN revision 290997: https://people.freebsd.org/~ken/cam_smr.head.20151117.1.txt FreeBSD stable/10 as of SVN revision 290995: