Re: Dummynet messages

2003-01-20 Thread Maxim Konovalov
On 23:43+0100, Jan 19, 2003, Wiktor Niesiobedzki wrote:

 Hi,

 sys/netinet/ip_dummynet.c:
 975:   if (q-avg = fs-max_th) { /* average queue =  max threshold */
 (...)
 984:} else {
 985:q-count = -1;
 986:   printf(- drop);
 987:return 1 ;
 989:}

 is quite meaningless. Shouldn't be it at least DEB(printf(- drop)? Or
 better drop - max_th exceeded?

 Just a small proposition, I was quite confused, when I saw this message.

Fixed in rev. 1.61 sys/netinet/ip_dummynet.c, thanks.

-- 
Maxim Konovalov, [EMAIL PROTECTED], [EMAIL PROTECTED], +7 (095) 796979

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Dummynet messages

2003-01-19 Thread Wiktor Niesiobedzki
Hi,

sys/netinet/ip_dummynet.c:
975:   if (q-avg = fs-max_th) { /* average queue =  max threshold */
(...)
984:} else {
985:q-count = -1;
986:   printf(- drop);
987:return 1 ;
989:}

is quite meaningless. Shouldn't be it at least DEB(printf(- drop)? Or 
better drop - max_th exceeded?

Just a small proposition, I was quite confused, when I saw this message.

Best regards,

Wiktor Niesiobedzki

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message